- Issue created by @axroth
- 🇫🇷France jenue1933 Bordeaux
Hi! I completely agree with you. This module needs to populate a domain record for the current nodes after installation.
We should implement a hook_install to handle this. IMO, we should use the field_domain_source data if the domain_source module is installed.
This module provides a single URL for a matching node/domain, while if you use domain_access, there can be multiple domains linked to a single node.
What do you think?
- Status changed to Needs work
about 1 year ago 2:46pm 29 October 2023 - First commit to issue fork.
- Merge request !2Import domain ids on install form domain_source or domain_access. → (Merged) created by alexrayu
- Status changed to Needs review
12 months ago 2:19pm 22 November 2023 - 🇧🇬Bulgaria alexrayu
Created a MR, please check. Attaching the patch for convenience.
- 🇧🇬Bulgaria alexrayu
Debugged and fixed the commented logic, without which the code does not apply and original uniquifier is used.
Attaching the patch for those who may need it. (code is in MR2).
Please check. - 🇫🇷France jenue1933 Bordeaux
Thx for your MR. Currently very busy these days, but will check and review next week.
- 🇫🇷France jenue1933 Bordeaux
Hi!
some reviews on your MR.
Can you rebase your branch plz ?
For information, I changed the default branch, now it's 1.x. It's our working branch now.
- Status changed to Needs work
11 months ago 9:17pm 5 December 2023 - Status changed to Needs review
11 months ago 2:28pm 20 December 2023 - 🇧🇬Bulgaria alexrayu
Thanks for checking it. Updated, rebased, resolved conflict.
Please check the updated MR. - Status changed to Fixed
11 months ago 9:36am 25 December 2023 - Status changed to Fixed
10 months ago 10:38am 6 January 2024