alexpott → credited percoction → .
Rerolled the patch against 10.3.x and pushed up a branch to the issue fork. Also added a static patch here
percoction → made their first commit to this issue’s fork.
Pushed up two branches on the issue fork (they are basically the same, cloned from the 10.2.x branch).
The branches include two new FunctionalJavascript tests that test adding a AJAX callback to a Form programmatically utilizing each of the two HTTP methods GET and POST. The test using a POST AJAX callback should succeed and the test using a GET AJAX callback should fail, demonstrating the bug.
Going to remove the Needs tests tag - please let me know if we really need tests on a 11.x branch as well before removing this tag.
Just commenting here to update: I've started working on this at DrupalCon2024 Portland.
Was (I believe) able to reproduce the bug on 11.x branch on a DrupalPod. I say I believe because I receive an error using GET method where I don't with a POST method, but I am not sure how to inspect requests / set breakpoints in DrupalPod yet.
Going to work on adding a test to core to prove / reproduce the bug
Rerolling for 1.16.0
@gaëlg Why remove the bug fix from b10f1269e4dcda05c25eee0abcc0330781c523f1 in the latest commits to Merge request #4? Must this bug be coming from somewhere else than this module?
Hey, just pushed a commit to address the issue I mentioned in #110 ✨ Drupal 10 & CKEditor 5 readiness Fixed
Please let me know if there is any related code that I should update besides this.
(I could also clean up that \Drupal::service() call and properly inject the extension.list.module service while I'm at it)
In Text formats and editors config the new default entity.svg embed button icon is properly being loaded for ckeditor5 editors, but in Embed buttons config the old default entity.png icon is being loaded.
This is also being reported as an error on the status report page
percoction → made their first commit to this issue’s fork.
Adding patch
percoction → created an issue.
As .patch and .diff files automatically generated from MRs on Gitlab may change as new commits are pushed, and similarly to the recommendation to download local copies of the patches to use in your workflow, I'm uploading a patch here, a copy of the current diff generated from the MR, that applies to the current latest commit of the 8.x-1.x-dev branch.
Note: We have to target the 8.x-1.x-dev branch here instead of the latest 8.x-1.0-beta3 release as D.O. releases modify the composer.json file, which, I believe, was disallowing the patch to be applied.
percoction → created an issue.