- Issue created by @percoction
- Assigned to paulocs
- ๐บ๐ธUnited States jrockowitz Brooklyn, NY
Thanks. Let's make sure to include the manual steps required to test this change.
- ๐ฎ๐ณIndia Sandeep Sanwale
Sandeep Sanwale โ made their first commit to this issueโs fork.
- Merge request !452Issue #3336931 by paulocs: [Deprecation] Replace deprecated jQuery :tabbable selector โ (Merged) created by Sandeep Sanwale
- last update
12 months ago 536 pass - Status changed to Needs review
12 months ago 10:49am 9 April 2024 - ๐ฎ๐ณIndia Sandeep Sanwale
I have replace deprecated jQuery :tabbable selector with the core/tabbable library included with core. To test this you need to check on add element when modal opens it should foucs on first input element same on edit operation. Please review . Thank you
- ๐บ๐ธUnited States jrockowitz Brooklyn, NY
@Sandeep Sanwale, Thank you for working on this.
One immediate tweak is to include the tabbable library as a dependency when needed.
We'll have to document the manual steps required to verify that things continue to work as expected.
- last update
12 months ago 536 pass - ๐ฎ๐ณIndia Sandeep Sanwale
I have added the tabbable library as a dependency when needed. please review this .
- ๐บ๐ธUnited States jrockowitz Brooklyn, NY
Yep, we need to fix this before a stable release of 6.3. This is causing JS errors.
- ๐บ๐ธUnited States jrockowitz Brooklyn, NY
Looks good. I made minor tweaks to the codemirror libraries and copied how core was implementing tabbable using
tabbable.tabbable
Below are my manual steps to review the change
- Check pressing escape when inside core mirror element, tabs to the next element. (/form/example-style-guide)
- Check when webform builders opens and closes sidebar as expected (/admin/structure/webform/manage/contact)
- Check that autofocus="autofocus" attribute in add element dialog works as expected (/admin/structure/webform/manage/contact)
- ๐บ๐ธUnited States jrockowitz Brooklyn, NY
Marking this RTBC and assuming all the tests will pass.
-
jrockowitz โ
committed efca0aa2 on 6.3.x authored by
sandeep sanwale โ
Issue #3336931 by jrockowitz, sandeep sanwale, paulocs, percoction: [...
-
jrockowitz โ
committed efca0aa2 on 6.3.x authored by
sandeep sanwale โ
-
jrockowitz โ
committed efca0aa2 on 6.x authored by
sandeep sanwale โ
Issue #3336931 by jrockowitz, sandeep sanwale, paulocs, percoction: [...
-
jrockowitz โ
committed efca0aa2 on 6.x authored by
sandeep sanwale โ
Automatically closed - issue fixed for 2 weeks with no activity.