- Issue created by @arnaud-brugnon
- Status changed to Needs review
11 months ago 4:39pm 14 December 2023 - last update
11 months ago 45 pass, 4 fail - last update
11 months ago 45 pass, 4 fail The last submitted patch, 2: 3408813-2.patch, failed testing. View results โ
- Status changed to Needs work
11 months ago 4:50pm 14 December 2023 - First commit to issue fork.
- Status changed to Needs review
11 months ago 5:54am 18 December 2023 - last update
11 months ago 51 pass - ๐ฎ๐ณIndia viren18febS
I have resolved the issue & added patch, please review.
- last update
11 months ago 51 pass - ๐ซ๐ทFrance ckhalilo
Must add string in front of function getDescription()
public function getDescription() :string {
Env
- PHP8.2
- D10.2 - last update
11 months ago 32 pass - ๐ฉ๐ชGermany Goldfit
I have resolved the issue with the provided changes.
- last update
11 months ago 32 pass - last update
11 months ago 32 pass - last update
11 months ago 32 pass - last update
11 months ago 32 pass - last update
11 months ago 32 pass - ๐ฎ๐ณIndia siddharthjain
The patch shared in #9 applies smoothly. Thanks for the patch @Goldfit
- Status changed to RTBC
11 months ago 4:52pm 9 January 2024 - ๐ฌ๐งUnited Kingdom Alina Basarabeanu
We came across the same error after upgrading to Drupal core 10.2.
The patch provided by #9 fixed the issue.
Please add this to a new stable release. - ๐ฎ๐ณIndia ananthakrishnan.kr
After upgrading to Drupal core 10.2 we also came across the same error.
Patch #9 ๐ Fatal error: Declaration of Drupal\lightning_core\ConfigEntityDescriptionTrait::getDescription() must be compatible with Drupal\Core\Entity\EntityDisplayModeBase::getDescription(): string RTBC fixed the issue. - ๐ฎ๐ณIndia manikandank03 Tamil Nadu
I am also facing the same issue after upgrade Drupal 10.2.2 with PHP 8.2 and tried this patch #9, the issue fixed now and site was working fine.
- ๐บ๐ธUnited States SamLerner
The patch in #9 worked for me as well, upgrading to 10.2 with PHP 8.1. Thanks!
- First commit to issue fork.
- last update
6 months ago 45 pass, 4 fail - last update
6 months ago Composer require-dev failure - last update
6 months ago 51 pass - ๐ฆ๐ซAfghanistan drupalam
I ran into this issue with the `lightning_core` module following an upgrade of Drupal from version 10.1.8 to 10.3.1. Unfortunately, patch number 9 was ineffective for me because I needed to fix both functions in the `ConfigEntityDescriptionTrait.php` file. The patch provided below resolved the problem and I will create a Merge Request to make it permanent.
- ๐ญ๐บHungary Balu Ertl Budapest ๐ช๐บ
Marking as a blocker of ๐ Automated Drupal 11 compatibility fixes for lightning_core + enable GitLab CI Needs review .
- ๐จ๐ฆCanada puregin
@drupalam, sorry to be weighing in on this late in the game, but we have in
core/lib/Drupal/Core/Entity/EntityDescriptionInterface.php
the following:/** * Sets the entity description. * * @param string $description * The entity description. * * @return $this */ public function setDescription($description);
It seems that
setDescription()
returns$this
(an EntityDescriptionInterface), so trying to coerce the result to a string as in #21 is going to give a type error, unless I'm missing something. - ๐จ๐ทCosta Rica mariaannuar
@puregin was correct! Hereโs a solution to this