- Issue created by @Roshni_Kodiganti
- 🇮🇳India Roshni_Kodiganti
updated drupal core version to ^10 in composer.json file.
- Issue was unassigned.
- Status changed to Needs review
about 1 year ago 2:26am 5 October 2023 - First commit to issue fork.
- 🇮🇳India bhanu951
Updated patch to include 8.x compatibility as it is compatible with 8.x as well.
- Status changed to RTBC
7 months ago 1:42am 23 April 2024 - 🇳🇿New Zealand Gold 20 minutes in the future
Both of these get a +1 from me. I would suggest the patch at #2 though. Drupal Core 8.x has been EOL'd for quite a while now. If it is advertised as supporting it it means the devs will need to accept issues on that version.
- Status changed to Needs work
7 months ago 1:52am 23 April 2024 - 🇳🇿New Zealand Gold 20 minutes in the future
Scratch that. While this is technically correct and will allow the module to be installed via composer it won't let the module be enabled.
@Bhanu951, @Roshni_Kodiganti, could you both update your patches to include Drupal 10 in the announcement_modal.info.yml file too.
core_version_requirement: ^8 || ^9 || ^10 - First commit to issue fork.
- 🇮🇳India mukesh-kumar3 Dharmshala
@Gold I have changed announcement_modal.info.yml to let the module to be enabled in drupal 10.
- Status changed to Needs review
7 months ago 4:49am 23 April 2024 - 🇮🇳India siddharthjain
Here is the updated patch, which includes updates related to core_version_requirement and removed drupal/core from composer.json as its is not required as per D.O documentation https://www.drupal.org/docs/develop/using-composer/add-a-composerjson-file →
- First commit to issue fork.
-
akshay_d →
committed 5d6f8ba4 on 8.x-1.x authored by
Bhanu951 →
Issue #3391794: Make module Drupal 10 Compatible.
-
akshay_d →
committed 5d6f8ba4 on 8.x-1.x authored by
Bhanu951 →
- Status changed to Fixed
4 months ago 10:25am 19 July 2024