Deprecated function: strpos(): Passing null to parameter #1 ($haystack) of type string is deprecated

For this branch we still need to support PHP 7, so using str_contains() is not going to work.

Clearly the test coverage doesn't hit that line, so we should add some more testing.

Benji points out that the str_contains() is provided on php 7 by symfony/polyfill-php80, so the patch code should work either way

I am actually not sure whether it is polyfill-php80 or polyfill-php72 or polyfill-php73. Maybe the first one provides compatibility for sites using PHP 8.0? But I did test using PHP 7.4:

$ ddev drush php
Psy Shell v0.10.8 (PHP 7.4.33 — cli) by Justin Hileman
>>> str_contains('foobar', 'bar')
=> true
>>> str_contains(null, 'bar')
=> false
>>> \q

I did not test, but the patch is simple and looks like it should work, so +1/2 for RTBC.

If the maintainers want steps to reproduce the bug, then I think PMNMI is the right issue status. Besides steps to reproduce, a stach trace may be helpful.

This issue is most likely caused by the same issue as 🐛 Deprecation message on validation of empty file key Fixed . While KeyProviderInterface::getKeyValue() currently states that the return statement should always be a string, this seems to currently not be the case, for example when using the environment and file key types.

I've also created 🐛 KeyProviderInterface::getKeyValue() doesn't always return a string Needs review upstream, so we can some clarification on this issue.

I have faced the same issue and the patch #3 works for me. Just re-rolling it for version 8.x-1.1 to use it with the latest 1.x release.

How about this version?

If people are seeing this for real, please suggest a test case we can add. I'll note the bug is fixed in a different way in the 2.x branch

Automatically closed - issue fixed for 2 weeks with no activity.