Provide a way to disable "select all on all pages"

I created patch for to use.

The client almost deleted 15,000 contents out of inattention, but we managed to solve it from the backup.
This is UX problem.

Patch #10 doesn't fix notes from https://git.drupalcode.org/project/views_bulk_operations/-/merge_request...

Graber can you propose a good solution how to fix this?

Just address my comments on the PR. The patch in #10 contains exactly the changes from the PR at the time of writing this.

@graber I'm surprised by some of your comments in PR. Seems like you don't see a use case of he patch.
Atm we have only two options for the behavior:
- checked - Always show selection info
- unchecked - Calculated way to determine wheter we need to show it or not

And we don't have any way to hide that block at all.
This patch provides such a way.

I updated a patch a bit, to fix the schema.
But this is not ready solution yet, we also need to provide an upgrade path.

Also, MR used outdated source branch, so I made a new one and updated the patch file.

Is there a patch that works with 4.2.5? Thanks

Attaching a patch of the latest merge request against 4.2.5.

Patch in 21 works with 4.2.6. It also hide the element "Selected X items"

On case of the patch referenced in #21 📌 Provide a way to disable "select all on all pages" Needs work tests fail. The MR on the other hand looks good byt the select description needs updating so users know what's the "Default behavior". Also, in the MR there's a schema update which means we'll need an update hook for any existing config.

Still needs work in any case.

Attaching a patch against 4.3.4.

The patch in #25 works exactly as expected. +1 for RTBC.

mparker17 → changed the visibility of the branch 4.3.x to hidden.

I've turned the patch by @knyshuk.vova in #25 📌 Provide a way to disable "select all on all pages" Needs work into a merge request.

Next, I'll address the issue identified in #27 📌 Provide a way to disable "select all on all pages" Needs work .

Interesting, I don't see changes in any patches or merge requests that address the issue identified in #27 📌 Provide a way to disable "select all on all pages" Needs work .

We should also add tests.

To prove to myself what was going on, I added a test.

With the patch in this issue...

1. The 'Default Behavior' (i.e.: force_selection_info = '') is to:
   1. hide the 'Select / deselect all results (all pages, N total)' checkbox (i.e.: input name="select_all") when the table is empty (0 results)
   2. hide the 'Select / deselect all results (all pages, N total)' checkbox (i.e.: input name="select_all") when the table has 1 page of results
   3. show the 'Select / deselect all results (all pages, N total)' checkbox (i.e.: input name="select_all") when the table has 2+ pages of results
2. The 'Always show' (i.e.: force_selection_info = 'show') is to:
   1. hide the 'Select / deselect all results (all pages, N total)' checkbox (i.e.: input name="select_all") when the table is empty (0 results)
   2. show the 'Select / deselect all results (all pages, N total)' checkbox (i.e.: input name="select_all") when the table has 1 page of results
   3. show the 'Select / deselect all results (all pages, N total)' checkbox (i.e.: input name="select_all") when the table has 2+ pages of results
3. The 'Always hide' (i.e.: force_selection_info = 'hide') is to:
   1. hide the 'Select / deselect all results (all pages, N total)' checkbox (i.e.: input name="select_all") when the table is empty (0 results)
   2. hide the 'Select / deselect all results (all pages, N total)' checkbox (i.e.: input name="select_all") when the table has 1 page of results
   3. hide the 'Select / deselect all results (all pages, N total)' checkbox (i.e.: input name="select_all") when the table has 2+ pages of results

Given the above behavior, regarding the comment in #27...

The patch in #25 works fine. However, it doesn't provide the option to disable the (Select / deselect all results) which is what this ticket is basically about.

My understanding is that the 'Always hide' (i.e.: force_selection_info = 'hide') is a way to disable the "Select / deselect all results" checkbox? But maybe @alfattal is talking about something else, and I am misunderstanding #27?

I've pushed an update hook to fix existing views (and I wrote a test for the update hook).

I also put a Choice constraint on the force_selection_info configuration

Looking at the configuration form control, I find it a bit confusing.

    $form['force_selection_info'] = [
      '#type' => 'select',
      '#title' => $this->t('Force show selection info state'),
      '#default_value' => $this->options['force_selection_info'],
      '#description' => $this->t('Should the selection info fieldset be shown above the view even if there is only one page of results and full selection can be seen in the view itself?'),
      '#options' => [
        '' => $this->t('Default Behavior'),
        'show' => $this->t('Always show'),
        'hide' => $this->t('Always hide'),
      ],
    ];

At the very least, I would recommend that we change the key/label of the "Default" option — neither the key (i.e.: an empty string) nor the label ("Default Behaviour") describes what it does very well. Maybe something like 'only_multiple' => $this->t('Only when there are multiple pages'),?

I daresay the title and description could be reworded as well, but I don't want to derail the discussion either.

@graber what are your thoughts as a maintainer?

Moving back to "Needs Review"

At the very least, I would recommend that we change the key/label of the "Default" option — neither the key (i.e.: an empty string) nor the label ("Default Behaviour") describes what it does very well.

Yes but from what I remember there may be more conditions. Should check first.

Yes but from what I remember there may be more conditions. Should check first.

@graber, I apologize, but are you asking me to check if there are more conditions? (I'm happy to try, but I'm asking for clarification because I don't want to be a bottleneck)

@mparker17 Thank you for your comments and work on this issue and sorry if my comment in #27 📌 Provide a way to disable "select all on all pages" Needs work wasn't clear enough. The patch in #25 📌 Provide a way to disable "select all on all pages" Needs work as well as MR!103 hides the whole selection box which is useful for deselecting selected files.

In the screenshot below, I've managed to hide the "select all on all pages" checkbox and link using CSS display: none.

As you can see, the selection box in the middle is still showing which allow users to deselect the files

@alfattal, got it, thanks! I'll take a look!

@alfattal, I've figured out a way to make the visibility of the "Items selected" details box independent from the visibility of the "Select / Deselect all results (all pages)" checkbox.

I'm uploading it as a patch because it goes a bit further out-of-scope than what @jerrylow originally proposed as their own solution to the issue they filed (also, Hi @jerrylow! 👋). If the other people in this issue agree that this is the direction that they want to go, I'll simply push the commit from my local.

I've uploaded a patch to 4.3.x as is tradition; as well as an interdiff from the most-recent-commit to the merge request (commit 51e5c5c2) to show the proposed changes for someone already familiar with what's in the merge request.

Feedback (from everyone in this issue, as well as the maintainers) is welcome!

You can see in the attached screenshots that I've replaced the "Force show selection info state" with two controls: a control to change the visibility of the "Items selected" details element, and a separate control to change the visibility of the "Select / Deselect all results (all pages)" checkbox.

Screenshot of config page and resulting view, configured to only show the selection box:

Screenshot of config page and resulting view, configured to only show the select all checkbox:

Screenshot of config page and resulting view, configured to show neither selection control

Screenshot of config page and resulting view, configured to show both selection controls:

@mparker17 Thank you so much for your work. The patch in #42 works flawlessly and it's precisely what this ticket is about. +1 for RTBC.

@alfattal, awesome, I have pushed the commit! Reviews welcome!