Create specific permissions for administer unmanaged file

Created on 27 April 2022, over 2 years ago
Updated 1 June 2023, over 1 year ago

Problem/Motivation

All users with permission access administration pages can access this feature. A contributor role doesn't need this functionality.

Proposed resolution

Create a specific permissions to access the admin page of this feature.

✨ Feature request
Status

RTBC

Version

1.0

Component

Code

Created by

πŸ‡«πŸ‡·France egruel

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • πŸ‡©πŸ‡ͺGermany broon Potsdam

    Good and useful addition, working fine.

  • πŸ‡ΊπŸ‡ΈUnited States alfattal Minnesota

    The MR in #2 and patch in #3 works fine. However, I have a use case where a role with the permission to "Delete any files" needs to have access to the "Unmanaged File List" to perform cleaning, but this role should NOT have access to the "Unmanaged File Settings".

    The current patch removes access to both. Hence, we need more granular permissions to limit the access to the settings separately from the access to the list.

  • Status changed to Needs review over 1 year ago
  • πŸ‡§πŸ‡ͺBelgium daften

    A new patch file with separate permissions.

    IMO the unmanaged files list could be put in the content menu, but that's a separate issue if other people agree it would be better.

  • Status changed to Needs work over 1 year ago
  • πŸ‡ΊπŸ‡ΈUnited States alfattal Minnesota

    @daften I've applied your patch in #6, went to the permissions and granted a specific role the access to administer tasks only but seems like nothing has changed. That role and every role still have access to Administer unmanaged files and Administer unmanaged files settings. For this reason, I'm changing the status to Needs work.

  • Status changed to Needs review over 1 year ago
  • πŸ‡³πŸ‡΄Norway vegardjo

    Hi, I can't reproduce #7.

    I have tested this with 3 different roles, one that has only the "administer unmanaged files", one that has only the "administer unmanaged files settings" and one that has none, and it works like expected. I had to clear cache after applying the patch, though.

  • Status changed to RTBC over 1 year ago
  • πŸ‡ΊπŸ‡ΈUnited States alfattal Minnesota

    @vegardjo Thank you for the cache clearing tip. I've made another test for the patch in #6 and after clearing the cache, I can confirm that it's working as expected. Moving this to RTBC!

Production build 0.71.5 2024