Resave method not implemented

Attached is a patch for the 2.x branch.

Patch in #14 failed to apply with the following error:

Could not apply patch! Skipping. The error was: Cannot apply patch https://www.drupal.org/files/issues/2023-10-17/3073426-10-2.x.patch
Unhandled promise rejection with ArgumentCountError: Too few arguments to function React\Promise\Promise::React\Promise\{closure}(), 0 passed in phar:///usr/local/bin/composer/src/Composer/Installer/InstallationManager.php on line 660 and exactly 1 expected in phar:///usr/local/bin/composer/vendor/react/promise/src/Promise.php:277
Stack trace:
#0 phar:///usr/local/bin/composer/src/Composer/Installer/InstallationManager.php(660): React\Promise\Promise::React\Promise\{closure}()
#1 phar:///usr/local/bin/composer/vendor/react/promise/src/Internal/FulfilledPromise.php(47): Composer\Installer\InstallationManager::Composer\Installer\{closure}()
#2 phar:///usr/local/bin/composer/src/Composer/Installer/InstallationManager.php(661): React\Promise\Internal\FulfilledPromise->then()
#3 phar:///usr/local/bin/composer/vendor/react/promise/src/Promise.php(288): Composer\Installer\InstallationManager::Composer\Installer\{closure}()
#4 phar:///usr/local/bin/composer/vendor/react/promise/src/Promise.php(37): React\Promise\Promise->call()
#5 phar:///usr/local/bin/composer/src/Composer/Installer/InstallationManager.php(663): React\Promise\Promise->__construct()
#6 phar:///usr/local/bin/composer/src/Composer/Installer/InstallationManager.php(221): Composer\Installer\InstallationManager->runCleanup()
#7 phar:///usr/local/bin/composer/src/Composer/Installer.php(791): Composer\Installer\InstallationManager->execute()
#8 phar:///usr/local/bin/composer/src/Composer/Installer.php(292): Composer\Installer->doInstall()
#9 phar:///usr/local/bin/composer/src/Composer/Command/InstallCommand.php(147): Composer\Installer->run()
#10 phar:///usr/local/bin/composer/vendor/symfony/console/Command/Command.php(298): Composer\Command\InstallCommand->execute()
#11 phar:///usr/local/bin/composer/vendor/symfony/console/Application.php(1040): Symfony\Component\Console\Command\Command->run()
#12 phar:///usr/local/bin/composer/vendor/symfony/console/Application.php(301): Symfony\Component\Console\Application->doRunCommand()
#13 phar:///usr/local/bin/composer/src/Composer/Console/Application.php(382): Symfony\Component\Console\Application->doRun()
#14 phar:///usr/local/bin/composer/vendor/symfony/console/Application.php(171): Composer\Console\Application->doRun()
#15 phar:///usr/local/bin/composer/src/Composer/Console/Application.php(145): Symfony\Component\Console\Application->run()
#16 phar:///usr/local/bin/composer/bin/composer(88): Composer\Console\Application->run()
#17 /usr/local/bin/composer(29): require('...')
#18 {main}

In Patches.php line 331:
                                                                                                                                       
  Cannot apply patch 3073426-14: Resave method not implemented (https://www.drupal.org/files/issues/2023-10-17/3073426-10-2.x.patch)!

The patch applies for me and it works fine except that handlers are called.

I think the `::doPostSave()` method runs the handlers again.

Instead of doPostSave, all we need is to set the data back to the decrypted data.

I've updated the patch.

Hello

I have just run into this problem and wrote my own resave() method as was done here in pretty much the same way.

However, there is an issue with this solution.

If you are using cron to process webform submissions programmatically and then update the entity at the end. Because the cron does not have a current user with permission to see the encrypted values the values in the entity object are '[Value Encrypted]' and this is what then gets encrypted and written back into the database. Not the original unencrypted data.

I guess this issue would be true of any method where a user or programmatic process is updating a submission not just through resave()?

The only thing I found to go on so far is doing this at the start of the code being triggered by the cron:

    // Call the account switcher service.
    $accountSwitcher = \Drupal::service('account_switcher');
    // Switch to the admin user.
    $accountSwitcher->switchTo(new \Drupal\Core\Session\UserSession(['uid' => 1]));

See https://drupal.stackexchange.com/a/316471

Then when the code hits then \Drupal\webform_encrypt\WebformEncryptSubmissionStorage::decrypt method the currentUser is the default admin user (1).

I will have a further investigation tomorrow. It may be that the resave() method needs extra protection against it accidentally overwriting the real data with the encrypted '[Value Encrypted]' string.

Cheers, Neil