Implement Drupal Dialog API instead of bootstrap to show Modal

I am interested on it, because my main theme has bootstrap 4 and the admin theme (GIN) does not have bootstrap.

Thanks @marcusvsouza - I'll check out your merge request. Bootstrap is great if your custom theme is already using it, but adding it to the front end globally causes a number of conflicts on my end. I haven't seen much movement on this in awhile so wanted to make a note. If I have some time I'll see what I can contribute.

Bootstrap is great if your custom theme is already using it, but adding it to the front end globally causes a number of conflicts on my end

agreed, using Drupal Dialog API without dependency of BS would be amazing

If I have some time I'll see what I can contribute

Awesome! Really appreciated @jeffc518

@jeffc518 I'm also very interested in this change for the same reasons.

@renatog, I haven't seen an update in a while, so I'll try to spend some time on it and get it going. I see that v5 is now available. Do you think we should make it work directly with v5, or continue with 4.x?

Thank you so much @zeshan.ziya

Do you think we should make it work directly with v5, or continue with 4.x?

v5 is better

We'll focus updates on 5.x so makes sense use this version

Hi @renatog, I am almost done with the changes. I am doing some final testing. I need help opening the merge request. I don't see an option to open the merge request. Can you please help with the same?

Hi @renatog, I have raised an MR. Please review. Please let me know if any changes are required.

Wow! Seems awesome! Thank you so much @zeshanziya

Moving to NR so we can validate. Anyone are welcome to help testing as well

If it works fine we can create 5.1.0-beta1 with this

zeshan.ziya → changed the visibility of the branch 3281106-implement-drupal-dialog to hidden.

I tried to apply the MR as a local patch, but it failed to apply.

Hey @alfattal, thanks for giving it a try. I don’t have much experience with patching, but here’s what worked for me.

1. Download the diff from https://git.drupalcode.org/project/modal_page/-/merge_requests/42.diff.
2. Apply the patch with: `patch < 42.diff`

@zeshan.ziya Sorry for the late response. I've successfully applied the patch from the PR and I can confirm that it is working properly. 1 for RTBC!

I can confirm that it is working properly. 1 for RTBC!

Great! Thanks for testing

Moving that to RTBC to be merged soon

Any news? we tested it, and works properly.

Sorry, I didn't have time to merge that before but it's on my plans

I'll test that and merge as soon as possible

Any news? we tested it, and works properly

Tested and confirmed that it works fine

Merged to the dev branch: 6.0.x

Since it's a considerable milestone we're going to create a beta-version based on 6.x and keep the stable on 5.x

After a time when it's tested by users, we'll make 6.x stable

Thanks everyone, it's amazing

Automatically closed - issue fixed for 2 weeks with no activity.