๐Ÿ‡ฎ๐Ÿ‡ณIndia @zeshan.ziya

Account created on 23 September 2013, over 11 years ago
#

Merge Requests

Recent comments

๐Ÿ‡ฎ๐Ÿ‡ณIndia zeshan.ziya

Thanks, @stasadev, for highlighting the upcoming change in DDEV!

You're absolutely rightโ€”itโ€™s not an ideal approach to create a DDEV project inside another DDEV project. However, since it was allowed previously, I considered that scenario.

๐Ÿ‡ฎ๐Ÿ‡ณIndia zeshan.ziya
if [ "${n}" -gt 0 ]; then
  NAME=${NAME}-$((n + 1))
fi

This looks correct, but I see one issue: if I run the script again by mistake, it will create a new project each time instead of starting the current project. It keeps appending a numeric suffix to the name each time it runs.

With @stasadev's suggestion, I see another issue. If we try to install it inside inner directories of any DDEV project, it will not work as expected. This is because `ddev describe` will return the project from the parent directory instead of the current directory. So, a more reliable approach could be:

# Check if a DDEV project exists in the current directory only
if [ ! -f .ddev/config.yaml ]; then
  NAME=$(basename $PWD)
  # If there is any other DDEV project with the same name, add a numeric suffix
  if ddev describe "${NAME}" >/dev/null 2>&1; then
    NAME="${NAME}-1"
  fi
  # Configure a new project
  ddev config --project-type=drupal11 --docroot=web --php-version=8.3 --ddev-version-constraint=">=1.24.0" --project-name="$NAME"
fi
๐Ÿ‡ฎ๐Ÿ‡ณIndia zeshan.ziya

I have sent a message on Drupal slack to @misc and @javivf. Let's see if we get a response there.

๐Ÿ‡ฎ๐Ÿ‡ณIndia zeshan.ziya

Thanks @renatog, yes, it's ready for review.

๐Ÿ‡ฎ๐Ÿ‡ณIndia zeshan.ziya

Yes, I was because of hidden variable inside enable footer section in template file. I have moved it outside.

๐Ÿ‡ฎ๐Ÿ‡ณIndia zeshan.ziya

zeshan.ziya โ†’ made their first commit to this issueโ€™s fork.

๐Ÿ‡ฎ๐Ÿ‡ณIndia zeshan.ziya

Hey @alfattal, thanks for giving it a try. I donโ€™t have much experience with patching, but hereโ€™s what worked for me.

1. Download the diff from https://git.drupalcode.org/project/modal_page/-/merge_requests/42.diff.
2. Apply the patch with: `patch < 42.diff`

๐Ÿ‡ฎ๐Ÿ‡ณIndia zeshan.ziya

zeshan.ziya โ†’ changed the visibility of the branch 3281106-implement-drupal-dialog to hidden.

๐Ÿ‡ฎ๐Ÿ‡ณIndia zeshan.ziya

Hi @renatog, I have raised an MR. Please review. Please let me know if any changes are required.

๐Ÿ‡ฎ๐Ÿ‡ณIndia zeshan.ziya

Hi @renatog, I am almost done with the changes. I am doing some final testing. I need help opening the merge request. I don't see an option to open the merge request. Can you please help with the same?

๐Ÿ‡ฎ๐Ÿ‡ณIndia zeshan.ziya

@renatog, I haven't seen an update in a while, so I'll try to spend some time on it and get it going. I see that v5 is now available. Do you think we should make it work directly with v5, or continue with 4.x?

๐Ÿ‡ฎ๐Ÿ‡ณIndia zeshan.ziya

Yes @jurgenhaas, Implementing the use of a configurable cache lifetime seems to be a worthwhile consideration. Furthermore, I'd like to propose the inclusion of a timestamp that displays the data's last retrieval time. This enhancement would provide users with insight into the recency of the present data.

Production build 0.71.5 2024