Extra options depend on "Modal Footer" enabled

Created on 16 May 2023, almost 2 years ago

Problem/Motivation

Most options in the EXTRA tab only works if the modal footer is enabled and even the modal_id is not printed when the modal footer is not shown. The behavior is the same for both the 4.x and 5.x versions.
These options don't have any obvious connection to a modal footer and this is not documented anywhere, so I suspect it may be a bug in the modal-page-modal template logic.

Steps to reproduce

Add a modal;
Uncheck Show Modal Footer on MODAL FOOTER tab;
Change any options in the EXTRA tab, except "Modal By";
Open the page you added the modal to.

Result: the option does not apply.
Expected: all options apply regardless of footer enabled or disabled.

Proposed resolution

I propose we move the hidden inputs with modal_id and these configurations - delay_display, show_once, auto_hide, auto_hide_delay and height_offset outside the modal footer. These should go into a new hidden div just for modal configuration data and the JS would be adjusted.

Alternatively we could just note this behavior on Extras.

Remaining tasks

User interface changes

API changes

Data model changes

๐Ÿ› Bug report
Status

Active

Version

5.0

Component

Code

Created by

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

Production build 0.71.5 2024