- last update
11 months ago 23 pass - Status changed to Needs review
11 months ago 1:19pm 16 February 2024 - last update
11 months ago 22 pass, 1 fail - 🇺🇦Ukraine sickness29
I have usr #7 as base with some code quality changes and added functional test for argument handler.
Also fixed deprecation messages in ProfileRoleAccessTest. - last update
11 months ago 24 pass The last submitted patch, 11: default_argument-2835930-11.patch, failed testing. View results →
- Status changed to Needs review
11 months ago 1:37pm 16 February 2024 - last update
11 months ago 24 pass - last update
11 months ago 24 pass - 🇮🇱Israel jsacksick
Looks good at first glance, haven't tested it manually.
One thing though, can we simply implement the create method and skip overridding the constructor? This way we don't have to worry about potential breaking changes to the parent constructor.
So basically something like:
public static function create(ContainerInterface $container, array $configuration, $plugin_id, $plugin_definition) {
$instance = parent::create($container, $configuration, $plugin_id, $plugin_definition);
$instance->entityTypeManager = $container->get('entity_type.manager');
$instance->currentUser = $container->get('current_user');
return $instance;
}
- 🇮🇱Israel jsacksick
Also...
I see this comment:
Select the profile type to use. If a profile type is configured to support multiple profiles, it won't show up here as an option.
However, I don't actually see any code filtering out profile type allowing multiple profiles??
- last update
10 months ago 24 pass - 🇺🇦Ukraine sickness29
Hi @jsacksick
good catches, thanks. I have fixed both cases -
jsacksick →
committed 86825ee4 on 8.x-1.x
Issue #2835930 by sickness29, nedjo, drupalfan2, maaty388, jsacksick,...
-
jsacksick →
committed 86825ee4 on 8.x-1.x
- Status changed to Fixed
10 months ago 1:58pm 15 March 2024 -
jsacksick →
committed 457170d8 on 8.x-1.x
Issue #2835930 followup: Make the type setting required.
-
jsacksick →
committed 457170d8 on 8.x-1.x
- 🇸🇰Slovakia poker10
Should this settings be required even without a check if the profiles array is not empty? It seems like it is causing issues if there are no suitable profiles, the contextual filter cannot be saved now. Thanks!
Automatically closed - issue fixed for 2 weeks with no activity.