Time Field fails required field validation if value is 00:00

This issue should have been resolved in Time Field fails required field validation if value is 12:00 AM 🐛 Time Field fails required field validation if value is 12:00 AM Fixed but the merged in fix missed a certain part of the provided patches.

The validation error is caused when the time is set to midnight as the value resolves to 0 which is treated as empty by Drupal core.

This is resolved by modifying TimeElement::valueCallback() to cast the return value as a string.

This string cast is necessary to avoid FormValidator::doValidateForm() from considering midnight to be empty.
ie: the line with $is_empty_value = ($elements['#value'] === 0); will treat 0 (midnight) as an empty value where-as it will treat '0' as populated.

Thanks for the details answer and patch! Really helps when validating even a trivial patch like this. As far for the patch itself, it looks RTBC to me, but I think it should be easy to write a test case for this. I'll see if I find the time for that, or if someone else beats me to it 😉

Just confirming this patch works.

Sorry, target version should be 2.x-dev. Patch still works on current latest commit (https://git.drupalcode.org/project/time_field/-/commit/24b503688ad0bb27b...)

Rerolled patch from #2 and added Functional test for time field which checks the field with couple values

Added a test only patch

The last submitted patch, 8: empty_validation-3227128-7-testonly.patch, failed testing. View results →

Cool! Thanks everyone

Automatically closed - issue fixed for 2 weeks with no activity.