Great :D I see new releases already cut—thanks so much @mark_fullmer!
Thank you for the review and thorough testing scenarios @mark_fullmer! 🙏🏻🙏🏻
I think the bug @marcoscano referred to was with the clearing of match metadata stored in the link field's "options" array. I didn't actually test his patch until now, and found out it breaks a little worse than I thought. I expected:
Match metadata gets saved if autocomplete dropdown is clicked, but cleared if the user "keyups" in the textfield.
But it actually works like:*
Hidden form inputs always get cleared, even when the autocomplete dropdown is used to click an entity matcher and the user has no direct interaction with the textbox.
*Tested in Firefox on linux
Specifically, the options data we lose with the first patch are:
- data-entity-type
- data-entity-uuid
- data-entity-substitution
The approach in MR 28 attempts to be less aggressive in clearing the match metadata. Specifically when any portion of the link changes, besides query string and fragment.
MR !28 adds support for maintaining fragments and query strings (the issue that @marcoscano noted ✨ Linkit for Link field Fixed in the LinkIt for Fields issue).
hawkeye.twolf → made their first commit to this issue’s fork.
penyaskito → credited hawkeye.twolf → .
penyaskito → credited hawkeye.twolf → .
penyaskito → credited hawkeye.twolf → .
Also thank you Betty for the patch and thank you Marcos for such a quick release!!!! :D
+1 for always using `|clean_class` when printing classes in a template! :D
hawkeye.twolf → created an issue.
hawkeye.twolf → created an issue.
hawkeye.twolf → created an issue.
The field formatter option works great. Here's an updated patch to fix the PHP warning reported by @Greg Boggs in #31 ✨ Allow hiding display of country for domestic addresses Needs work .
hawkeye.twolf → created an issue.