- Issue created by @hawkeye.twolf
- @hawkeyetwolf opened merge request.
- Status changed to Needs review
over 1 year ago 9:39pm 28 March 2023 - πΊπΈUnited States hawkeye.twolf αα©α―αα Unalatogiyasdi, Tsalaguwetiyi (Cherokee country)
- Assigned to sickness29
- Status changed to Needs work
about 1 year ago 10:47am 21 November 2023 - Issue was unassigned.
- Status changed to Needs review
about 1 year ago 1:19pm 21 November 2023 - last update
about 1 year ago 33 pass - πΊπ¦Ukraine sickness29
Reworked to apply to latest 8.x-1.x, fixed few coding standard issues.
Renamed CountryNameTokenTest to AddressTokenTest and extended it to contain test case for new token - last update
11 months ago Patch Failed to Apply - Status changed to Needs work
11 months ago 3:47pm 30 December 2023 - π·πΈSerbia bojanz
Needs a reroll for 2.0.x.
We also need to add address_line3 the same way we added address_line2.
- Status changed to Needs review
11 months ago 2:24am 10 January 2024 - last update
11 months ago 44 pass - π¦π·Argentina tguerineau
I have created a patch for the 2.0.x.
I have adapted this patch for the 2.0.x branch, which includes support for an additional third address line.
Changes Made:
1. Renamed the token from'address_lines_both'
to'address_lines_combined'
to better reflect its functionality, as it now combines up to three address lines.
2. Updated the logic inaddress.tokens.inc
to handle the third address line. The token now correctly concatenates the available address lines, separating them with commas as appropriate.
3. Manually tested the new token with the Meta Tag module. I used the[node:field_address:address_lines_combined]
token in the default meta description for content. The token correctly outputs:- Just the first line when only the first address line is present.
- The first and second lines, separated by a comma, when both are present.
- All three lines, each separated by a comma, when all are present.
- No additional text in the meta description when the address field is empty.
- π·πΈSerbia bojanz
Thanks!
This is now 2.1.0 material, so bumping the version.