[Gitlab] PHPUnit tests fail after --verbose removed, and no scheduled pipelines exist

Made a start on getting everything green again

CSpell - Most words looked project specific, the only ones that I wasn't sure on are there are a few UI labels using British spelling (e.g. Neighbourhood instead of Neighborhood) - it looks from a quick scan that this was withing the context of screens where the US spelling is presented (e.g Organization instead of Organisation) so I assume these are genuine misspellings. Not fixed given they impact UI - wanted clarification first.

CSpell - organisation looks like it was used in the migration plugin - so its in the dictionary but perhaps should be just ignored in the plugin?

PHPCS - minor fixes

PHPStan - updated the baseline to ignore some deprecations related to things introduced in 10.3. Since 10.2 went out of security support this week, maybe we should just fix these now and have min 10.3 support? Will take maitainers direction here.

PHUnit - version 10 needs dataprovider related methods to be static - made these changes.

There are still 19 failures - 18 will be resolved by 📌 Drupal 11 compatibility fix for removed views default_argument_skip_url setting Active

The final one is:

18) Drupal\Tests\address\Unit\Plugin\Validation\Constraint\CountryConstraintValidatorTest::testValidate with data set #3 ('InvalidValue', 'The country %value is not valid.')
Prophecy\Exception\Prophecy\MethodProphecyException: The method "addViolation" has a void return type, and so cannot return anything
/builds/issue/address-3495167/vendor/phpspec/prophecy/src/Prophecy/Prophecy/MethodProphecy.php:256
/builds/issue/address-3495167/tests/src/Unit/Plugin/Validation/Constraint/CountryConstraintValidatorTest.php:60
/builds/issue/address-3495167/vendor/bin/phpunit:122

I have to divert my attention to something else now but its a start.

Setting to needs work for the above - but I think adding a scheduled pipeline is not blocked as if that is done now it will make it more visible that this is the current state. Cheers

Thank you for your efforts!

Since 10.2 went out of security support this week, maybe we should just fix these now and have min 10.3 support

That sounds fine, let's do that.

CSpell - Most words looked project specific, the only ones that I wasn't sure on are there are a few UI labels using British spelling (e.g. Neighbourhood instead of Neighborhood) - it looks from a quick scan that this was withing the context of screens where the US spelling is presented (e.g Organization instead of Organisation) so I assume these are genuine misspellings.

Yes, those are genuine misspellings we should fix.

I'll go ahead and commit 📌 Drupal 11 compatibility fix for removed views default_argument_skip_url setting Active now.

We now have a scheduled pipeline that runs daily.

I moved the cspell/phpstan changes to 📌 Fix cspell and phpstan builds Active and committed them there.

I'll fix the phpunit failure in a followup issue.

Automatically closed - issue fixed for 2 weeks with no activity.