Fix all code validate jobs running in GitLab CI

Whoot, https://git.drupalcode.org/project/address/-/pipelines/75265 is finally all green. 😅

I punted on a couple of the errors since they were a bit more complicated to fix than I care to spend the time on right now. Should probably open a follow-up for them. For now, put them in phpstan.neon:

 ------ -------------------------------------------------------------------------- 
  Line   src/Plugin/Field/FieldType/AddressItem.php                                
 ------ -------------------------------------------------------------------------- 
  357    Access to an undefined property                                           
         Drupal\address\Plugin\Field\FieldType\AddressItem::$langcode.             
         💡 Learn more:                                                            
            https://phpstan.org/blog/solving-phpstan-access-to-undefined-property  
  421    Access to an undefined property                                           
         Drupal\address\Plugin\Field\FieldType\AddressItem::$country_code.         
         💡 Learn more:                                                            
            https://phpstan.org/blog/solving-phpstan-access-to-undefined-property  
  429    Access to an undefined property                                           
         Drupal\address\Plugin\Field\FieldType\AddressItem::$langcode.             
         💡 Learn more:                                                            
            https://phpstan.org/blog/solving-phpstan-access-to-undefined-property  
 ------ -------------------------------------------------------------------------- 
 ------ -------------------------------------------------------------------------- 
  Line   src/Plugin/Field/FieldType/ZoneItem.php                                   
 ------ -------------------------------------------------------------------------- 
  75     Access to an undefined property                                           
         Drupal\address\Plugin\Field\FieldType\ZoneItem::$value.                   
         💡 Learn more:                                                            
            https://phpstan.org/blog/solving-phpstan-access-to-undefined-property  
 ------ -------------------------------------------------------------------------- 

I'd like to backport this to 8.x-1.x, and I believe the changes are all safe (enough).

Curious to see what you think.

Thanks!
-Derek

Opened 📌 Cleanup access to undefined properties in FieldType classes Active and pushed a @todo comment to phpstan.neon pointing there.

Thanks for MR, I provide feedback. Please check.

Thanks for the review! Addressed/resolved the threads. Yeah, it's much safer to deal with 📌 Use DI not \Drupal in src/Plugin/views/filter/AdministrativeArea.php Active separately to not introduce disruptions.

@bojanz: Any final concerns before I merge?

Looks good at a glance!

Great, thanks! Merged to 2.0.x and cherry picked to 8.x-1.x.

dww → closed merge request !43

Automatically closed - issue fixed for 2 weeks with no activity.