Fix PHPCS issues

Created on 1 September 2024, 8 months ago

PHPCS ensures that coding standards are followed consistently across a project. This makes it easier for developers to read and find the relevant code.

There are a number of issues identified by PHPCS that should be cleaned up.

🐛 Bug report
Status

Active

Version

3.0

Component

Code

Created by

🇺🇸United States John Franklin

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @John Franklin
  • Merge request !22Resolve #3471496 "Fix phpcs issues" → (Open) created by John Franklin
  • Pipeline finished with Failed
    8 months ago
    Total: 241s
    #271069
  • Pipeline finished with Failed
    8 months ago
    Total: 169s
    #271076
  • Status changed to Needs review 8 months ago
  • 🇺🇸United States John Franklin

    There is one test failing in the pipelines. The same test fails in other recent MRs.

  • Pipeline finished with Failed
    8 months ago
    Total: 163s
    #271120
  • Pipeline finished with Failed
    8 months ago
    Total: 160s
    #271127
  • 🇺🇸United States John Franklin

    The "test-pipelines" MR is 3.0.x, minus the LICENSE.txt file. The unit tests fail in exactly the same way when running against 3.0.x as they do the fix-phpcs-issues MR, I have to consider the MR to be valid.

  • 🇮🇳India riddhi.addweb

    I tried to apply both MR [22, 23] and it applied cleanly, but still, the errors are displayed. Still, PHPCS errors are there and not resolved. Attaching the SS for the same.

  • 🇺🇸United States John Franklin

    john franklin changed the visibility of the branch 3471496-test-pipelines to hidden.

  • 🇺🇸United States John Franklin

    MR 22 is the correct one. I've hidden 23 and deleted the branch from git. MR 22 passed PHPCS in the pipelines. I'll rerun it and see what comes back.

  • Pipeline finished with Failed
    7 months ago
    Total: 191s
    #294855
  • Pipeline finished with Failed
    7 months ago
    Total: 180s
    #295086
  • Pipeline finished with Failed
    7 months ago
    Total: 175s
    #295089
  • Pipeline finished with Failed
    6 months ago
    Total: 231s
    #322582
  • Pipeline finished with Failed
    6 months ago
    #322588
  • Pipeline finished with Failed
    6 months ago
    #322589
  • Pipeline finished with Failed
    6 months ago
    Total: 394s
    #322598
  • Pipeline finished with Canceled
    6 months ago
    Total: 84s
    #322638
  • Pipeline finished with Failed
    6 months ago
    Total: 192s
    #322641
  • 🇮🇳India kulpratap2002

    Working on it.

  • Pipeline finished with Success
    6 months ago
    Total: 177s
    #322935
  • Pipeline finished with Success
    6 months ago
    Total: 182s
    #322950
  • Pipeline finished with Success
    6 months ago
    Total: 246s
    #322974
  • 🇮🇳India kulpratap2002

    Pipeline passed with no warning and errors.

  • Pipeline finished with Success
    6 months ago
    Total: 172s
    #323141
  • Pipeline finished with Failed
    6 months ago
    Total: 161s
    #323147
  • Pipeline finished with Success
    6 months ago
    Total: 185s
    #323243
  • Pipeline finished with Failed
    6 months ago
    Total: 162s
    #323255
  • Pipeline finished with Failed
    6 months ago
    Total: 175s
    #323271
  • Pipeline finished with Canceled
    6 months ago
    Total: 407s
    #323264
  • 🇺🇸United States John Franklin

    Thanks for the updates @kul.pratap. A completely green pipeline is a lovely thing to see! I updated the cspell handling to inject unknown words in the `.gitlab-ci.yml` file instead of recreating the whole .cspell.json file, and backported the changes to the 3.x branch.

    @robert castelo, there are two MRs attached here:

    MR 22 - Applies updates to fix the "validate" class of tests in the pipeline for 3.0.x. This is as close as we're going to get to green until that last phpunit test is fixed in 3.0.x.

    MR-24 - Applies updates to fix the "validate" class of tests in the pipeline for 4.0.x. This brings the pipeline to full green.

    I don't think it's appropriate for me to RTBC this as I'm one of the people contributing the fixes. @riddhi.addweb, can you check on 3.x or 4.x?

  • Status changed to RTBC 5 months ago
  • 🇮🇳India arunsahijpal

    Great Work @kul.pratap and @john-franklin,
    I've tested MR!22 and MR!24 on my local and phpcs doesn't reports any error, and phpcs is passing in the pipeline too!
    Hence moving it to RTBC.

  • 🇺🇸United States John Franklin

    @robert-castelo, can you review and merge these two MRs, one each for the 3.x and 4.x branches, please?

Production build 0.71.5 2024