Fix PHPCS issues

There is one test failing in the pipelines. The same test fails in other recent MRs.

The "test-pipelines" MR is 3.0.x, minus the LICENSE.txt file. The unit tests fail in exactly the same way when running against 3.0.x as they do the fix-phpcs-issues MR, I have to consider the MR to be valid.

I tried to apply both MR [22, 23] and it applied cleanly, but still, the errors are displayed. Still, PHPCS errors are there and not resolved. Attaching the SS for the same.

john franklin → changed the visibility of the branch 3471496-test-pipelines to hidden.

MR 22 is the correct one. I've hidden 23 and deleted the branch from git. MR 22 passed PHPCS in the pipelines. I'll rerun it and see what comes back.

Working on it.

Pipeline passed with no warning and errors.

Thanks for the updates @kul.pratap. A completely green pipeline is a lovely thing to see! I updated the cspell handling to inject unknown words in the `.gitlab-ci.yml` file instead of recreating the whole .cspell.json file, and backported the changes to the 3.x branch.

@robert castelo, there are two MRs attached here:

MR 22 - Applies updates to fix the "validate" class of tests in the pipeline for 3.0.x. This is as close as we're going to get to green until that last phpunit test is fixed in 3.0.x.

MR-24 - Applies updates to fix the "validate" class of tests in the pipeline for 4.0.x. This brings the pipeline to full green.

I don't think it's appropriate for me to RTBC this as I'm one of the people contributing the fixes. @riddhi.addweb, can you check on 3.x or 4.x?

Great Work @kul.pratap and @john-franklin,
I've tested MR!22 and MR!24 on my local and phpcs doesn't reports any error, and phpcs is passing in the pipeline too!
Hence moving it to RTBC.

@robert-castelo, can you review and merge these two MRs, one each for the 3.x and 4.x branches, please?

any chance for merge?

robert castelo → made their first commit to this issue’s fork.

Why is "behaviour" (UK spelling) being changed to "behavior" (US spelling)?

Not going to hold up merging, but feel like both should be allowed.

@robert castelo thank you:)

Automatically closed - issue fixed for 2 weeks with no activity.