- Issue created by @elgandoz
- Status changed to Needs review
over 1 year ago 5:20pm 25 October 2023 - Status changed to RTBC
over 1 year ago 3:44am 30 October 2023 - ๐บ๐ธUnited States mlncn Minneapolis, MN, USA
This is perfectโ the right call on being a link not a button, gets the color right by using the Gin variable, the text is translatable, and the code is updated to keep the addition as efficient as it can be.
And works as advertised.
RTBC.
- Assigned to yannickoo
- Status changed to Needs work
over 1 year ago 3:16pm 27 January 2024 - ๐ฉ๐ชGermany yannickoo Berlin
I'm going to make some adjustments for the PHP code but really nice changes so far!
- ๐ซ๐ทFrance erwangel
Patch doesn't apply on gin login 2.1.3. It was working before update.
- Issue was unassigned.
- Status changed to Needs review
7 months ago 12:43pm 14 November 2024 - ๐บ๐ธUnited States mlncn Minneapolis, MN, USA
No one has said there's anything specific wrong with this code, and it solves the problem. Setting back to needs review for the bots to confirm it applies, but if this does i still say it's RTBC.
- ๐จ๐ญSwitzerland saschaeggi Zurich
@zenimagine we're not doing any patches anymore, there is a MR open.
You can generate a patch from the MR if needed to include in your setup with clicking at
plain diff
Or you can add
.patch
or.diff
at any GitLab MR URL to generate a patch on the fly. - ๐ฆ๐บAustralia elgandoz Canberra
Merge request rebased for 2.1.x-dev, it also apply to current 2.1.3.
If good please mark as Review & Tested by community, I believe it's a small change which restores the original Drupal workflow.