Drupal 10 Compatability

Adding the thread that the patch came from 🌱 Port Views Distinct module to Drupal 8 Needs review as a related issue.

It may be better to close this as a duplicate and rename the thread over there to "Port Views Distinct module to Drupal 8+" or similar.

Thanks for the patch:)

@jay.dansand, can you create a dev branch for this one? It would be easier for us to test it.

Best,
Orkut

@chetan 11, thanks for your contribution.

When I installed your version on Drupal 10.1.6 site. Right after it, I've started receiving this error:

Error: Call to undefined function db_select() in _views_distinct_field_settings_get() (line 360 of /var/www/html/web/modules/views_distinct/views_distinct.module).

I'm changing the issue's status as Needs work.

Also, it is better to change the content of info file like below:

name: 'Views Distinct'
type: module
description: 'Allow filtering/aggregating "distinct" Views result rows based on arbitrary fields.'
package: Views
core_version_requirement: ^8.8 || ^9 || ^10
dependencies:
  - drupal:views

Best,
Orkut

I've done the changes and committed to this issue's branch, also created a new MR too. Right now the error message changed into:

Cannot use view object to get third party settings.

Can someone check it too?

Hi,

May be to do with; https://www.drupal.org/project/drupal/issues/2686145 🐛 Formatter third party settings missing from Views UI Needs work ?
greetings,

After changing the OR for a AND operator in my previous commit I was able to use the module without the log
Cannot use view object to get third party settings.

For a basic configuration the module successfully removed duplicates from view.

1. Create a few articles
2. Add a reference field for articles in Basic Page.
3. Create a few basic pages referencing multiple articles.
4. Create a view of Basic pages
5. Add a relationship to article
6. Note that some basic pages titles are duplicated
7. In the title field config in "Views Distinct settings" tick "Filter this field"
8. Note that duplicated title are removed from the view

Core will never replace what this module does. This module (in D7) has the ability to combine fields and use those for uniqueness. Core will never do that.

I strongly agree with @liquidcms, this module has a different purpose.

+1 for a speedy resolution. I need this module for D10. thx