MR raised and ready for review.
colinstillwell → created an issue.
@abhishek_gupta1 I am not sure I agree with the changes. I would have just copied what is already in Drupal core, for consistency. This should avoid confusion in the future.
I have just created my own MR, to demonstrate my point.
colinstillwell → created an issue.
colinstillwell → created an issue.
Thanks for offering to maintain with us Viktor, I just took a look at your profile on Drupal.org and you look more than capable.
Gisle, I have no concerns from my side, I think Viktor would be a great addition to the team :-).
I ran an audit on the whole module and found two additional files which need patching, so have created a new version.
colinstillwell → created an issue.
colinstillwell → created an issue.
After further investigations, this issue is being caused by entity_translation_i18n_menu. Closing.
colinstillwell → created an issue.
As of today, I have also received the following:
Deprecated function: is_file(): Passing null to parameter #1 ($filename) of type string is deprecated in image_resize_filter_get_images() (line 378 of /var/www/html/docroot/profiles/d2/modules/contrib/image_resize_filter/image_resize_filter.module).
Deprecated function: is_file(): Passing null to parameter #1 ($filename) of type string is deprecated in image_resize_filter_delete_temp_file() (line 613 of /var/www/html/docroot/profiles/d2/modules/contrib/image_resize_filter/image_resize_filter.module).
New patch created, the one in #5 was not applying cleanly for me.
colinstillwell → created an issue.
colinstillwell → created an issue.
colinstillwell → created an issue.
Thank you for adding me, I have received a notification.
I am only focused on Drupal 7 at the moment, Drupal 9 & 10 are new to me and this is something I plan to look into over the coming months.
colinstillwell → created an issue.
Work completed, merge request raised. Ready for review.
I have a use case for this myself, I am going to fork and create a merge request. Watch this space!
Work completed and merge request raised.
colinstillwell → created an issue.