- last update
about 1 year ago 1 pass - π¬π§United Kingdom colinstillwell
I ran an audit on the whole module and found two additional files which need patching, so have created a new version.
- π¨πSwitzerland salvis
Thank you for the patches!
Why does
$_SERVER['SERVER_SOFTWARE']
need to be cast to string?Is this already fixed in the D8 version?
- πΈπ°Slovakia poker10
I think that there are cases where the
$_SERVER['SERVER_SOFTWARE']
is not defined and the patch is trying to "fix" that by casting to a string. Proper fix should be isset (see for example here, where the similar fix was made in D7 core: #2356055: Notice in includes/mail.inc define β ). But as I have mentioned in #4, I am not entirely sure that the fix to$_SERVER['SERVER_SOFTWARE']
is in scope of this issue. -
joseph.olstad β
committed 857da4cd on 7.x-2.x authored by
djdevin β
Issue #3281253 by djdevin, colinstillwell, poker10: realpath(): Passing...
-
joseph.olstad β
committed 857da4cd on 7.x-2.x authored by
djdevin β
- Status changed to Fixed
11 months ago 1:52am 13 January 2024 Automatically closed - issue fixed for 2 weeks with no activity.