After looking at this a bit it's still outputting incorrectly, the eligibleRegion should have had a Country subelement.
Turning off pivoting outputs as expected:
{
"@context": "https://schema.org",
"@graph": [
{
"@type": "Product",
"name": "Thing",
"offers": {
"@type": "Offer",
"price": "500",
"eligibleRegion": {
"@type": "Country",
"name": "USA"
}
}
}
]
}Thinking about how we could solve this.
I thought it would be possible to just associate both revisions with the workspace, so if one revision is disassociated the other one will still be there.
But, there's a unique index on the workspace_association table that prevents this:
PRIMARY KEY (`workspace`,`target_entity_type_id`,`target_entity_id`,`target_entity_id_string`)
It's strange that only one record per entity can exist here, but in a table like node_revision, multiple revisions can be associated with a workspace. Maybe we should update the index (and the code) to work off of the revision instead.
Another option is to update deleteAssociations() to either delete associations or update them to the most recent workspaced revision. But, that's probably confusing without renaming deleteAssociations to updateOrDeleteAssociations...
Added a test that illustrates the problem.
Let me take a look at it, just wanted to make an issue.
I just found a duplicate here ✨ Media library form can only be submitted in the default workspace Needs work
Agreed, tie it to system.performance.js.preprocess
Wasn't the issue. Closing.
This might be a symptom and not the cause, I can't pin it down to the coalesce.
Yes, the dependencies are setup correctly (mod1 depends on mod2).
On a fresh install it works fine, issue seems to be introducing autowiring during an update - seems to be no way I can get the module enabled in time before that error throws.
djdevin → created an issue.
It was part of a multifaceted approach so I'm not sure exactly how much this was part of the gained performance. I used a Drupal queue and ran multiple instances of queue-process to delete a batch of 1000 entities at a time in parallel. A custom progress bar running periodically looked at the number of items at the start and the number of items left in the queue.
Didn't have significant issues with memory, I believe it was solely the efficiency loss from running thousands of delete queries instead of 1.
I was exaggerating a little bit and don't have hard benchmarks, but at 10M (million) it went from ~200 hours to 6 hours or so. They were also entities with ~200 fields (paragraphs) so there were a ton of single field delete queries which is where I identified the issue. So deleting a single entity cost 402 queries. Deleting 1000 of them cost 402,000 (2000 entity, revision, and 2*200*1000 field queries).
With the fix, deleting 1000 entities cost 2400 (1000*2 entity, revision and 200*2 fields and revisionqueries)
At 402,000 queries per batch of 1000, the issue is exacerbated if you are using something like AWS Aurora or MySQL with replication in a durable ACID configuration, and if the database isn't local to the network. Both contribute to delay when writing tons of data.
tl;dr: Bulk queries are recommended anyway.
Probably not, but likely fixes my issue.
I have another issue with openid_connect since that form is not marked as workspace safe which I assume I could just do by adding it to Workspace safe forms.
The discard issue is fixed if you use WSE in combination with this change, because then it gets all the revisions associated with a Workspace and not just the ones since the current version.
📌 Simplify getAssociatedRevisions() and getAssociatedInitialRevisions() from core Active
I closed ✨ Option to show all revisions on Workspace-enabled content Active in favor of this
Just wanted to note that it would be useful to show the Workspace the revision belongs to, which I think is happening in the MR!
Recreated MR with failing test.
djdevin → changed the visibility of the branch 3473358-some-cleanup-and to hidden.
If you run this in devel/php it illustrates the problem (clean D10 site)
$node = \Drupal::entityTypeManager()->getStorage('node')->create([
'title' => 'Change in the live site',
'type' => 'page',
]);
$node->save();
$stage_ws = \Drupal::entityTypeManager()->getStorage('workspace')->load('stage');
$ws_manager = \Drupal::service('workspaces.manager');
$ws_manager->setActiveWorkspace($stage_ws);
$node->title = 'Change in stage site';
$node->save();
$ws_manager->switchToLive();
$nE = \Drupal::entityTypeManager()->getStorage('node')->load($node->id());
$nR = \Drupal::service('entity.repository')->getActive('node', $node->id());
// These outputs should be the same because we are in the live workspace so we should only see the non-workspace change.
echo $nE->label();
echo "\n";
echo $nR->label();
Thanks!
Basically just follow the steps in https://www.drupal.org/project/drupal/issues/3438083#comment-15866369 ✨ Ability to edit content in live workspace when it has been edited in other workspaces Active
It looks like it should work, but it fails with this patch. I keep getting the latest revision instead of the latest non-workspace revision.
Added an MR which is basically https://www.drupal.org/project/workspaces_parallel →
Oops, close in favor of ✨ Ability to edit content in live workspace when it has been edited in other workspaces Active
Spoke too soon, this prevents the entity repository from getting swapped out so the loaded revisions are wrong.
That approach seems to conflict with jsonapi_cross_bundles but I don't know why
The website encountered an unexpected error. Try again later.
Symfony\Component\DependencyInjection\Exception\ServiceCircularReferenceException: Circular reference detected for service "workspaces_parallel.entity_repository", path: "redirect.request_subscriber -> redirect.checker -> access_manager -> paramconverter_manager -> paramconverter.jsonapi.entity_uuid -> workspaces_parallel.entity_repository -> jsonapi.exception_subscriber -> jsonapi.serializer -> serializer.normalizer.resource_identifier.jsonapi_extras -> Drupal\jsonapi\ResourceType\ResourceTypeRepositoryInterface -> jsonapi_cross_bundles.cross_bundle_resource_type_repository.inner". in Drupal\Component\DependencyInjection\Container->get() (line 149 of core/lib/Drupal/Component/DependencyInjection/Container.php).Thanks!
This is still an issue, the problem is that the form rebuilds when you add another condition, and then the arguments end up being a string instead of an array.
This only happens if you try to add more than 1 condition to an Entity reference views component.
I updated the README.md.
Thanks!
I fixed a few issues from my PoC in #4 and published it here: https://www.drupal.org/project/workspaces_parallel →
Caveat, there is no reintegration so any live changes just get overwritten when you publish (only content that was edited within the Workspace).
Patch worked once rerolled for 10.3.x, not flooding the query log anymore.
There's a tag set on config:system.menu.[name], not sure if that gets flushed if a link changes.
Seems to still be called a lot, even with a warm cache. Looking at RDS insights it's still a top query under load.
General log is full of the same query, even when trying the page as anon (no page cache, just dynamic cache).
(346 is the current node being viewed)
Could be something with our site but still investigating.
I was unable to test the MR because we haven't updated to 11.x yet and it doesn't apply to 10.3.x The modernizr tweak didn't seem to work for me, but we have a ton of libraries so it could easily be another library with weights.
Something else I'm also seeing related to performance is a ton of these queries (1000s) under heavy traffic:
Very likely old cached JS/CSS calls.
Seems I can just make up some random hash and pass all the query parameters, and it will make several DB calls. Could easily DDOS the site as 4xx errors are usually not cached. Since no JS file is ever created it keeps crunching.
https://drupal/sites/default/files/css/anything.css?delta=0&language=en&...
Would be happy to have you on. Thanks!
I just added a print_r(array_column($group['items'], 'data')); right before it gets passed to generateHash and the order is wrong causing the hash mismatch.
Seeing this in 10.3.1.
Adding a breakpoint on AssetGroupSetHashTrait::generateHash() shows a differently weighted list when it is called on the current page vs. from the .js file, so the hash_equals() in AssetControllerBase fails and it doesn't cache the file.
I don't think generateHash() is the problem because the weights are already wrong for some reason.
Trying to reproduce outside of our specific site, but it's a list of 56 JS files and the middle of the list is out of order, resulting in a different hash.
We do have a lot of library dependencies so something is not taking those into account.
Reverting to 10.2.6 caches it to disk as expected.
Rebased against 11.x (applies to 10.3.x cleanly as well)
deleteFromDedicatedTables() doesn't have any test coverage - since this isn't a bug I wonder if having coverage through SqlContentEntityStorageSchemaTest is enough?
Setting as needs work, since this is a BC break.
Sorry this is actually Drupal 10.3!
But there is an issue in core to not break BC here: https://www.drupal.org/project/drupal/issues/3450244 🐛 Provide BC for ImageStyleDownloadController Needs review
djdevin → created an issue.
In our case, merging wasn't necessary, all derivatives are based off of the currently published version so it wasn't a big deal.
This functionality is also necessary for a situation like this:
- Live site
- Promo A
- Promo A takedown
- Promo B
Otherwise you have to wait until the Promo A takedown to start working on the next promo
I removed the constraint then added a hook_entity_prepare_form that would swap out the entity version. When editing, Drupal only loads the most recent revision. It seems to work alright, I'm not sure of any caveats. The order of versioning is kinda wonky since the latest version might not be the content that is going to go out, but just don't look at the revisions page!
It might be useful to add a column on that page to show that a revision belongs to which workspace.
/**
* Implements hook_entity_prepare_form().
*
* Replace the form's entity with one that is associated with the current
* workspace.
*
* Workspace already replaces the entity being viewed based on the workspace.
* But edit forms always load the most recent revision.
*
* This is based on Drupal\workspaces\EntityOperations::entityPreload, altered
* to work in hook_entity_prepare_form().
*/
function custom_entity_prepare_form(EntityInterface &$entity, $operation, FormStateInterface $form_state) {
if ($operation == 'edit') {
$entityTypeManager = \Drupal::entityTypeManager();
$workspaceManager = \Drupal::service('workspaces.manager');
$workspaceAssociation = \Drupal::service('workspaces.association');
// Only run if the entity type can belong to a workspace and we are in a
// non-default workspace.
if (!$workspaceManager->shouldAlterOperations($entityTypeManager->getDefinition($entity->getEntityTypeId()))) {
return;
}
// Get a list of revision IDs for entities that have a revision set for the
// current active workspace. If an entity has multiple revisions set for a
// workspace, only the one with the highest ID is returned.
if ($tracked_entities = $workspaceAssociation->getTrackedEntities($workspaceManager->getActiveWorkspace()->id(), $entity->getEntityTypeId(), [$entity->id()])) {
/** @var \Drupal\Core\Entity\RevisionableStorageInterface $storage */
$storage = $entityTypeManager->getStorage($entity->getEntityTypeId());
$vid = key($tracked_entities[$entity->getEntityTypeId()]);
// Swap out the entity.
$entity = $storage->loadRevision($vid);
// Just an indicator we could use in form_alter.
$form_state->set('pur_workflow_entity_prepare_form', TRUE);
}
}
}
[...]
/**
* Implements hook_validation_constraint_alter().
*
* Replace the default workspace constraint with one that does nothing.
*/
function custom_validation_constraint_alter(array &$definitions) {
if (isset($definitions['EntityWorkspaceConflict'])) {
$definitions['EntityWorkspaceConflict']['class'] = CustomEntityWorkspaceConflictConstraint::class;
}
}
Scale was removed from Quiz core and moved to https://git.drupalcode.org/project/quiz_scale but it is currently unsupported.
It was not really question type, as it could not be scored. Any answer was correct.
If you are looking to collect scale answers, I would use Webform instead.
Quiz builds on a lot of core/contrib functionality instead of reinventing (if you remember, was done for the D5-D7 versions, resulting in a mountain of technical debt).
Rules is used for evaluating all the feedback items and allows for custom conditions. Agreed it should probably move to something like ECA or core conditions.
entity - Quiz requires some Entity functionality not provided by core, e.g base entity classes/forms/handlers
range - Needed for widgets like grade range (e.g. grade between X and Y)
rules, typed_data - Needed for evaluating Feedback conditions
paragraphs - Needed for all sorts of nested data storage e.g. MCQ questions, Feedbacks, Grade feedback, Taxonomy questions...
entity_reference_revisions - Dependency of paragraphs, also powers Quiz revisioning
views_bulk_operations - Needed for admin functionality e.g. question bank, quiz questions, results
views_data_export, rest, csv_serialization - Needed for reporting/exports of Quiz results
It sounds like your user does not have permission to create the paragraph type that Quiz uses.
You'll have to grant the ability to create/edit Quiz Question Term Pool paragraphs.
It's me, hi, I'm the problem, it's me...
We had this code altering JS, removing it also fixes the issue.
function xxx_js_alter(&$javascript, AttachedAssetsInterface $assets) {
$request = \Drupal::request();
if ($request->getPathInfo() === '/xxx') {
unset($javascript['core/misc/drupal.init.js']);
unset($javascript['core/misc/drupalSettingsLoader.js']);
unset($javascript['core/misc/drupal.js']);
}
}
Though I'm not sure why doing that wiped out the rest of the JS, and how adding a dependency on core/once fixes it.
I tried the MR and those suggestions to no avail. I noticed the problem was no longer happening for me so I backtracked over any changes and found out that I added a dependency on a completely different library, to a completely different library (on core/once) which causes some change in how the JS gets grouped.
As a test, I just added a dependency on core/once to the broken external library (which has no dependencies) and that also worked.
some-external-library:
js:
//domain.com/ext.js: { type: external, minified: true }
//domain.com/ext2.js: { type: external, minified: true }
dependencies:
# Why is this needed? We don't know.
- core/once
Can't figure it out but at least I know removing that seemingly innocuous library dependency triggers the issue.
The working JS output looks like:
When the JS is broken it looks like: with that last aggregated file being blank. Regular pages are unaffected, only broken in this case where we are calling getJsAssets() manually for some decoupled functionality.D10 fixes + PHP 8.2 fix