PHP Fatal error: Declaration of Drupal\imageapi_optimize_webp\Controller\ImageStyleDownloadController::deliver

Is this issue on Drupal 11 or Drupal 10 ?
This module does not have a release for Drupal 11 yet. It must be throwing from a patch from this issue https://www.drupal.org/project/imageapi_optimize_webp/issues/3448709 📌 Automated Drupal 11 compatibility fixes for imageapi_optimize_webp Needs review

Sorry this is actually Drupal 10.3!

But there is an issue in core to not break BC here: https://www.drupal.org/project/drupal/issues/3450244 🐛 Provide BC for ImageStyleDownloadController Needs review

Setting as needs work, since this is a BC break.

Thanks for the patch. We'll likely need to create a 2.1 and make a requirement for 10.3 and above.

What I've found is the approach with this module and some of the others in the space are a bit dated(and require overriding a core controller which created this issue to begin with. I'm working on a potential new alternative that I think would be foundationally stronger, but in the meantime we'll keep supporting this.

I've applied the patch at #6 to a couple of site so far and can report it is working with 10.3.1.

Can we get a 2.1 version? Is there anyway I can help with that?

michaellander → changed the visibility of the branch 3453941-declaration-of-drupalimageapioptimizewebpcontrollerimagestyledownloadcontrollerdeliver to hidden.

Hiding patch and moving to branch.

Hi there
I also did a successful test of the patch. I also tested the 2.1-dev branch on my projects - also successful.
What is the timeline for the 2.1 release? Can I help you with this in any way?

@danielwirz, am wanting to include 📌 Automated Drupal 11 compatibility fixes for imageapi_optimize_webp Needs review in a 2.1 release so we can confidently support Drupal 11. If you can help test the patch in that issue on 10.3 and 11, that'd be great.

Also going to test ✨ Attempt to remove ImageStyleDownloadController override completely Needs review , which would really simplify things. In which case maybe we just move to 3.x if it works.

If we can get some more eyes on ✨ Attempt to remove ImageStyleDownloadController override completely Needs review , I believe it'll make this update much easier overall. I think it allows us to keep this in 2.1, and should give us a path forward for modules like ImageAPI Optimize AVIF → to run alongside this module without needing glue modules like ImageAPI Optimize WebP and AVIF →

@michaellander thanks for the feedback. i'll test the patch next week and give a feedback

Automatically closed - issue fixed for 2 weeks with no activity.

Since using MR as a patch is a security issue, I'm adding a patch as a temporary solution until a new release of the module is added.

so is this ever going into the module release version? i really need to be able to update some sites that break when i do... thanks!

so i am guessing that is a 'no' and i need to remove the module then.