Account created on 17 December 2018, about 6 years ago
#

Merge Requests

More

Recent comments

🇨🇭Switzerland danielwirz

@michaellander thanks for the feedback. i'll test the patch next week and give a feedback

🇨🇭Switzerland danielwirz

Hi there
I also did a successful test of the patch. I also tested the 2.1-dev branch on my projects - also successful.
What is the timeline for the 2.1 release? Can I help you with this in any way?

🇨🇭Switzerland danielwirz

danielwirz made their first commit to this issue’s fork.

🇨🇭Switzerland danielwirz

Will be tested and released in 1.0.1

🇨🇭Switzerland danielwirz

Will be tested and released in 1.0.1

🇨🇭Switzerland danielwirz

Will be tested and released in 1.0.1

🇨🇭Switzerland danielwirz

Fixed with #c29d889d

🇨🇭Switzerland danielwirz

Hi there
Patch #2 worked well for me on Drupal 9.1. On Drupal 10, however, the range filter is no longer rendered.
I adjusted the patch, so the fields are restored.

🇨🇭Switzerland danielwirz

Patch in #17 causes issues with range filters, because field names that end with [xxx] are converted to []. That casues problems on range filters, where the field names end with [min] and [max].

🇨🇭Switzerland danielwirz

Sorry, i just realized that this issue is caused by a patch that was applied ( https://www.drupal.org/files/issues/2023-01-12/views_ajax_history-histor... )

Sorry I missed that!

🇨🇭Switzerland danielwirz

danielwirz created an issue.

🇨🇭Switzerland danielwirz

danielwirz made their first commit to this issue’s fork.

🇨🇭Switzerland danielwirz

danielwirz made their first commit to this issue’s fork.

🇨🇭Switzerland danielwirz

danielwirz made their first commit to this issue’s fork.

🇨🇭Switzerland danielwirz

Hey there!

I stumbled across a very similar issue where I needed the lat & long coordinates as value for the field. I think, a nice solution for this would be to add an option for a custom format, using the places object given by the API.

I added a new output_format setting to the field formatter. This way we can use JS template literals to format the resulting value as desired.

What do you think, could that be a useful feature?

🇨🇭Switzerland danielwirz

Hi there

I encountered the same problem. I tested the latest dev version (dev-3.x, commit 9abb2b2) on a vanilla Drupal installation and randomly added columns to the content view:

We can see 2 problems:
1. The --is-sticky class is added although we haven’t scrolled down yet. This is caused by the intersection observer which always detects an intersection as soon as the view overflows the viewport horizontally.
2. The sticky header is not scrollable.

For the first problem, I might have come up with a – rather «creative» – solution: Instead of observing the table header – which always triggers an intersection when it’s wider than the viewport – we could add an absolutely positioned element to the table header and observe this element. Due to the absolute positioning, horizontal scrolling does not cause intersections and therefore the –is-sticky class is not toggled.

The second problem could be resolved by adding a scrollable wrapper around the sticky table and sync its scrolling with the views scrolling.

I did some changes (https://git.drupalcode.org/issue/gin-3323501/-/tree/3323501-table-sticky...) to implement those two suggestions. However I didn’t test them very thoroughly – they are more like proof of concept (and feel a bit hacky…).

What do you think – could that be a possible solution? Let me know if I can help you with this!

🇨🇭Switzerland danielwirz

@abelass, yes, that might be true. there are several issues covering the same problem, so i wasn't really sure where to put it. sorry, if picked the wrong one.

Production build 0.71.5 2024