🇳🇿New Zealand @siramsay

alexpott → credited siramsay → .

tonypaulbarker → credited siramsay → .

A few ideas showing the block nature of the contact form.

I will submit a solution for this too.

Maybe, you've added a fluid container.

There are 2 issues.

1. Experience Builder preview width is 1024W - You stated this. Need a larger preview window.
2. CT breakpoints have a mixin (ct-container) that creates a max-width for all breakpoint on the container. xxl breakpoint is 1440px with a 1248px.

1. I think this is an Experience Builder issue. Need to open an issue there.

2. Looking at this quickly, there is a lot going on, but in the layout.twig there is a {{ is_contained_class }} variable. If this was set to false then I think we would get .container-fluid class, which would be better for such a page builder or at least these components.

Adding these for reference.

Desktop: https://www.figma.com/design/tKYim76bnDZAyWubUi3sVv/New-Drupal-Brand---D...

Mobile: https://www.figma.com/design/tKYim76bnDZAyWubUi3sVv/New-Drupal-Brand---D...

I can have a look at this. Is all the code in the current main 1.0.x branch?

You say "too big in XB's desktop preview area." Do you mean the Create Ambitious Experiences... text sizing in the mobile preview area?

That's okay, gave me a chance to look at the set-up. I added it to the reset.css in the 00-base directory, so it is at the top of the base.css.

As I thought, Olivero adds the code you added in the /base.css.

Since this image doesn't have style set it uses the attribute width and height as you have illustrated, and therefore it is best we add the same code in the demo design system too.

The small image, uses the thumbnail image style, that's why it is resized.

I'll check for the best file to add it to.

I'll look at this for you.

Update Appearance Screenshot to be current

kristen pol → credited siramsay → .

Sorry for the late reply.

The test I did looks the same as the main 1.0.x branch now.
Please see side by side attached. The bottom of the files are the same too.

Follow up / fresh installation d11

I get the same log as #4

This is the browser console when upload an image named one.jpg or a.jpg (keeping names short for reason above.)

I can reproduce this too. I am using 10.3.2 and a git clone of the xb repo.

I don't understand this bit

Browse to `/node/add/article` — you'll see a `🪄 XB Demo ✨` field. Don't touch that — just enter a title for the article and hit save: a component is rendered using the article title

Mainly because we need to add the required image.
I have tried an image named image,jpg after reading this and the problem persists.

What I can notice is there are a lot of required fields like the one below.
These disable the save button.

If I select something I CAN "save" the node.
But then getting hero field is required.

Upload an image and get Ops....

thejimbirch → credited siramsay → .

siramsay → created an issue.

Added alternative method to use pip for when pip install doesn't work.

As long as the meta and props are correct, the only issue is the empty line at the start of the README.md that I removed in the subsequent commit.

Add correct syntax for using pip

I just added the comment above, unsure why my Gitlab profile doesn't match up with this one.

Anyhow, I read/reviewed it and I understand it clearly. A few capitalizations missing at the beginning of list items, but unsure how strict you are on that.

I think removing link is best. For someone new/beginner, it can be confusing. I've been there.

siramsay → made their first commit to this issue’s fork.

Step 2
2. Find the issue where you want to contribute code [example issue]

Example issue is a fixed issue and doesn't have Create issue fork

I've applied the patch at #6 to a couple of site so far and can report it is working with 10.3.1.

Can we get a 2.1 version? Is there anyway I can help with that?

@andres.torres

I'm using 10.2.6. I will test update to 10.3.0 this/next week.

The reason for the code not being included is that someone would need to manage an alias list.

I think the best way around this would be to have an alias list for any of the Drupal core code block module that ships with CKEditor 5. #14
Having a UI administration page could be the way to go for people that want to enhance the alias list.

@Andres.torres

I have it working with 1.1.2.

See my comment #12

In short, use this https://git.drupalcode.org/project/highlightjs_input_filter/-/merge_requ...
I think this was included in latest release https://www.drupal.org/project/highlightjs_input_filter/issues/3402489#c... 🐛 Error when several instances of same language on the page Fixed

Switching this back to review, as maybe this is a better solution?

By using a dialog OpenDialogCommand instead of a modal window, OpenModalDialogCommand the dialog opens on top of the Media window.
( https://www.drupal.org/node/1989646 → Ajax commands for opening and closing Dialogs and generic Dialog Controller added to core)

We need to name the new dialog with an ID such as "#focal-point-preview" but this doesn't really matter except we need to pass the argument.

$response->addCommand(
     - new OpenModalDialogCommand($this->t('Images preview'), $output, $options)
     + new OpenDialogCommand('#focal-point-preview',$this->t('Images preview'), $output, $options)
 );

I've also added a wrapper to the original image, so the size is known before the image is loaded. This fixes the modal so it does centre strangely on first load.

<div class="focal-point-original-image">{{ original_image }}</div>

.focal-point-original-image {
  height: 500px;
}

#11 was committed but didn't get in https://www.drupal.org/project/highlightjs_input_filter/issues/3402489#c... 🐛 Error when several instances of same language on the page Fixed

I have tested the code from https://git.drupalcode.org/project/highlightjs_input_filter/-/merge_requ... and this work good.

I had found the same with the HTML when updating from a custom highlight.js file I had been using with 1.0.1. I found that HTML was breaking the rendering due to highlight.js not having an HTML language file at the route

. This resolve alias function works as I hoped. Thank you.

Beautiful. I forgot to mention that I was using an optimization pipeline with WebP in my comment yesterday, and had thought this may have been the issue since.

This works on my site as described by the original poster @badrange

Now wondering if we should open a new issue or work on this one, as the workflow is strange is you want to use the preview button. I.e you need to click save on the modal which closes it and then re-open the edit to use the preview.

I am getting the same as #18

Using with Media with the edit button. The Media edit button open the media/22/edit page in a modal.
Focal point does save, and the preview does work in the same manner as described in the original post.
You can visit the /media/22/edit from the /content/media page and the focal point is saved, and the preview is working as above.

I need to flush the image style for the crop to take effect.

I am using it with in a Responsive image Style.

The code didn't make it into the 1.1.1 version of the HighlightJs.php

https://git.drupalcode.org/project/highlightjs_input_filter/-/blob/1.1.x...

JS is fine.

I patched and tested and it works.

'drupalSettings' => [
        'enableCopyButton' => $enable_copy_button,
-       'highlightJsLanguages' => $languages,
+       'highlightJsLanguages' => array_values(array_unique($languages)),
],

@smustgrave

I can reproduce this. You need to use the Exposed formsetting Exposed form in block and set it to Yes.

Then place the exposed from using block placement or in code.

I agree. I use a local Mac environment and am happy with vendor/bin/drush

If you want to user drush you can use drush launcher https://github.com/drush-ops/drush-launcher

Using docker isn't needed and add another hurdle. This recommendation should not be highlighted in this way.

@kristen.pol@gmail.com

Regarding Manage Display
There is still an issue where the node title doesn't show on the node
https://www.drupal.org/project/manage_display/issues/3143678 ✨ Allow node/entity to display title/label field as normal Needs work

(From memory the patch provided only works on 8.x-1.x-dev which Works with Drupal: ^8.8 || ^9 )

I have the same issue. A site in a sub-directory.

~/public_html/production/DRUPAL-ROOT

I have .htaccess in the /public_html/ to rewrite the URL

access denied on core/authorize.php/?batch=1&id=107&op=start

$settings['allow_authorize_operations'] = TRUE didn't work, TRUE is the default so unsure why this would work. The reason for the lin in the setting is so you can set it to FALSE by uncommenting.

@pasan.gamage I can verify that when you enter an anchor link in the middle of a paragraph it jumps to the end of the paragraph when you re-edit the content.

Follow up on my above comment about Fake Objects.

You are able to uninstall the module from the UI/drush but when you come to composer remove you get the below because composer is checking drupal packages remotely.

Removal failed, drupal/fakeobjects is still present, it may be required by another package. See `composer why drupal/fakeobjects`.

$ composer why drupal/fakeobjects
drupal/anchor_link 3.0.x-dev requires drupal/fakeobjects (~1.0) 

The latest @dev version "drupal/anchor_link": "3.0.x-dev@dev" / drupal/anchor_link dev-3.0.x 6938068 doesn't include the fake object removal patch so you get unable to install CKEditor 4 in the UI and drush.

If you use the patch from the following branch you can uninstall fake objects and therefore CKEditor 4 https://git.drupalcode.org/issue/anchor_link-3206676/-/commit/c91ee92c4e...
- https://git.drupalcode.org/issue/anchor_link-3206676/-/commit/c91ee92c4e...

Would be good to get this merged into the dev branch.

The instructions at #56 otherwise worked for me.

Hello,
This isn't included in the 2.0.1 recommend version.

I am happy to use the -dev release ( https://www.drupal.org/project/api_proxy/releases/2.x-dev → ) but is there any reason this isn't merged into the "Recommended by the project’s maintainer" repository?

Thanks

sorry, in my initial merge request I didn't apply the rector patch so closed it and open a new one.

This is what I have tested and I am using on a Drupal 10 site.

I've added the automated patch and updated the info YAML.

I ran it through Upgrade Status and now use it as a custom module on a Drupal 10 instance.

siramsay → made their first commit to this issue’s fork.