Account created on 21 August 2010, about 15 years ago
#

Merge Requests

Recent comments

🇳🇿New Zealand siramsay

Can I submit something a little more abstract?
A slight nod to the hard work that went into XB (only people who know that will get it), but also plays with the dashes of paint, pencil icons, or could be a butterfly.

Let your experience take flight with Drupal Canvas.
Drupal Canvas, Give your project wings.

Canvas seems like it will be a cornerstone of Drupal.

P.S. These are just quick sketches, they could be refined. Also, happy for people to improve on these or use them for inspiration.

🇳🇿New Zealand siramsay

The patch from https://git.drupalcode.org/project/drupal/-/merge_requests/8815/diffs applies to Drupal 11.2.4.

I downloaded the patch 8815.patch for the code dropdown and applied using composer patches

🇳🇿New Zealand siramsay

I also ran into the issue that brought me here. Exactly the same set-up except 11.2.3 core.

Even though this is fixed, I still needed to apply the patch from #37

🇳🇿New Zealand siramsay

I had to remove this for Drupal 11. (Drupal 10.5.x is still fine)

I get this error when patched. If I remove patch, Drupal 11 recovers.

TypeError: Drupal\context\ContextMenuActiveTrail::__construct(): Argument `#5` ($context_manager) must be of type Drupal\context\ContextManager, Drupal\Core\Path\PathMatcher given, called in /Users/simonramsay/Sites/XXXXX/web/core/lib/Drupal/Component/DependencyInjection/Container.php on line 259 in Drupal\context\ContextMenuActiveTrail->__construct() (line 26 of modules/contrib/context/src/ContextMenuActiveTrail.php).
🇳🇿New Zealand siramsay

I can reproduce #11

if there are more than one, then previous chosen elements are getting the `aria-labelled-by` attribute from the last found chosen element.

🇳🇿New Zealand siramsay

I download the patch from drupalcode repo and applied it using composer, and it fixes the issue on my site.

Attaching patch file, I used. I guess it the same as the diff.

🇳🇿New Zealand siramsay

#29 works, except it takes over all the styles for layout-container. This only happens after you have opened a modal (and Claro is loaded). See attachments.

I have been able to unset the styles with !important rules in my front-end theme, as it is only the tabs, messages, edit-actions (save layout etc.)

If we could somehow restrict Claro theme override to only the modal this could work.

Another small issue I have noticed is the Label associated with check-boxes are Block so they stack.

🇳🇿New Zealand siramsay

I tested the latest commit, and this works as advertised. https://git.drupalcode.org/issue/book-3497281/-/commits/c0da465fce1c465cd7f24d0c5f409b5084651f45 with composer.json set up to use this.

composer require 'drupal/book:3.0.x-dev#c0da465fce1c465cd7f24d0c5f409b5084651f45'

🇳🇿New Zealand siramsay

This would be good to have in the stable 2.x release, since 3.0.x is the dev release. I'll test this out later today. Sorry, I should have said I couldn't get to it till today. Thanks.

🇳🇿New Zealand siramsay

This fixes the issue so that Use top-level page title as block title and Show top level item can be use together.

Still needs test.

🇳🇿New Zealand siramsay

Sorry, I don't know what I did above changed the visibility of the branch 3497281-add-an-option to active..
I was trying to find the correct issue branch and commit, so must have clicked on something. Please change back if that makes sense.

🇳🇿New Zealand siramsay

siramsay changed the visibility of the branch 3497281-add-an-option to active.

🇳🇿New Zealand siramsay

This fix doesn't allow Use top-level page title as block title and Show top level item together. The new functionality takes precedence.

🇳🇿New Zealand siramsay

Adding a note here. The Drupal 10 8.x-1.x-dev release has issues in cloning a content type cleanly.

🇳🇿New Zealand siramsay

Unable to set up theme completely.

🇳🇿New Zealand siramsay

I tested this and works as stated. I've patched 2.0.x

  • Add the new Section region CSS classes to choose from input
  • Copies class_list to region_class_list on updatedb

I am adding a patch from the Issue fork that I am using with my composer patches.

Adding a couple of image:

  1. Layout Builder tray with region specific classes
  2. Layout configure with copied section classes
🇳🇿New Zealand siramsay

change status

🇳🇿New Zealand siramsay

Changed core/themes/olivero/ to themes/custom/MY-THEME since Olivero is a core theme.

🇳🇿New Zealand siramsay

Yes, that's right, every time you update core the component would be deleted.  Okay, I can update it to use a custom/contrib theme route in the theme directory.

🇳🇿New Zealand siramsay

This page effectively teaches you to "hack" core.

🇳🇿New Zealand siramsay

This is the patch I applied that I create locally.

It is the same as the commit that was recently merged
https://git.drupalcode.org/project/project_browser/-/commit/a500525a0ac6...

I guess I need to use the project_browser 2.0.x-dev release to test again, but as said, the patch I applied did not work, so don't think this will nay different.

The patch #4 above still works even with the above applied.

I manually applied it

public function browse(ProjectBrowserSourceInterface $source): array {

    if ($source == '') {
      $enabled_sources = $this->config('project_browser.admin_settings')->get('enabled_sources') ?? [];
      if (!empty($enabled_sources) && isset($enabled_sources[0])) {
          $source = $enabled_sources[0];
      }
    }


    return [
      '#type' => 'project_browser',
      '#source' => $source,
    ];
  }
🇳🇿New Zealand siramsay

@tim.plunkett

I tried to use the code from your merge request https://git.drupalcode.org/project/project_browser/-/merge_requests/673/... on the issue #3500024: WSOD when accessing non-enabled or non-existent source plugin.

But I am unsure if I was able to apply that correctly. I can try again, it will be a bit of trial and error on my part, or do you have a guide on how to apply that branch to my installation? Drupal CMS using DDEV.

However, I used the patch, the alternative approach and the site came alive. #33499406 Fix fallback logic for empty $source in browse() method to ensure config validation with improved fallback logic
https://www.drupal.org/files/issues/2025-01-13/project_browser--2025-01-...

Admin toolbar works, and it has Tools from the admin toolbar extras in the navigation.

🇳🇿New Zealand siramsay

Just tried this and got the error
TypeError: Cannot assign null to property Drupal\Core\Recipe\InputConfigurator::$values of type array in unserialize() (line 68 of profiles/drupal_cms_installer/src/RecipeLoader.php).

ran rm -rf web/profiles/drupal_cms_installer/cache
refreshed browser, installer ran.

Works!

🇳🇿New Zealand siramsay

I am getting the same.
Paragraph Block 4.1.4

  • Create Paragraph
  • Save Node (entity)
  • Edit Layout
  • Add a block to a section
    • Blocks are not there
  • Edit
  • make no change
  • Save Node (entity)
  • Edit Layout
  • Add a block to a section
    • Blocks ARE there

I'll test some more.

🇳🇿New Zealand siramsay

I think drush is fine. People can then use drush how they like, since there are many ways to set it up.

🇳🇿New Zealand siramsay

This works but could be better. People could add strings longer than 256 char.

🇳🇿New Zealand siramsay

With the default field length of 128 it was not possible to add long gradients such as the example below which is 210 char.
I have made the field max length 256 char.
I have added a help note below the field.

linear-gradient(217deg, rgb(255 0 0 / 80%), rgb(255 0 0 / 0%) 70.71%),
linear-gradient(127deg, rgb(0 255 0 / 80%), rgb(0 255 0 / 0%) 70.71%), 
linear-gradient(336deg, rgb(0 0 255 / 80%), rgb(0 0 255 / 0%) 70.71%)
🇳🇿New Zealand siramsay

@sourabhsisodia_ Thanks for fixing the coding standards, my IDE put those curly brackets on the next line.

I am changing this back to needs work. Please cancel MR. I can't do that for some reason.

🇳🇿New Zealand siramsay

A few ideas showing the block nature of the contact form.

🇳🇿New Zealand siramsay

There are 2 issues.

  1. Experience Builder preview width is 1024W - You stated this. Need a larger preview window.
  2. CT breakpoints have a mixin (ct-container) that creates a max-width for all breakpoint on the container. xxl breakpoint is 1440px with a 1248px.

1. I think this is an Experience Builder issue. Need to open an issue there.

2. Looking at this quickly, there is a lot going on, but in the layout.twig there is a {{ is_contained_class }} variable. If this was set to false then I think we would get .container-fluid class, which would be better for such a page builder or at least these components.

🇳🇿New Zealand siramsay

You say "too big in XB's desktop preview area." Do you mean the Create Ambitious Experiences... text sizing in the mobile preview area?

🇳🇿New Zealand siramsay

That's okay, gave me a chance to look at the set-up. I added it to the reset.css in the 00-base directory, so it is at the top of the base.css.

🇳🇿New Zealand siramsay

As I thought, Olivero adds the code you added in the /base.css.

Since this image doesn't have style set it uses the attribute width and height as you have illustrated, and therefore it is best we add the same code in the demo design system too.

The small image, uses the thumbnail image style, that's why it is resized.

I'll check for the best file to add it to.

🇳🇿New Zealand siramsay

Update Appearance Screenshot to be current

🇳🇿New Zealand siramsay

Sorry for the late reply.

The test I did looks the same as the main 1.0.x branch now.
Please see side by side attached. The bottom of the files are the same too.

🇳🇿New Zealand siramsay

Follow up / fresh installation d11

I get the same log as #4

This is the browser console when upload an image named one.jpg or a.jpg (keeping names short for reason above.)

🇳🇿New Zealand siramsay

I can reproduce this too. I am using 10.3.2 and a git clone of the xb repo.

I don't understand this bit

Browse to `/node/add/article` — you'll see a `🪄 XB Demo ✨` field. Don't touch that — just enter a title for the article and hit save: a component is rendered using the article title

Mainly because we need to add the required image.
I have tried an image named image,jpg after reading this and the problem persists.

What I can notice is there are a lot of required fields like the one below.
These disable the save button.

If I select something I CAN "save" the node.
But then getting hero field is required.

Upload an image and get Ops....

🇳🇿New Zealand siramsay

Added alternative method to use pip for when pip install doesn't work.

🇳🇿New Zealand siramsay

As long as the meta and props are correct, the only issue is the empty line at the start of the README.md that I removed in the subsequent commit.

🇳🇿New Zealand siramsay

Add correct syntax for using pip

🇳🇿New Zealand siramsay

I just added the comment above, unsure why my Gitlab profile doesn't match up with this one.

Anyhow, I read/reviewed it and I understand it clearly. A few capitalizations missing at the beginning of list items, but unsure how strict you are on that.

🇳🇿New Zealand siramsay

I think removing link is best. For someone new/beginner, it can be confusing. I've been there.

🇳🇿New Zealand siramsay

siramsay made their first commit to this issue’s fork.

🇳🇿New Zealand siramsay

Step 2
2. Find the issue where you want to contribute code [example issue]

Example issue is a fixed issue and doesn't have Create issue fork

🇳🇿New Zealand siramsay

I've applied the patch at #6 to a couple of site so far and can report it is working with 10.3.1.

Can we get a 2.1 version? Is there anyway I can help with that?

🇳🇿New Zealand siramsay

@andres.torres

I'm using 10.2.6. I will test update to 10.3.0 this/next week.

The reason for the code not being included is that someone would need to manage an alias list.

I think the best way around this would be to have an alias list for any of the Drupal core code block module that ships with CKEditor 5. #14
Having a UI administration page could be the way to go for people that want to enhance the alias list.

🇳🇿New Zealand siramsay

@Andres.torres

I have it working with 1.1.2.

See my comment #12

In short, use this https://git.drupalcode.org/project/highlightjs_input_filter/-/merge_requ...
I think this was included in latest release https://www.drupal.org/project/highlightjs_input_filter/issues/3402489#c... 🐛 Error when several instances of same language on the page Fixed

Production build 0.71.5 2024