- Issue created by @Kristen Pol
- Status changed to Needs review
4 months ago 4:51pm 6 August 2024 - ๐บ๐ธUnited States Kristen Pol Santa Cruz, CA, USA
- ๐บ๐ธUnited States Kristen Pol Santa Cruz, CA, USA
Note that Jacob has reviewed and suggesting moving the merge request creation to after the code changes which is a good idea so will do that tomorrow probably.
- ๐บ๐ธUnited States Kristen Pol Santa Cruz, CA, USA
Some other feedback from Jacob:
1. Quotes need fixing.
git commit -m โAdded tag SDC yml file.โ
2. He didn't see the yellow merge request number because the pipeline was running so update doc to reflect this.
3. It wasn't clear to him how to change the status, assigned, etc.
- ๐ณ๐ฟNew Zealand siramsay
Step 2
2. Find the issue where you want to contribute code [example issue]Example issue is a fixed issue and doesn't have Create issue fork
- ๐บ๐ธUnited States Kristen Pol Santa Cruz, CA, USA
Thanks. I was just pointing at an issue that was used for this type of workโฆ I used it when creating the documentationโฆ perhaps Iโll remove the link to avoid confusion
- Assigned to Kristen Pol
- ๐บ๐ธUnited States Kristen Pol Santa Cruz, CA, USA
Assigning back to me but this is still being reviewed by others so will hold off on changes for now.
- ๐ณ๐ฟNew Zealand siramsay
I think removing link is best. For someone new/beginner, it can be confusing. I've been there.
- ๐บ๐ธUnited States sea2709 Texas
I haven't contributed to merge requests before. Is there a sample issue that I can do some trials? I read through the guide and got the ideas, just want to do it by myself!
- Status changed to Needs work
4 months ago 10:02pm 8 August 2024 - ๐บ๐ธUnited States Kristen Pol Santa Cruz, CA, USA
Thanks @siramsay. Will do!
@sea2709 Let me find or create an issue for you to test this out :)
Moving this back to needs work for me to make changes.
- ๐บ๐ธUnited States Kristen Pol Santa Cruz, CA, USA
@sea2709 Please use this one to test:
https://www.drupal.org/project/demo_design_system/issues/3465333#comment... ๐ SDDS SDC Conversion Examples: Map component [MANUAL] Postponed
- ๐บ๐ธUnited States Kristen Pol Santa Cruz, CA, USA
I have made all the changes above except for reordering when you create the MR. I'll wait on @sea2709's feedback before doing that.
- Status changed to Needs review
4 months ago 10:12pm 8 August 2024 - ๐บ๐ธUnited States Kristen Pol Santa Cruz, CA, USA
@sea2709 Did you have any additional feedback based on the MR you did?
- ๐บ๐ธUnited States sea2709 Texas
@Kristen: I just have only one comment, I think step 6 should be placed after step 15 (or at least, that is what I did). After I push changes, I will be able to create a MR.
- Status changed to Needs work
3 months ago 6:19am 10 August 2024 - ๐บ๐ธUnited States Kristen Pol Santa Cruz, CA, USA
@sea2709 Gotcha. So just the reordering of MR creation that Jacob also pointed out. I'll move back to needs work for reworking that.
- Issue was unassigned.
- ๐บ๐ธUnited States Kristen Pol Santa Cruz, CA, USA
@sea2709 Would you have time to rework the guide so the MR is created after the code branch is created and changes are added?
We've been doing that but I haven't had time to update the docs.
- Status changed to Fixed
3 months ago 7:13pm 26 August 2024 - ๐บ๐ธUnited States Kristen Pol Santa Cruz, CA, USA
Going to call this one fixed for now. If someone wants to update to not do the draft MR, just reopen and update the docs.
Automatically closed - issue fixed for 2 weeks with no activity.