- Issue created by @Wim Leers
- π§πͺBelgium Wim Leers Ghent π§πͺπͺπΊ
Now that π Support complex SDC prop shapes: introduce (Storable)PropShape to compute field type storage settings Fixed is in, doing this is even more important.
And now that π Create validation constraint for ComponentTreeStructure Needs work is in, I can do this with more detail, and with more confidence.
- Merge request !141#3461490: Document the current JSON-based data model, and describe in an ADR β (Merged) created by Wim Leers
- Issue was unassigned.
- Status changed to Needs review
about 1 month ago 3:00pm 5 August 2024 - π§πͺBelgium Wim Leers Ghent π§πͺπͺπΊ
ADR draft is ready.
Docs next.
I'm assuming this data model will remain largely unchanged between today and DrupalCon Barcelona (in ~1.5 month). For Barcelona, we'll tag
0.1.0
, per π± Milestone 0.1.0: Experience Builder Demo Active . - π§πͺBelgium Wim Leers Ghent π§πͺπͺπΊ
Didn't push this forward today, but π Create an Open API spec for the current mock HTTP responses Fixed instead. Which also is documentation-related π
- π³πΏNew Zealand siramsay
I just added the comment above, unsure why my Gitlab profile doesn't match up with this one.
Anyhow, I read/reviewed it and I understand it clearly. A few capitalizations missing at the beginning of list items, but unsure how strict you are on that.
- Assigned to Wim Leers
- Status changed to Needs work
27 days ago 12:14pm 12 August 2024 - π§πͺBelgium Wim Leers Ghent π§πͺπͺπΊ
Related: π Create an Open API spec for the current mock HTTP responses Fixed landed. That helps with understanding the big picture, but then the client-server communication part. This issue is solely concerned with server aspects.
@siramsay Thanks for the review! π
- Issue was unassigned.
- Status changed to Needs review
25 days ago 10:40am 14 August 2024 - Assigned to effulgentsia
- π§πͺBelgium Wim Leers Ghent π§πͺπͺπΊ
Addressed all of @longwave's feedback.
Would like to get @effulgentsia and @f.mazeikis to sign off on this too. It's the EOD for @f.mazeikis. So assigning to @effulgentsia. @effulgentsia, please assign to @f.mazeikis after you've reviewed it π
- Assigned to f.mazeikis@gmail.com
- πΊπΈUnited States effulgentsia
I think this all looks great at capturing the current state of things. There's a few unresolved threads from @longwave, but I think those are proposing changes that can be discussed/explored in separate issues and I don't think should hold up merging these docs in.
Passing the review baton to @f.mazeikis :)
- π§πͺBelgium Wim Leers Ghent π§πͺπͺπΊ
@effulgentsia Thanks! :)
Created 2 follow-up issues based on @longwave's comments in https://git.drupalcode.org/project/experience_builder/-/merge_requests/1...
- π§πͺBelgium Wim Leers Ghent π§πͺπͺπΊ
#11: huh, I did respond to everything an hour after he posted that, but GitLab didn't show those to me! π€ͺ Addressed all things I missed last night ππ
Off to @f.mazeikis now!
P.S.: it'd be great to get @tedbow to chime in too, but he's out the rest of the week. I think it'd be better to land this sooner rather than later. I'll be out in a few hours too. Please land this even in my absence. We'll keep evolving the
docs/data-model.md
doc (for example when π `ComponentTreeStructure` date type: simplify the stored structure Active lands), but having this first ADR captures our intent for everyone to find in a compact representation. - Assigned to tedbow
- π¬π§United Kingdom f.mazeikis@gmail.com Brighton
Reviewed, re-read and approved. Nice amount of details in there, the Terminology section alone is worth it's weight in gold. I see @wim-leers is already responding to @longwave threads, so we just need @tedbow to have a look.
- First commit to issue fork.
- Issue was unassigned.
- Status changed to RTBC
23 days ago 7:30pm 15 August 2024 - πΊπΈUnited States tedbow Ithaca, NY, USA
This looks good. I accepted my own suggestion in the MR
- π§πͺBelgium Wim Leers Ghent π§πͺπͺπΊ
With:
- +1 from @effulgentsia in #11, whose abstract proposal was implemented over the past few months, and documented here
- +1 from @f.mazeikis in #14, who has helped achieve this implementation
- +1 from @tedbow in #16, who has helped achieve this implementation
- many questions from @longwave answered, where in private he wrote β which I won't take as agreement/+1, but "yes, this documentation has helped me make sense of why things are the way they currently are", which is the purpose of this issue
I've already opened several follow-ups based on @longwave's feedback (#3468269 + #3468272), and I'm sure that when he gets more involved over time, that he'll make implementation changes which we'll then update these docs for π
-
Wim Leers β
committed 5c9122cd on 0.x
Issue #3461490 by Wim Leers, tedbow, siramsay, longwave, effulgentsia, f...
-
Wim Leers β
committed 5c9122cd on 0.x
- Status changed to Fixed
20 days ago 7:28am 19 August 2024 Automatically closed - issue fixed for 2 weeks with no activity.