- Issue created by @wim leers
- πΊπΈUnited States ctrladel North Carolina, USA
Wim Leers β credited ctrlADel β .
- π§πͺBelgium wim leers Ghent π§πͺπͺπΊ
- Mermaid diagram
*.md
files being out of sync are caught: https://git.drupalcode.org/project/experience_builder/-/jobs/1864229 - Syntax errors are caught: https://git.drupalcode.org/project/experience_builder/-/jobs/1864354
- That was for the single-diagram case, now it's been hardened to work for the multiple diagrams it'll generate.
- Copy/pasting that file into https://structurizr.com/dsl, editing+previewing it there and then copying it back is a pretty good experience β far less fiddly than using OmniGraffle! π
β https://git.drupalcode.org/project/experience_builder/-/merge_requests/60 is ready.
Going ahead and merging this so that I can hit the ground running on Monday π’
- Mermaid diagram
-
Wim Leers β
committed 57092751 on 0.x
Issue #3454677 by Wim Leers, ctrlADel: [PP-1] Diagram tying the product...
-
Wim Leers β
committed 57092751 on 0.x
- π¦πΊAustralia larowlan π¦πΊπ.au GMT+10
I wonder if we need the overhead of the DSL?
Gitlab supports mermaid and we can edit them direct on mermaid.live - π§πͺBelgium wim leers Ghent π§πͺπͺπΊ
FYI: initial diagram of the data model as currently partially implemented and the direction weβve been going in: https://git.drupalcode.org/issue/experience_builder-3454677/-/blob/34546...
P.S.: that's a "direct" Mermaid diagram, which I think will please @larowlan π€
- πΊπΈUnited States ctrladel North Carolina, USA
@larowlan one of the benefits of using structurizr's DSL from is that it's really easy to generate and keep in sync smaller diagrams that are easier to digest and if you put the code in the previewer at https://structurizr.com/dsl it's really easy to zoom in/out on specific areas. I'm not particularly attached to structurizr but am a fan of the concepts behind c4 that encourage diagramming systems at multiple levels of detail so people can more easily onboard.
@wimleers I know these diagrams are early drafts but it looks like XB.dsl is missing Senior Developers as a person and Code Defined components that live alongside Config Defined components.
- π§πͺBelgium wim leers Ghent π§πͺπͺπΊ
The current MR is a decent starting point for capturing both what already exists and what's being discussed in all other "early phase" issues β , except for:
- π± [META] Real-time preview: supporting back-end infrastructure Needs work
- π± [PP-1] Create components for a default design system Postponed
In general, the docs in MR61 are focused on the server-side part of XB. The client-side part of XB will follow later and depends on strong design direction existing there first. Finally: the server side is also where most of the Drupal community's interests & concerns lie, so getting that off the ground first should happen first.
Going ahead and merging to allow referencing the diagrams in the various issues.
-
Wim Leers β
committed a6cd7c1d on 0.x
Issue #3454677 by Wim Leers, ctrlADel: [PP-1] Diagram tying the product...
-
Wim Leers β
committed a6cd7c1d on 0.x
- π§πͺBelgium wim leers Ghent π§πͺπͺπΊ
First issue that builds on top of the two MRs merged here so far: #3455629-12: [later phase] [META] 7. Content type templates β aka "default layouts" β affects the tree+props data model β .
- First commit to issue fork.
- π§πͺBelgium wim leers Ghent π§πͺπͺπΊ
Merging @jessebaker's diagram of the current state of the React front end/client β it's subject to change just like everything else, but it'll help onboard new contributors β and keep existing contributors on the same page.
Now I just need to win the fight with GitLab to actually merge this MR β it's refusing to merge for mysterious reasons β¦
-
Wim Leers β
committed a8fa36d9 on 0.x authored by
jessebaker β
Issue #3454677 by Wim Leers, ctrlADel: [PP-1] Diagram tying the product...
-
Wim Leers β
committed a8fa36d9 on 0.x authored by
jessebaker β
- Issue was unassigned.
- Status changed to Fixed
2 months ago 2:42pm 12 September 2024 - π§πͺBelgium wim leers Ghent π§πͺπͺπΊ
The C4 diagram is still accurate.
Since then,
- π Document the current JSON-based data model, and describe in an ADR Active landed
-
π
Support complex SDC prop shapes: introduce (Storable)PropShape to compute field type storage settings
Fixed
landed and added ADR #2 (and updated
docs/diagrams/data-model.md
) - π Clarify the "shape matching" bits: namespaces, `CODEOWNERS` and as issue queue component Fixed landed
- π Document the current component discovery + SDC criteria, and describe in an ADR Active is about to land and will add ADR #3
I think that's sufficient for us to be able to consider this :)
Automatically closed - issue fixed for 2 weeks with no activity.