- Issue created by @larowlan
- π¦πΊAustralia larowlan π¦πΊπ.au GMT+10
Ah looks like https://git.drupalcode.org/project/experience_builder/-/merge_requests/1... might be just that?
- π§πͺBelgium Wim Leers Ghent π§πͺπͺπΊ
@larowlan I don't think so β that's adding one missing concept: adapters. It touches the matcher, but won't refactor it.
Quoting my response from the MR where you raised this:
Eventually, maybe. Right now, we should first explore what the shape is of the needed solution. In this particular class though I'm not convinced yet we'd need an event/what the benefit would be. Because this is 100% reusing what's in `SdcPropToFieldTypePropMatcher`, it just adds heuristics to generate a sensible ordering. Events implies many pieces of logic collaborating, but that'll result in heuristics fighting/conflicting. In this particular situation, I think replacing the service would be more appropriate.
β https://git.drupalcode.org/project/experience_builder/-/merge_requests/2...
Thoughts?
- First commit to issue fork.
- Assigned to tedbow
- Merge request !71Draft: Resolve #3450496 Refactor SdcPropToFieldTypePropMatcher β (Open) created by tedbow
- Status changed to Needs work
2 days ago 1:43pm 26 June 2024