- Issue created by @Kristen Pol
- πΊπΈUnited States Kristen Pol Santa Cruz, CA, USA
See instructions from Simon Ramsay in Slack as well for XB install.
- πΊπΈUnited States Kristen Pol Santa Cruz, CA, USA
Bumping priority now that the XB team wants us to focus on using D11 standard profile rather than Starshot / Drupal CMS.
- Issue was unassigned.
- Status changed to Needs review
3 months ago 7:05pm 22 August 2024 - πΊπΈUnited States Kristen Pol Santa Cruz, CA, USA
This has been completely refactored and simplified. It's working for me but needs more eyes.
https://www.drupal.org/community-initiatives/starshot-demo-design-system... β
- πΊπΈUnited States Kristen Pol Santa Cruz, CA, USA
Update title and revise tasks.
- πΊπΈUnited States Kristen Pol Santa Cruz, CA, USA
Note that the XB part is just installing it and making sure it shows up. It is not testing the theme components with it. That needs to be in the testing guide which still needs to happen and is waiting on some more working on our side and the XB side.
π Create SDDS project testing guide Needs work
- Assigned to jacobadeutsch
- πΊπΈUnited States Kristen Pol Santa Cruz, CA, USA
Assigning to Jacob for review.
- πΊπΈUnited States sea2709 Texas
The documentation is shorter :-)
There is one thing we might need to pay more attention, in `composer.json` of the demo_design_system theme https://git.drupalcode.org/project/demo_design_system/-/blob/1.0.x/compo..., it requires some modules
- Components
- Field Group
- Focal Point
- etc.
These modules are included in Drupal CMS, but not in D11. I think missing these modules might break some features in the theme, and I don't see the inserting dummy data feature in the theme settings, maybe because of missing some modules.
- πΊπΈUnited States Kristen Pol Santa Cruz, CA, USA
Thanks!
Ah shoot... I guess I need to remove from composer.json... slammed today though o_O
The dummy content stuff was intentionally removed because the sitebuilding stuff that's in CT isn't relevant for the XB demo and it's not ideal to have those extra modules (and some aren't D11 compatible). The config for the extra modules was moved to optional per:
π± [META] Remove unnecessary dependencies before DrupalCon Barcelona Active
But, I want to make sure that those extra modules aren't getting added...
@sea2709 do you have time on your local to test removing from composer and seeing how it goes? If it works okay, then an MR here or on that issue ^ would be appreciated! :)
- πΊπΈUnited States Kristen Pol Santa Cruz, CA, USA
Jacob is also reviewing.
Some notes based on things that have been going on in Slack and in other issues:
- We moved back to D10 because of using the components module that doesn't have a D11 release
- To remove the components module dependency, we'd have to use SDC namespaces which would break Storybook
- There is an open question to the XB team on if they want the components module gone
- When following the current dev guide steps, you will get XB errors due to arrays in the SDC YAML files
See related issues:
π Reconcile components vs SDC namespaces for SDDS includes/embeds Postponed
π± [META] Remove unnecessary dependencies before DrupalCon Barcelona Active
π Implement temporary design system for the DrupalCon Barcelona demo Needs work
π Arrays in SDDS SDC YAMLs are causing fatal errors in XB Postponed - Assigned to Kristen Pol
Instructions were clear and I got XB running and everything. Not sure if the themes were working though, seemed like maybe they weren't.
- πΊπΈUnited States Kristen Pol Santa Cruz, CA, USA
@jacobadeutsch Let's talk through that then. They should show up in list and storybook should work.
- πΊπΈUnited States Kristen Pol Santa Cruz, CA, USA
Moving to postponed as the guide is okay for now but we'll need to see about changing it to D11 if we drop the components module dependency or if it gets a D11 release.
- Issue was unassigned.
- Status changed to Postponed
3 months ago 5:38am 29 August 2024 - πΊπΈUnited States Kristen Pol Santa Cruz, CA, USA
Whoops... change status.
- Status changed to Fixed
3 months ago 10:01pm 29 August 2024 - πΊπΈUnited States Kristen Pol Santa Cruz, CA, USA
Switch this from D11 to D10.
Follow-up issues to move this to D11:
π Switch SDDS to D11 components module once it's available Postponed
and
π Reconcile components vs SDC namespaces for SDDS includes/embeds Postponed
Automatically closed - issue fixed for 2 weeks with no activity.