Standardize an efficient way to load data keyed by route name and parameters

Rerolling patch from comment 30
Fixed PHPCS and Deperactred code.

Fixed Command Failed.

Forgot to attach interdiff

Don't think we can use a persistent cache here, or at least not without adding the relevant cache tags to it.

The original approach here was to add a static cache, 🌱 [policy] Standardize how we implement in-memory caches Needs work has a way to do that without using drupal_static().

Could use an issue summary update. This is also likely cached at a higher level now like the render cache, so we'd want to check if this data is actually requested more than once on the same request (for example after a cache clear).

Seems to still be called a lot, even with a warm cache. Looking at RDS insights it's still a top query under load.

General log is full of the same query, even when trying the page as anon (no page cache, just dynamic cache).

(346 is the current node being viewed)

Could be something with our site but still investigating.

Patch worked once rerolled for 10.3.x, not flooding the query log anymore.

There's a tag set on config:system.menu.[name], not sure if that gets flushed if a link changes.