Allow viewing and reverting to live revisions inside workspaces

Created on 1 December 2024, 4 months ago

Problem/Motivation

When viewing the revision tab of an entity inside a workspace, it's currently not possible to even see any other revisions than the ones created inside that workspace. So no live revisions are listed and as a consequence, it's neither possible to revert to live revisions while it should actually be possible.

The diff module should also be supported, meaning it should be possible to diff to live revisions.

This should eventually be solved in core workspaces, but I'm creating this here first to push some WIP code and a PoC first.

Steps to reproduce

  • Create a node in live, save it and create one more revision
  • Switch to a workspace
  • Create two more revisions inside the workspace
  • Navigate to the revisions tab of the node

The live revisions aren't listed inside the workspace.

Proposed resolution

Change the revision controllers and access checks such that live revisions are listed and can be reverted to from inside a workspace.

Remaining tasks

User interface changes

API changes

Data model changes

πŸ“Œ Task
Status

Active

Version

2.0

Component

Code

Created by

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @s_leu
  • Pipeline finished with Success
    4 months ago
    Total: 388s
    #355377
  • Pipeline finished with Success
    4 months ago
    Total: 270s
    #355382
  • Pipeline finished with Success
    4 months ago
    Total: 163s
    #355410
  • Pipeline finished with Success
    4 months ago
    Total: 475s
    #360797
  • Pipeline finished with Success
    4 months ago
    Total: 358s
    #360837
  • Pipeline finished with Success
    4 months ago
    Total: 199s
    #361020
  • This is ready for a first review.

  • Pipeline finished with Success
    4 months ago
    Total: 221s
    #361051
  • Pipeline finished with Failed
    4 months ago
    Total: 144s
    #361113
  • Pipeline finished with Failed
    4 months ago
    Total: 142s
    #361123
  • Pipeline finished with Failed
    4 months ago
    Total: 142s
    #361132
  • Pipeline finished with Failed
    4 months ago
    Total: 147s
    #361144
  • Pipeline finished with Failed
    4 months ago
    Total: 145s
    #361171
  • There revert button for the latest live revision isn't accessible inside workspaces and CI fails.

  • Pipeline finished with Failed
    4 months ago
    Total: 140s
    #365118
  • Pipeline finished with Failed
    4 months ago
    Total: 141s
    #365252
  • s_leu β†’ changed the visibility of the branch 3490853-revisions-of-nested-ws to hidden.

  • Pipeline finished with Success
    4 months ago
    Total: 247s
    #365346
  • Pipeline finished with Success
    4 months ago
    Total: 170s
    #365360
  • Pipeline finished with Success
    4 months ago
    Total: 306s
    #365376
  • Pipeline finished with Success
    4 months ago
    Total: 243s
    #365404
  • Pipeline finished with Success
    4 months ago
    Total: 182s
    #365411
  • πŸ‡ΊπŸ‡ΈUnited States djdevin Philadelphia

    I closed ✨ Option to show all revisions on Workspace-enabled content Active in favor of this

    Just wanted to note that it would be useful to show the Workspace the revision belongs to, which I think is happening in the MR!

  • Pipeline finished with Skipped
    4 months ago
    #366938
  • Pipeline finished with Failed
    4 months ago
    Total: 207s
    #370934
  • After discussing this with amateescu, the logic for altering the revert operation access results shouldn't live in an override of NodeAccessControlHandler because this will clash with what the Trash module is doing. Instead, the coresponding code in core needs to change, I filed an MR for this in πŸ› Revision revert links in workspace respond with 404 not found Active .

  • Pipeline finished with Canceled
    4 months ago
    Total: 190s
    #371134
  • Pipeline finished with Failed
    4 months ago
    Total: 193s
    #371139
  • Pipeline finished with Failed
    4 months ago
    Total: 192s
    #371885
  • Pipeline finished with Failed
    4 months ago
    Total: 191s
    #372226
  • Pipeline finished with Success
    3 months ago
    Total: 706s
    #377506
  • Pipeline finished with Success
    3 months ago
    Total: 282s
    #381412
  • Pipeline finished with Success
    3 months ago
    Total: 239s
    #381553
  • Pipeline finished with Success
    3 months ago
    Total: 558s
    #385233
  • Pipeline finished with Success
    3 months ago
    Total: 727s
    #385398
  • Pipeline finished with Success
    3 months ago
    Total: 655s
    #385416
  • Pipeline finished with Success
    3 months ago
    Total: 565s
    #385831
  • Pipeline finished with Skipped
    3 months ago
    #390236
  • Pipeline finished with Success
    3 months ago
    Total: 732s
    #393678
  • Pipeline finished with Canceled
    3 months ago
    Total: 93s
    #393685
  • First commit to issue fork.
  • Merge request !96Resolve #3490853 "Fix revision overview" β†’ (Merged) created by amateescu
  • Status changed to Needs review 2 months ago
  • πŸ‡·πŸ‡΄Romania amateescu

    amateescu β†’ changed the visibility of the branch 3490853-live-revisions-in-ws_2.0.0-alpha6 to hidden.

  • πŸ‡·πŸ‡΄Romania amateescu

    amateescu β†’ changed the visibility of the branch 3490853-live-revisions-in-ws to hidden.

  • Pipeline finished with Failed
    2 months ago
    Total: 201s
    #411084
  • πŸ‡·πŸ‡΄Romania amateescu

    After giving this a lot of thought and trying various things, decided to go in a different direction than the latest MRs:

    - stop filtering revisions -> all revisions are visible on the overview page regardless whether you're in a workspace or not
    - add a Workspace table column (at the end)
    - prevent revert and delete revision operations when an entity is tracked in a workspace and you're viewing the revision overview page from Live or a different workspace

  • Pipeline finished with Success
    2 months ago
    Total: 219s
    #411086
  • Pipeline finished with Skipped
    2 months ago
    #411090
    • amateescu β†’ committed 37fd4349 on 2.0.x
      Issue #3490853 by s_leu, amateescu: Allow viewing and reverting to live...
    • amateescu β†’ committed b8a4e8d3 on 1.0.x
      Issue #3490853 by s_leu, amateescu: Allow viewing and reverting to live...
  • πŸ‡·πŸ‡΄Romania amateescu

    Merged into 2.0.x and cherry-picked to 1.0.x, thanks for all the work here!

  • Pipeline finished with Skipped
    about 2 months ago
    #420955
  • Automatically closed - issue fixed for 2 weeks with no activity.

  • Pipeline finished with Success
    about 2 months ago
    Total: 437s
    #426690
  • Pipeline finished with Success
    about 2 months ago
    Total: 512s
    #426699
  • Pipeline finished with Failed
    about 1 month ago
    Total: 174s
    #430709
  • Pipeline finished with Success
    about 1 month ago
    Total: 207s
    #434007
  • Pipeline finished with Success
    about 1 month ago
    Total: 289s
    #434018
  • Pipeline finished with Success
    about 1 month ago
    Total: 559s
    #434168
  • Pipeline finished with Success
    about 1 month ago
    Total: 586s
    #434207
  • Pipeline finished with Success
    about 1 month ago
    Total: 558s
    #434723
  • Pipeline finished with Success
    about 1 month ago
    Total: 148s
    #434991
  • Pipeline finished with Skipped
    about 1 month ago
    #435102
  • Pipeline finished with Success
    about 1 month ago
    Total: 791s
    #438247
  • Pipeline finished with Success
    about 1 month ago
    Total: 315s
    #438418
  • Pipeline finished with Skipped
    27 days ago
    #444949
  • Pipeline finished with Success
    19 days ago
    Total: 160s
    #451524
  • Pipeline finished with Success
    18 days ago
    Total: 146s
    #452080
  • Pipeline finished with Failed
    17 days ago
    Total: 361s
    #453387
  • Pipeline finished with Success
    17 days ago
    Total: 224s
    #453402
  • Pipeline finished with Failed
    17 days ago
    Total: 115s
    #453420
  • Pipeline finished with Failed
    17 days ago
    Total: 320s
    #453441
  • Pipeline finished with Failed
    17 days ago
    Total: 200s
    #453444
  • Pipeline finished with Failed
    17 days ago
    Total: 208s
    #453456
  • Pipeline finished with Failed
    17 days ago
    Total: 283s
    #453462
  • Pipeline finished with Canceled
    17 days ago
    Total: 195s
    #453472
  • Pipeline finished with Failed
    17 days ago
    Total: 208s
    #453474
  • Pipeline finished with Success
    17 days ago
    Total: 347s
    #453476
  • Pipeline finished with Canceled
    17 days ago
    Total: 128s
    #453480
  • Pipeline finished with Success
    17 days ago
    Total: 252s
    #453482
  • Pipeline finished with Success
    17 days ago
    Total: 223s
    #453485
  • Pipeline finished with Success
    17 days ago
    Total: 228s
    #453491
  • Pipeline finished with Success
    17 days ago
    Total: 246s
    #453500
Production build 0.71.5 2024