- Issue created by @s_leu
- Merge request !85Issue #3490853: List live revisions inside workspaces β (Closed) created by s_leu
There revert button for the latest live revision isn't accessible inside workspaces and CI fails.
s_leu β changed the visibility of the branch 3490853-revisions-of-nested-ws to hidden.
- πΊπΈUnited States djdevin Philadelphia
I closed β¨ Option to show all revisions on Workspace-enabled content Active in favor of this
Just wanted to note that it would be useful to show the Workspace the revision belongs to, which I think is happening in the MR!
After discussing this with amateescu, the logic for altering the revert operation access results shouldn't live in an override of
NodeAccessControlHandler
because this will clash with what the Trash module is doing. Instead, the coresponding code in core needs to change, I filed an MR for this in π Revision revert links in workspace respond with 404 not found Active .- First commit to issue fork.
- Status changed to Needs review
2 months ago 10:13am 31 January 2025 - π·π΄Romania amateescu
amateescu β changed the visibility of the branch 3490853-live-revisions-in-ws_2.0.0-alpha6 to hidden.
- π·π΄Romania amateescu
amateescu β changed the visibility of the branch 3490853-live-revisions-in-ws to hidden.
- π·π΄Romania amateescu
After giving this a lot of thought and trying various things, decided to go in a different direction than the latest MRs:
- stop filtering revisions -> all revisions are visible on the overview page regardless whether you're in a workspace or not
- add aWorkspace
table column (at the end)
- prevent revert and delete revision operations when an entity is tracked in a workspace and you're viewing the revision overview page from Live or a different workspace -
amateescu β
committed 37fd4349 on 2.0.x
Issue #3490853 by s_leu, amateescu: Allow viewing and reverting to live...
-
amateescu β
committed 37fd4349 on 2.0.x
-
amateescu β
committed b8a4e8d3 on 1.0.x
Issue #3490853 by s_leu, amateescu: Allow viewing and reverting to live...
-
amateescu β
committed b8a4e8d3 on 1.0.x
- π·π΄Romania amateescu
Merged into 2.0.x and cherry-picked to 1.0.x, thanks for all the work here!
Automatically closed - issue fixed for 2 weeks with no activity.