- Issue created by @malcomio
- Status changed to Needs work
11 months ago 8:51am 7 June 2024 - 🇺🇸United States xjm
We would need a merge request created against 11.x first (which would be backported to other branches once committed). (Also, the existing branch appears to be empty.) Thanks!
- First commit to issue fork.
s_leu → changed the visibility of the branch 3440304-revision-revert-links to hidden.
- Merge request !10586Issue #3440304: Allow altering of entity 'revert'/node 'revert revision' access → (Open) created by s_leu
The MR i opened here in combination with the changes of the MR for 📌 Allow viewing and reverting to live revisions inside workspaces Active will allow reverting to non default revisions inside a workspace. It's worth to note that the MR for wse will also enable listing of live revisions inside workspaces.
The MR here will only change core's entity and node access control handlers in a way which will allow us to alter access for revert operations on default revisions.
s_leu → changed the visibility of the branch 3440304-non-default-revision-revert-10.x to hidden.
- First commit to issue fork.
- 🇷🇴Romania amateescu
The original problem from the current issue summary was fixed in 📌 Revert and Delete actions should not be available for the current revision Active , but that issue introduced a new problem: when you have pending revisions (e.g. make changes in a workspace), you can not revert to the default revision, while you can revert the latest (workspace) revision. This doesn't make sense and it was actually one of the goals of the issue mentioned above, but somehow missed in the implementation.
The current MR is fixing the new problem in the entity API, so I'm going to repurpose this issue since it's not workspace-specific anymore.
- Status changed to Needs review
2 months ago 7:40pm 25 February 2025 - 🇺🇸United States smustgrave
Leaving in review for others
But aren't we losing coverage with all the tests that needed to be updated? Also won't this be introducing a new behavior for users. Tests all seem to be reverting what it was originally testing.
Example
Link should appear => Link should not appear now - 🇷🇴Romania amateescu
Re #11: Those test changes are reverting the wrong assumptions made in 📌 Revert and Delete actions should not be available for the current revision Active , which didn't take into account that it should be possible to revert to the default revision when there are pending revisions.
- 🇺🇸United States smustgrave
Gotcha, will lean on that then and in that case change seems fine
- 🇬🇧United Kingdom catch
The overall logic looks fine, but a couple of small questions on the MR.