😢😢 Anyone knows where is the documentation about introducing a new method inside a public interface ?
I've fixed the latest comments
When this is committed can the related issue also be closed? ✨ Support ROLLUP modifier for GROUP BY Active
Yes, it can.
Small stuff fixed and rebased
I've updated the MR with the remarks in #18
I have updated the merge request :
- It is now targeted at the 11.x branch
- It doesn't changed the internal storage of $group anymore
- It includes the test provided by #9
Hello,
The "WITH ROLLUP" modifier syntax does not exists in PostgreSQL :
Also, as you can see from the issue description, we need to be able to use multiple fields inside the ROLLUP function.
Your proposed solution does not address both of theses issues.
ROLLUP was working fine in Drupal 9.x with Postgresql 14 until 9.5.3. See 🐛 Adding escaping for the GROUP BY fields broke ROLLUP support Needs review .
I've created the first draft for a potential fix.
When applied on my Drupal 9.5.3 installation, the bug is fixed.
This first draft changes the internal storage of the group By clauses inside of Drupal\Core\Database\Query\Select and therefore change the return value of Drupal\Core\Database\Query\Select::getOrderBy().
Since the return value of Drupal\Core\Database\Query\Select::getOrderBy() is not strictly specified nor documented, is this considered a breaking change or not ?
I've updated the MR to Drupal Core 10.0.x and all the tests passes.
I updated the issue description to match Drupal 10.0.x (the issue is still present with 10.0.3)