- 🇮🇹Italy apaderno Brescia, 🇮🇹
Actually, Your current password is missing or incorrect; it's required to change the %name. is not easier to translate, not even in Italian.
In Italian, the translation of Your current password is missing or incorrect; it's required to change the email. is La tua password corrente è mancante o errata; è necessaria per modificare l'email.. The translation of Your current password is missing or incorrect; it's required to change the password. is La tua password corrente è mancante o errata; è necessaria per modificare la password..
In Russian, the translation for Your current password is missing or incorrect; it's required to change the %name. Your current password is missing or incorrect; it's required to change the email. Your current password is missing or incorrect; it's required to change the password. are the following.
- Ваш текущий пароль отсутствует или неверен; необходимо изменить %name.
- Ваш текущий пароль отсутствует или неверен; необходимо изменить электронную почту.
- Ваш текущий пароль отсутствует или неверен; требуется сменить пароль.
Also in this case, the sentence changes basing on what replaces %name.
- 🇮🇳India amanbtr72
amanmansuri72 → made their first commit to this issue’s fork.
- Status changed to Needs review
5 months ago 7:40am 23 July 2024 - 🇳🇿New Zealand quietone
There is some confusion here. I was referring to the string in the issue summary. The string in the issue summary is "Enter your current password to change the %mail or %pass. !request_new." That string was changed in core 2011, #1326172: Improve wording of the "Current password" field description on the user edit form → , to "Required if you want to change the %mail or %pass below". That string is still in core.
The string in #36, is different from those two. The string in #36 added in 2010 in [#8629]. So, I think that should be a separate issue.
- Status changed to Needs work
5 months ago 7:45am 23 July 2024 The Needs Review Queue Bot → tested this issue.
While you are making the above changes, we recommend that you convert this patch to a merge request → . Merge requests are preferred over patches. Be sure to hide the old patch files as well. (Converting an issue to a merge request without other contributions to the issue will not receive credit.)
- 🇮🇹Italy apaderno Brescia, 🇮🇹
My comment was a reply to comment #35, which says:
I tested this on 9.2.x and the string
Enter your current password to change the %mail or %pass.
does not exist in the code base nor in 8.9.x.It was replaced with <code>Your current password is missing or incorrect; it's required to change the %name.
in #2418119: REST user updates bypass tightened user account change validation → in March 2015. The new string is easier to translate (looking at the Italian translation right now).Since the string still exists in D7 moving to the Drupal 7 issue queue.
I did not check which string was actually used, but that comment said the string used in Drupal 7 was replaced from
Your current password is missing or incorrect; it's required to change the %name.
, which is them said to be easier to translate. - 🇮🇹Italy apaderno Brescia, 🇮🇹
Even Required if you want to change the %mail or %pass below has the same issue the original string has: Other languages could have more than a definite article, or could use no definite article at all.
In Italian, the definite articles are il, lo, la, gli, i, le, not considering that it is l'email, not la email, but it is la mail. Without knowing which word is used, after the article, I can just guess basing on the placeholder, with the consequence that l'mail or la email could appear, depending on my guess and what value is used for %mail. - 🇮🇹Italy apaderno Brescia, 🇮🇹
In Norvegian seems to be even more difficult, as the translation of la signora seems to be damen, while the translation of il bambino seems to be barnet. In both the cases, the bold part in the word is what replaces the article. (The translation of signora would be dam.)
- Status changed to Active
5 months ago 11:38am 23 July 2024 - 🇳🇿New Zealand quietone
So, I came to two different conclusions based on my git research. That doesn't help this at all!
I have updated the issue summary
@avpaderno, do you have a suggestions to fix this?
- 🇮🇹Italy apaderno Brescia, 🇮🇹
The solution is simple: Do not use placeholders after an article.
- 🇮🇹Italy apaderno Brescia, 🇮🇹
The only time the %mail is used in a translatable string is in the core/modules/user/src/AccountForm.php file.
I would leave other cases of placeholder after an article to other issues. - Merge request !9061Issue #973772: Hard to translate: "Required if you want to change the %mail or %pass below." → (Closed) created by apaderno
- Status changed to Needs review
5 months ago 1:31pm 3 August 2024 - Status changed to Needs work
5 months ago 1:33pm 6 August 2024 - 🇺🇸United States smustgrave
Could the issue summary be updated to the standard template please.
- Status changed to Needs review
4 months ago 11:02am 24 August 2024 - 🇮🇹Italy apaderno Brescia, 🇮🇹
I apologize: I was not able to retrieve this issue.
- Status changed to RTBC
4 months ago 11:06pm 29 August 2024 - 🇺🇸United States smustgrave
Much appreciated @avpaderno believe the change is good.
- 🇬🇧United Kingdom catch
Committed/pushed to 11.x and cherry-picked to 10.4.x, thanks!
- Status changed to Fixed
4 months ago 12:04am 31 August 2024 Automatically closed - issue fixed for 2 weeks with no activity.