- Issue created by @bhaveshdas
- Issue was unassigned.
- Status changed to Needs review
4 months ago 7:49am 9 July 2024 - š®š³India bhaveshdas
I have fixed phpcs issuse could you please review it.
Thankyou !
- Status changed to Needs work
4 months ago 10:53am 9 July 2024 - šµšPhilippines cleavinjosh
Hi @bhaveshdas,
I applied MR!5 and it fixed the phpcs issue. After I ran phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml I still encounter an issue.
ā frontpage_per_lang git:(main) ā curl https://git.drupalcode.org/project/frontpage_per_lang/-/merge_requests/5... | patch -p1
% Total % Received % Xferd Average Speed Time Time Time Current
Dload Upload Total Spent Left Speed
100 496 0 496 0 0 1156 0 --:--:-- --:--:-- --:--:-- 1158
patching file README.md
ā frontpage_per_lang git:(main) ā ..
ā contrib git:(main) ā phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml frontpage_per_langFILE: /Users/interns/Demo-site/drupal-org-issues/web/modules/contrib/frontpage_per_lang/frontpage_per_lang.info.yml
-------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 1 LINE
-------------------------------------------------------------------------------------------------------------------
1 | WARNING | Remove "project" from the info file, it will be added by drupal.org packaging automatically
1 | WARNING | Remove "datestamp" from the info file, it will be added by drupal.org packaging automatically
1 | WARNING | Remove "version" from the info file, it will be added by drupal.org packaging automatically
-------------------------------------------------------------------------------------------------------------------Time: 239ms; Memory: 10MB
ā contrib git:(main) ā
Please check and advise.
Thank you. - š®š³India amanbtr72
Reviewed and tested MR-5 no error was found, so moving it forward to RTBC.
Thanks
- Status changed to RTBC
4 months ago 11:34am 9 July 2024