Fix the issues reported by phpcs

Created on 9 July 2024, 4 months ago

Problem/Motivation

command -:
vendor/bin/phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,js,info,txt,md,yml,twig modules/contrib/frontpage_per_lang/

FILE: /var/www/html/drupal-contri-d10/modules/contrib/frontpage_per_lang/README.md
----------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
----------------------------------------------------------------------------------
 3 | WARNING | Line exceeds 80 characters; contains 83 characters
----------------------------------------------------------------------------------


FILE: /var/www/html/drupal-contri-d10/modules/contrib/frontpage_per_lang/frontpage_per_lang.info.yml
-------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 1 LINE
-------------------------------------------------------------------------------------------------------------
 1 | WARNING | Remove "project" from the info file, it will be added by drupal.org packaging automatically
 1 | WARNING | Remove "datestamp" from the info file, it will be added by drupal.org packaging automatically
 1 | WARNING | Remove "version" from the info file, it will be added by drupal.org packaging automatically
-------------------------------------------------------------------------------------------------------------

Time: 123ms; Memory: 10MB

Steps to reproduce

Run PHPCS on Config Pages module.

Proposed resolution

Fixed the coding standards.

Remaining tasks

Submit the patch either MR.

šŸ“Œ Task
Status

RTBC

Version

1.0

Component

Code

Created by

šŸ‡®šŸ‡³India bhaveshdas

Live updates comments and jobs are added and updated live.
  • Coding standards

    It involves compliance with, or the content of coding standards. Requires broad community agreement.

Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @bhaveshdas
  • Issue was unassigned.
  • Status changed to Needs review 4 months ago
  • šŸ‡®šŸ‡³India bhaveshdas

    I have fixed phpcs issuse could you please review it.

    Thankyou !

  • Pipeline finished with Success
    4 months ago
    Total: 137s
    #219566
  • Status changed to Needs work 4 months ago
  • šŸ‡µšŸ‡­Philippines cleavinjosh

    Hi @bhaveshdas,

    I applied MR!5 and it fixed the phpcs issue. After I ran phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml I still encounter an issue.

    āžœ frontpage_per_lang git:(main) āœ— curl https://git.drupalcode.org/project/frontpage_per_lang/-/merge_requests/5... | patch -p1
    % Total % Received % Xferd Average Speed Time Time Time Current
    Dload Upload Total Spent Left Speed
    100 496 0 496 0 0 1156 0 --:--:-- --:--:-- --:--:-- 1158
    patching file README.md
    āžœ frontpage_per_lang git:(main) āœ— ..
    āžœ contrib git:(main) āœ— phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml frontpage_per_lang

    FILE: /Users/interns/Demo-site/drupal-org-issues/web/modules/contrib/frontpage_per_lang/frontpage_per_lang.info.yml
    -------------------------------------------------------------------------------------------------------------------
    FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 1 LINE
    -------------------------------------------------------------------------------------------------------------------
    1 | WARNING | Remove "project" from the info file, it will be added by drupal.org packaging automatically
    1 | WARNING | Remove "datestamp" from the info file, it will be added by drupal.org packaging automatically
    1 | WARNING | Remove "version" from the info file, it will be added by drupal.org packaging automatically
    -------------------------------------------------------------------------------------------------------------------

    Time: 239ms; Memory: 10MB

    āžœ contrib git:(main) āœ—

    Please check and advise.
    Thank you.

  • šŸ‡®šŸ‡³India amanbtr72

    Reviewed and tested MR-5 no error was found, so moving it forward to RTBC.

    Thanks

  • Status changed to RTBC 4 months ago
Production build 0.71.5 2024