- Issue created by @DamienMcKenna
- First commit to issue fork.
- Status changed to Needs review
5 months ago 7:04am 17 July 2024 - 🇮🇳India ankitv18
@DamienMcKenna with the regression reported in 3.x version due to renderPlain I've decided to move that deprecation warning into phpstan-baseline and revisit at the time D12 readiness.
- Status changed to Needs work
5 months ago 8:40am 17 July 2024 - 🇮🇳India ankitv18
I'm considering this https://www.drupal.org/project/schema_metatag/issues/3461911 🐛 Error: Cannot use object of type Drupal\Core\StringTranslation\TranslatableMarkup.... Active to be fixed first then we can update the MR accordingly.
- Status changed to RTBC
5 months ago 9:55am 17 July 2024 - 🇮🇳India bhaveshdas
Hi,
I have verified the PHPCS issue with the #3461461 merge request applied cleanly in the Drupal 10 version.
Testing Steps:
-> Install the Drupal 10 version.
-> Open the command line and run PHPCS on this module.
-> Check for errors and warnings.Testing Results:
Showing no errors and warnings.Attached the after screenshots. Based on these results, the issue can be moved to RTBC.
RTBC+1
- 🇺🇸United States DamienMcKenna NH, USA
Adding Extatic who worked on another ticket that this absorbed.
- Status changed to Fixed
5 months ago 5:08pm 5 August 2024 -
DamienMcKenna →
committed a9f27916 on 8.x-2.x authored by
ankitv18 →
Issue #3461461 by ankitv18, DamienMcKenna, bhaveshdas, Extatic: Fix...
-
DamienMcKenna →
committed a9f27916 on 8.x-2.x authored by
ankitv18 →
Automatically closed - issue fixed for 2 weeks with no activity.