- Issue created by @Prem Suthar
- First commit to issue fork.
- Status changed to Needs review
about 2 months ago 12:15pm 23 July 2024 - š®š³India Sourav_Paul Kolkata
@tzatziki Kindly review changes & merge it..
- Status changed to Needs work
about 2 months ago 12:35pm 23 July 2024 - šµšPhilippines cleavinjosh
Hi @Sourav_Paul,
I applied MR!1 and it was applied smoothly. However, I still encountered some issues after I ran
</code>. <code>ā ckeditor5_dark_mode git:(1.0.0) curl https://git.drupalcode.org/project/ckeditor5_dark_mode/-/merge_requests/1.diff | patch -p1 % Total % Received % Xferd Average Speed Time Time Time Current Dload Upload Total Spent Left Speed 100 2045 0 2045 0 0 4789 0 --:--:-- --:--:-- --:--:-- 4789 patching file README.md patching file css/dark.css ā ckeditor5_dark_mode git:(1.0.0) ā .. ā contrib phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml ckeditor5_dark_mode FILE: /Users/interns/Demo-site/drupal-org-issues/web/modules/contrib/ckeditor5_dark_mode/css/dark.css ----------------------------------------------------------------------------------------------------- FOUND 3 ERRORS AFFECTING 3 LINES ----------------------------------------------------------------------------------------------------- 104 | ERROR | [x] Selectors must be on a single line 105 | ERROR | [x] Blank lines are not allowed between class names 106 | ERROR | [ ] Style definitions must end with a semicolon ----------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY ----------------------------------------------------------------------------------------------------- Time: 125ms; Memory: 10MB ā contrib
Thank you.
- Status changed to Needs review
about 2 months ago 12:46pm 23 July 2024 Hi, patch was applied cleanly.
curl https://git.drupalcode.org/project/ckeditor5_dark_mode/-/merge_requests/1.diff | git apply -v % Total % Received % Xferd Average Speed Time Time Time Current Dload Upload Total Spent Left Speed 100 6314 0 6314 0 0 11343 0 --:--:-- --:--:-- --:--:-- 11846 Checking patch README.md... Checking patch css/dark.css... Applied patch README.md cleanly. Applied patch css/dark.css cleanly.
Tested with phpcs after applying patch, did not encounter any errors.
- š®š³India Sourav_Paul Kolkata
@tzatziki Could you please look into this MR?
- Status changed to RTBC
6 days ago 7:33am 2 September 2024 - š®š³India Tirupati_Singh
Hi, I've applied the provided MR as a patch and it applied cleanly with no errors. After patch and running command
vendor/bin/phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig
all the mentioned phpcs issues resolved successfully and the module is working perfect. Attaching the screenshots for reference.Thanks!