Contrib.social

@vishwenderbaloria

Open on Drupal.org →Open on Drupal Gitlab →
Account created on 17 February 2023, almost 2 years ago
#

Merge Requests

Recent comments

📌 | Bulk Update User Roles | Remove un-use hook in .module file
Comment 4 months ago →
vishwenderbaloria

Hi, applied MR2. The patch was applied successcfully. Attaching screenshot

🐛 | Resource Hints | Fix PHPstan error
Comment 4 months ago →
vishwenderbaloria

The MR5 was successfully applied. Have attached screenshot of before and after the merge request.

📌 | CKEditor5 Dark Mode | Fix the issues reported by phpcs
Comment 4 months ago →
vishwenderbaloria

Hi, patch was applied cleanly.

curl https://git.drupalcode.org/project/ckeditor5_dark_mode/-/merge_requests/1.diff | git apply -v
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100  6314    0  6314    0     0  11343      0 --:--:-- --:--:-- --:--:-- 11846
Checking patch README.md...
Checking patch css/dark.css...
Applied patch README.md cleanly.
Applied patch css/dark.css cleanly.

Tested with phpcs after applying patch, did not encounter any errors.

🐛 | Bootstrap Layouts | Phpcs standard fix.
Comment 4 months ago →
vishwenderbaloria

Got these issues after applying patch. Please review. 

FILE: /app/modules/contrib/bootstrap_layouts/README.md
----------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
----------------------------------------------------------------------
 3 | WARNING | Line exceeds 80 characters; contains 81 characters
----------------------------------------------------------------------


FILE: /app/modules/contrib/bootstrap_layouts/bootstrap_layouts.install
----------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
----------------------------------------------------------------------
 66 | ERROR | Inline doc block comments are not allowed; use "/*
    |       | Comment */" or "// Comment" instead
 74 | ERROR | Inline doc block comments are not allowed; use "/*
    |       | Comment */" or "// Comment" instead
----------------------------------------------------------------------


FILE: /app/modules/contrib/bootstrap_layouts/bootstrap_layouts.module
----------------------------------------------------------------------
FOUND 6 ERRORS AFFECTING 6 LINES
----------------------------------------------------------------------
  64 | ERROR | [x] list(...) is forbidden, use [...] instead.
  91 | ERROR | [x] Use null coalesce operator instead of ternary
     |       |     operator.
  92 | ERROR | [x] Use null coalesce operator instead of ternary
     |       |     operator.
  93 | ERROR | [x] Use null coalesce operator instead of ternary
     |       |     operator.
  94 | ERROR | [x] Use null coalesce operator instead of ternary
     |       |     operator.
 106 | ERROR | [x] Use null coalesce operator instead of ternary
     |       |     operator.
----------------------------------------------------------------------
PHPCBF CAN FIX THE 6 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------


FILE: /app/modules/contrib/bootstrap_layouts/src/BootstrapLayout.php
----------------------------------------------------------------------
FOUND 4 ERRORS AND 1 WARNING AFFECTING 5 LINES
----------------------------------------------------------------------
  10 | WARNING | [ ] The class short comment should describe what the
     |         |     class does and not simply repeat the class name
  91 | ERROR   | [x] Use null coalesce operator instead of ternary
     |         |     operator.
 119 | ERROR   | [x] Use null coalesce operator instead of ternary
     |         |     operator.
 229 | ERROR   | [x] Use null coalesce operator instead of ternary
     |         |     operator.
 244 | ERROR   | [x] Use null coalesce operator instead of ternary
     |         |     operator.
----------------------------------------------------------------------
PHPCBF CAN FIX THE 4 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------


FILE: ...odules/contrib/bootstrap_layouts/src/BootstrapLayoutsManager.php
----------------------------------------------------------------------
FOUND 2 ERRORS AND 2 WARNINGS AFFECTING 4 LINES
----------------------------------------------------------------------
  13 | ERROR   | [x] Use statements should be sorted alphabetically.
     |         |     The first wrong one is
     |         |     Drupal\Core\Layout\LayoutPluginManager.
  19 | WARNING | [ ] The class short comment should describe what the
     |         |     class does and not simply repeat the class name
 204 | ERROR   | [x] Use null coalesce operator instead of ternary
     |         |     operator.
 279 | WARNING | [ ] Unused variable $handler_id.
----------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------


FILE: .../contrib/bootstrap_layouts/src/BootstrapLayoutsPluginManager.php
----------------------------------------------------------------------
FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES
----------------------------------------------------------------------
 65 | WARNING | \Drupal calls should be avoided in classes, use
    |         | dependency injection instead
 75 | WARNING | \Drupal calls should be avoided in classes, use
    |         | dependency injection instead
----------------------------------------------------------------------


FILE: ...rib/bootstrap_layouts/src/BootstrapLayoutsUninstallValidator.php
----------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
----------------------------------------------------------------------
 10 | WARNING | The class short comment should describe what the
    |         | class does and not simply repeat the class name
----------------------------------------------------------------------


FILE: ...outs/src/Plugin/BootstrapLayouts/BootstrapLayoutsHandlerBase.php
----------------------------------------------------------------------
FOUND 1 ERROR AND 1 WARNING AFFECTING 2 LINES
----------------------------------------------------------------------
 12 | WARNING | [ ] The class short comment should describe what the
    |         |     class does and not simply repeat the class name
 39 | ERROR   | [x] Use null coalesce operator instead of ternary
    |         |     operator.
----------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------


FILE: ...src/Plugin/BootstrapLayouts/BootstrapLayoutsHandlerInterface.php
----------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
----------------------------------------------------------------------
 13 | WARNING | The class short comment should describe what the
    |         | class does and not simply repeat the class name
----------------------------------------------------------------------


FILE: ...les/contrib/bootstrap_layouts/src/Plugin/BootstrapLayouts/Ds.php
----------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------
 26 | ERROR | [x] Use null coalesce operator instead of ternary
    |       |     operator.
----------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------


FILE: ...ib/bootstrap_layouts/src/Plugin/BootstrapLayouts/PageManager.php
----------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------
 40 | ERROR | [x] Use null coalesce operator instead of ternary
    |       |     operator.
----------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------


FILE: ...rib/bootstrap_layouts/src/Plugin/Layout/BootstrapLayoutsBase.php
----------------------------------------------------------------------
FOUND 2 ERRORS AND 1 WARNING AFFECTING 3 LINES
----------------------------------------------------------------------
  11 | ERROR   | [x] Use statements should be sorted alphabetically.
     |         |     The first wrong one is
     |         |     Drupal\Core\Layout\LayoutDefault.
  21 | WARNING | [ ] Possible useless method overriding detected
 153 | ERROR   | [x] Use null coalesce operator instead of ternary
     |         |     operator.
----------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------

Time: 1.67 secs; Memory: 12MB
📌 | Migrate Tools | Fix PHPCS issues
Comment 4 months ago →
vishwenderbaloria

I tested with MR 53. Found these errors. Please check

FILE: ...ontrib/migrate_tools/src/Drush/Commands/MigrateToolsCommands.php
----------------------------------------------------------------------
FOUND 20 ERRORS AFFECTING 10 LINES
----------------------------------------------------------------------
104 | ERROR | [x] The first parameter of a multi-line function
| | declaration must be on the line after the opening
| | bracket
104 | ERROR | [x] Multi-line function declarations must define one
| | parameter per line
108 | ERROR | [x] Multi-line function declarations must have a
| | trailing comma after the last parameter
108 | ERROR | [x] The closing parenthesis of a multi-line function
| | declaration must be on a new line
258 | ERROR | [x] The first parameter of a multi-line function
| | declaration must be on the line after the opening
| | bracket
258 | ERROR | [x] Multi-line function declarations must define one
| | parameter per line
263 | ERROR | [x] Multi-line function declarations must have a
| | trailing comma after the last parameter
263 | ERROR | [x] The closing parenthesis of a multi-line function
| | declaration must be on a new line
453 | ERROR | [x] The first parameter of a multi-line function
| | declaration must be on the line after the opening
| | bracket
453 | ERROR | [x] Multi-line function declarations must define one
| | parameter per line
467 | ERROR | [x] Multi-line function declarations must have a
| | trailing comma after the last parameter
467 | ERROR | [x] The closing parenthesis of a multi-line function
| | declaration must be on a new line
551 | ERROR | [x] The first parameter of a multi-line function
| | declaration must be on the line after the opening
| | bracket
551 | ERROR | [x] Multi-line function declarations must define one
| | parameter per line
560 | ERROR | [x] Multi-line function declarations must have a
| | trailing comma after the last parameter
560 | ERROR | [x] The closing parenthesis of a multi-line function
| | declaration must be on a new line
777 | ERROR | [x] The first parameter of a multi-line function
| | declaration must be on the line after the opening
| | bracket
777 | ERROR | [x] Multi-line function declarations must define one
| | parameter per line
781 | ERROR | [x] Multi-line function declarations must have a
| | trailing comma after the last parameter
781 | ERROR | [x] The closing parenthesis of a multi-line function
| | declaration must be on a new line
----------------------------------------------------------------------
PHPCBF CAN FIX THE 20 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------

Time: 4.86 secs; Memory: 20MB

🐛 | Simple Currency Converter | After installing the module, a popup modal message appears on all pages.
Comment 4 months ago →
vishwenderbaloria

Please confirm
admin/config/regional/simplecurrencyconverter
Are you able to access this link.?

🐛 | Search API | Deprecated function: str_replace(): Passing null to parameter #3 in Highlight->createExcerpt() - php 8.1+
Comment 4 months ago →
vishwenderbaloria

Adding patch to solve the issue. Please review.

🐛 | Search API | Deprecated function: str_replace(): Passing null to parameter #3 in Highlight->createExcerpt() - php 8.1+
Comment 4 months ago →
vishwenderbaloria

vishwenderbaloria → made their first commit to this issue’s fork.

🐛 | Reroute Email | README.md code-snippet Helptext for 'mailkeys_skip' ist incorrect
Comment 7 months ago →
vishwenderbaloria

vishwenderbaloria → made their first commit to this issue’s fork.

🐛 | Taxonomy Translation Import Export | PHP 8.1: count(): Argument #1 ($value) must be of type Countable|array
Comment 8 months ago →
vishwenderbaloria

@sarwan_verma Applied patch in #3. The patch was applied cleanly. Attaching screenshot of error before the patch.
Did not get any error message after the patch was applied.

📌 | Libraries API | t() calls should be avoided in classes
Comment 8 months ago →
vishwenderbaloria

Patch was Applied Successfully.

🐛 | Barrio Bootstrap 5 Theme | Button checkboxes break ajax views auto-submit
Comment 8 months ago →
vishwenderbaloria

Checked at my end, seems to be working fine.

🐛 | Drupal core | Broken Breadcrumb on Appearance tab.
Comment over 1 year ago →
vishwenderbaloria

Checked on other version of drupal, the functionality is the same. What exactly is the requirement here ? Please clearify.

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024