- Issue created by @chaitanyadessai
- Issue was unassigned.
- Status changed to Needs review
9 months ago 3:54am 13 March 2024 - last update
9 months ago 27 pass - Status changed to RTBC
4 months ago 12:28pm 31 July 2024 - 🇵🇭Philippines cleavinjosh
Hi @chaitanyadessai,
I applied patch#2, it was applied smoothly and fixed all issues related to t() calls.
Before patch(This is only the end of the list since it was too long and all the t() calls issues can be found here)
FILE: /Users/interns/Demo-site/drupal-org-issues/web/modules/contrib/libraries/src/StreamWrapper/LocalHiddenStreamTrait.php --------------------------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE --------------------------------------------------------------------------------------------------------------------------- 15 | ERROR | Description for the @return value is missing --------------------------------------------------------------------------------------------------------------------------- FILE: /Users/interns/Demo-site/drupal-org-issues/web/modules/contrib/libraries/src/StreamWrapper/AssetLibrariesStream.php ----------------------------------------------------------------------------------------------------------------------------------------- FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES ----------------------------------------------------------------------------------------------------------------------------------------- 22 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead 29 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead ----------------------------------------------------------------------------------------------------------------------------------------- FILE: /Users/interns/Demo-site/drupal-org-issues/web/modules/contrib/libraries/src/StreamWrapper/LibraryDefinitionsStream.php --------------------------------------------------------------------------------------------------------------------------------------------- FOUND 3 ERRORS AND 2 WARNINGS AFFECTING 4 LINES --------------------------------------------------------------------------------------------------------------------------------------------- 6 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Config\ConfigFactoryInterface. 67 | WARNING | [ ] t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead 74 | WARNING | [ ] t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead 86 | ERROR | [x] There must be exactly one blank line before the tags in a doc comment 86 | ERROR | [ ] Missing parameter type --------------------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY --------------------------------------------------------------------------------------------------------------------------------------------- FILE: /Users/interns/Demo-site/drupal-org-issues/web/modules/contrib/libraries/src/StreamWrapper/PhpFileLibrariesStream.php ----------------------------------------------------------------------------------------------------------------------------------------- FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES ----------------------------------------------------------------------------------------------------------------------------------------- 22 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead 29 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead ----------------------------------------------------------------------------------------------------------------------------------------- FILE: /Users/interns/Demo-site/drupal-org-issues/web/modules/contrib/libraries/src/StreamWrapper/PrivateStreamTrait.php ----------------------------------------------------------------------------------------------------------------------- FOUND 2 ERRORS AFFECTING 2 LINES ----------------------------------------------------------------------------------------------------------------------- 20 | ERROR | [ ] Function return type is not void, but function has no return statement 25 | ERROR | [x] Visibility must be declared on method "getExternalUrl" ----------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ----------------------------------------------------------------------------------------------------------------------- Time: 1.37 secs; Memory: 14MB ➜ contribAfter patch
➜ libraries git:(4.0.x) curl https://www.drupal.org/files/issues/2024-03-13/3427504-2.patch | patch -p1 % Total % Received % Xferd Average Speed Time Time Time Current Dload Upload Total Spent Left Speed 100 3527 100 3527 0 0 5040 0 --:--:-- --:--:-- --:--:-- 5053 patching file src/StreamWrapper/AssetLibrariesStream.php patching file src/StreamWrapper/LibraryDefinitionsStream.php patching file src/StreamWrapper/PhpFileLibrariesStream.php ➜ libraries git:(4.0.x) ✗ .. ➜ contrib phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml libraries FILE: /Users/interns/Demo-site/drupal-org-issues/web/modules/contrib/libraries/config/install/libraries.settings.yml -------------------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE -------------------------------------------------------------------------------------------------------------------- 10 | ERROR | [x] Expected 1 newline at end of file; 0 found -------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY -------------------------------------------------------------------------------------------------------------------- FILE: /Users/interns/Demo-site/drupal-org-issues/web/modules/contrib/libraries/config/schema/libraries.schema.yml ----------------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ----------------------------------------------------------------------------------------------------------------- 53 | ERROR | [x] Expected 1 newline at end of file; 0 found ----------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ----------------------------------------------------------------------------------------------------------------- FILE: /Users/interns/Demo-site/drupal-org-issues/web/modules/contrib/libraries/libraries.install ------------------------------------------------------------------------------------------------ FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE ------------------------------------------------------------------------------------------------ 8 | WARNING | [x] Unused use statement ------------------------------------------------------------------------------------------------ PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ------------------------------------------------------------------------------------------------ FILE: /Users/interns/Demo-site/drupal-org-issues/web/modules/contrib/libraries/tests/example/example_4.css ---------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ---------------------------------------------------------------------------------------------------------- 1 | ERROR | [x] Additional whitespace found at start of file ---------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ---------------------------------------------------------------------------------------------------------- FILE: /Users/interns/Demo-site/drupal-org-issues/web/modules/contrib/libraries/tests/example/example_3.css ---------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ---------------------------------------------------------------------------------------------------------- 1 | ERROR | [x] Additional whitespace found at start of file ---------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ---------------------------------------------------------------------------------------------------------- FILE: /Users/interns/Demo-site/drupal-org-issues/web/modules/contrib/libraries/tests/example/example_2.css ---------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ---------------------------------------------------------------------------------------------------------- 1 | ERROR | [x] Additional whitespace found at start of file ---------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ---------------------------------------------------------------------------------------------------------- FILE: /Users/interns/Demo-site/drupal-org-issues/web/modules/contrib/libraries/tests/example/example_1.css ---------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ---------------------------------------------------------------------------------------------------------- 1 | ERROR | [x] Additional whitespace found at start of file ---------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ---------------------------------------------------------------------------------------------------------- FILE: /Users/interns/Demo-site/drupal-org-issues/web/modules/contrib/libraries/tests/modules/libraries_test/libraries_test.routing.yml -------------------------------------------------------------------------------------------------------------------------------------- FOUND 0 ERRORS AND 6 WARNINGS AFFECTING 6 LINES -------------------------------------------------------------------------------------------------------------------------------------- 6 | WARNING | Open page callback found, please add a comment before the line why there is no access restriction 12 | WARNING | Open page callback found, please add a comment before the line why there is no access restriction 18 | WARNING | Open page callback found, please add a comment before the line why there is no access restriction 24 | WARNING | Open page callback found, please add a comment before the line why there is no access restriction 30 | WARNING | Open page callback found, please add a comment before the line why there is no access restriction 36 | WARNING | Open page callback found, please add a comment before the line why there is no access restriction -------------------------------------------------------------------------------------------------------------------------------------- FILE: /Users/interns/Demo-site/drupal-org-issues/web/modules/contrib/libraries/tests/modules/libraries_test/libraries_test.module ------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- FOUND 11 ERRORS AND 2 WARNINGS AFFECTING 13 LINES ------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- 9 | WARNING | [x] Unused use statement 52 | ERROR | [x] Inline comments must end in full-stops, exclamation marks, question marks, colons, or closing parentheses 62 | ERROR | [x] Inline comments must end in full-stops, exclamation marks, question marks, colons, or closing parentheses 292 | WARNING | [ ] Format should be "* Implements hook_foo().", "* Implements hook_foo_BAR_ID_bar() for xyz_bar().",, "* Implements hook_foo_BAR_ID_bar() for xyz-bar.html.twig.", | | "* Implements hook_foo_BAR_ID_bar() for xyz-bar.tpl.php.", or "* Implements hook_foo_BAR_ID_bar() for block templates." 320 | ERROR | [ ] Missing parameter type 322 | ERROR | [ ] Missing parameter type 325 | ERROR | [ ] Missing parameter name 328 | ERROR | [ ] Missing parameter name 331 | ERROR | [ ] Missing parameter name 336 | ERROR | [ ] Return type missing for @return tag in function comment 435 | ERROR | [ ] Missing parameter type 438 | ERROR | [ ] Missing parameter type 441 | ERROR | [ ] Missing parameter type ------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 3 MARKED SNIFF VIOLATIONS AUTOMATICALLY ------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- FILE: /Users/interns/Demo-site/drupal-org-issues/web/modules/contrib/libraries/tests/modules/libraries_test/libraries_test.css ------------------------------------------------------------------------------------------------------------------------------ FOUND 1 ERROR AFFECTING 1 LINE ------------------------------------------------------------------------------------------------------------------------------ 1 | ERROR | [x] Additional whitespace found at start of file ------------------------------------------------------------------------------------------------------------------------------ PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ------------------------------------------------------------------------------------------------------------------------------ FILE: /Users/interns/Demo-site/drupal-org-issues/web/modules/contrib/libraries/tests/modules/libraries_test/src/Controller/ExampleController.php ------------------------------------------------------------------------------------------------------------------------------------------------ FOUND 7 ERRORS AND 5 WARNINGS AFFECTING 12 LINES ------------------------------------------------------------------------------------------------------------------------------------------------ 8 | ERROR | [x] Missing class doc comment 21 | WARNING | [ ] Line exceeds 80 characters; contains 82 characters 26 | WARNING | [ ] \Drupal calls should be avoided in classes, use dependency injection instead 27 | WARNING | [ ] Line exceeds 80 characters; contains 81 characters 31 | WARNING | [ ] Line exceeds 80 characters; contains 82 characters 44 | WARNING | [ ] Line exceeds 80 characters; contains 82 characters 70 | ERROR | [x] Missing function doc comment 74 | ERROR | [x] Missing function doc comment 78 | ERROR | [x] Missing function doc comment 82 | ERROR | [x] Missing function doc comment 86 | ERROR | [x] Missing function doc comment 90 | ERROR | [x] Missing function doc comment ------------------------------------------------------------------------------------------------------------------------------------------------ PHPCBF CAN FIX THE 7 MARKED SNIFF VIOLATIONS AUTOMATICALLY ------------------------------------------------------------------------------------------------------------------------------------------------ FILE: /Users/interns/Demo-site/drupal-org-issues/web/modules/contrib/libraries/tests/assets/vendor/test_asset_multiple_library/example.second.css ------------------------------------------------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ------------------------------------------------------------------------------------------------------------------------------------------------- 1 | ERROR | [x] Expected 1 newline at end of file; 0 found ------------------------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ------------------------------------------------------------------------------------------------------------------------------------------------- FILE: /Users/interns/Demo-site/drupal-org-issues/web/modules/contrib/libraries/tests/assets/vendor/test_asset_multiple_library/example.first.css ------------------------------------------------------------------------------------------------------------------------------------------------ FOUND 1 ERROR AFFECTING 1 LINE ------------------------------------------------------------------------------------------------------------------------------------------------ 1 | ERROR | [x] Expected 1 newline at end of file; 0 found ------------------------------------------------------------------------------------------------------------------------------------------------ PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ------------------------------------------------------------------------------------------------------------------------------------------------ FILE: /Users/interns/Demo-site/drupal-org-issues/web/modules/contrib/libraries/tests/assets/vendor/test_asset_library/example.css --------------------------------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE --------------------------------------------------------------------------------------------------------------------------------- 1 | ERROR | [x] Expected 1 newline at end of file; 0 found --------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY --------------------------------------------------------------------------------------------------------------------------------- FILE: /Users/interns/Demo-site/drupal-org-issues/web/modules/contrib/libraries/tests/src/Unit/Plugin/libraries/VersionDetector/LinePatternDetectorTest.php ---------------------------------------------------------------------------------------------------------------------------------------------------------- FOUND 15 ERRORS AND 2 WARNINGS AFFECTING 13 LINES ---------------------------------------------------------------------------------------------------------------------------------------------------------- 6 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\libraries\ExternalLibrary\Local\LocalLibraryInterface. 23 | ERROR | [ ] Missing member variable doc comment 67 | ERROR | [ ] Missing short description in doc comment 68 | ERROR | [ ] Description for the @return value is missing 75 | WARNING | [x] A comma should follow the last multiline array item. Found: '/@version (\d+\.\d+\.\d+)/' 127 | ERROR | [ ] Missing short description in doc comment 128 | ERROR | [ ] Description for the @return value is missing 135 | WARNING | [x] A comma should follow the last multiline array item. Found: '/@version (\d+\.\d+\.\d+)/' 144 | ERROR | [x] Array indentation error, expected 6 spaces but found 4 144 | ERROR | [x] Expected 0 spaces before comma; 4 found 144 | ERROR | [x] Closing parenthesis of array declaration must be on a new line 152 | ERROR | [ ] Description for the @return value is missing 184 | ERROR | [ ] Missing short description in doc comment 185 | ERROR | [ ] Missing parameter comment 185 | ERROR | [ ] Missing parameter type 186 | ERROR | [ ] Missing parameter comment 186 | ERROR | [ ] Missing parameter type ---------------------------------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 6 MARKED SNIFF VIOLATIONS AUTOMATICALLY ---------------------------------------------------------------------------------------------------------------------------------------------------------- FILE: /Users/interns/Demo-site/drupal-org-issues/web/modules/contrib/libraries/tests/src/Functional/ExternalLibrary/Definition/DefinitionDiscoveryFactoryTest.php ----------------------------------------------------------------------------------------------------------------------------------------------------------------- FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE ----------------------------------------------------------------------------------------------------------------------------------------------------------------- 71 | WARNING | [x] A comma should follow the last multiline array item. Found: '1.0.0' ----------------------------------------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ----------------------------------------------------------------------------------------------------------------------------------------------------------------- FILE: /Users/interns/Demo-site/drupal-org-issues/web/modules/contrib/libraries/tests/src/Kernel/LibraryTypeKernelTestBase.php --------------------------------------------------------------------------------------------------------------------------------------------- FOUND 3 ERRORS AFFECTING 3 LINES --------------------------------------------------------------------------------------------------------------------------------------------- 6 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Component\Plugin\Exception\PluginException. 48 | ERROR | [ ] Description for the @return value is missing 142 | ERROR | [ ] Description for the @return value is missing --------------------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY --------------------------------------------------------------------------------------------------------------------------------------------- FILE: /Users/interns/Demo-site/drupal-org-issues/web/modules/contrib/libraries/tests/src/Kernel/ExternalLibrary/Asset/MultipleAssetLibraryTest.php -------------------------------------------------------------------------------------------------------------------------------------------------- FOUND 8 ERRORS AND 4 WARNINGS AFFECTING 12 LINES -------------------------------------------------------------------------------------------------------------------------------------------------- 66 | ERROR | [x] Closing parenthesis of array declaration must be on a new line 72 | ERROR | [x] Closing parenthesis of array declaration must be on a new line 78 | WARNING | [x] A comma should follow the last multiline array item. Found: ] 91 | ERROR | [x] Closing parenthesis of array declaration must be on a new line 97 | ERROR | [x] Closing parenthesis of array declaration must be on a new line 103 | WARNING | [x] A comma should follow the last multiline array item. Found: ] 128 | ERROR | [x] Closing parenthesis of array declaration must be on a new line 135 | ERROR | [x] Closing parenthesis of array declaration must be on a new line 141 | WARNING | [x] A comma should follow the last multiline array item. Found: ] 154 | ERROR | [x] Closing parenthesis of array declaration must be on a new line 161 | ERROR | [x] Closing parenthesis of array declaration must be on a new line 167 | WARNING | [x] A comma should follow the last multiline array item. Found: ] -------------------------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 12 MARKED SNIFF VIOLATIONS AUTOMATICALLY -------------------------------------------------------------------------------------------------------------------------------------------------- FILE: /Users/interns/Demo-site/drupal-org-issues/web/modules/contrib/libraries/tests/src/Kernel/ExternalLibrary/Asset/AssetLibraryTest.php ------------------------------------------------------------------------------------------------------------------------------------------ FOUND 4 ERRORS AND 2 WARNINGS AFFECTING 6 LINES ------------------------------------------------------------------------------------------------------------------------------------------ 60 | ERROR | [x] Closing parenthesis of array declaration must be on a new line 66 | ERROR | [x] Closing parenthesis of array declaration must be on a new line 72 | WARNING | [x] A comma should follow the last multiline array item. Found: ] 96 | ERROR | [x] Closing parenthesis of array declaration must be on a new line 103 | ERROR | [x] Closing parenthesis of array declaration must be on a new line 109 | WARNING | [x] A comma should follow the last multiline array item. Found: ] ------------------------------------------------------------------------------------------------------------------------------------------ PHPCBF CAN FIX THE 6 MARKED SNIFF VIOLATIONS AUTOMATICALLY ------------------------------------------------------------------------------------------------------------------------------------------ FILE: /Users/interns/Demo-site/drupal-org-issues/web/modules/contrib/libraries/tests/src/Kernel/ExternalLibrary/GlobalLocatorTest.php ------------------------------------------------------------------------------------------------------------------------------------- FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE ------------------------------------------------------------------------------------------------------------------------------------- 5 | WARNING | [x] Unused use statement ------------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ------------------------------------------------------------------------------------------------------------------------------------- FILE: /Users/interns/Demo-site/drupal-org-issues/web/modules/contrib/libraries/tests/src/Kernel/LibrariesApi/LibrariesUnitTest.php ---------------------------------------------------------------------------------------------------------------------------------- FOUND 2 ERRORS AFFECTING 2 LINES ---------------------------------------------------------------------------------------------------------------------------------- 22 | ERROR | [x] Visibility must be declared on method "testLibrariesGetPath" 34 | ERROR | [x] Visibility must be declared on method "testLibrariesPrepareFiles" ---------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY ---------------------------------------------------------------------------------------------------------------------------------- FILE: /Users/interns/Demo-site/drupal-org-issues/web/modules/contrib/libraries/README.md ---------------------------------------------------------------------------------------- FOUND 1 ERROR AND 1 WARNING AFFECTING 2 LINES ---------------------------------------------------------------------------------------- 17 | WARNING | [ ] Line exceeds 80 characters; contains 81 characters 39 | ERROR | [x] Expected 1 newline at end of file; 2 found ---------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ---------------------------------------------------------------------------------------- FILE: /Users/interns/Demo-site/drupal-org-issues/web/modules/contrib/libraries/libraries.drush.inc -------------------------------------------------------------------------------------------------- FOUND 8 ERRORS AND 29 WARNINGS AFFECTING 36 LINES -------------------------------------------------------------------------------------------------- 20 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 21 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 6 22 | WARNING | [ ] Line exceeds 80 characters; contains 110 characters 22 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 6 23 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 6 24 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 8 25 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 6 26 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 27 | ERROR | [x] Line indented incorrectly; expected 3 spaces, found 2 121 | WARNING | [ ] Code after the RETURN statement on line 118 cannot be executed 122 | WARNING | [ ] Code after the RETURN statement on line 118 cannot be executed 126 | WARNING | [ ] Code after the RETURN statement on line 118 cannot be executed 127 | WARNING | [ ] Code after the RETURN statement on line 118 cannot be executed 128 | WARNING | [ ] Code after the RETURN statement on line 118 cannot be executed 130 | WARNING | [ ] Code after the RETURN statement on line 118 cannot be executed 131 | WARNING | [ ] Code after the RETURN statement on line 118 cannot be executed 135 | WARNING | [ ] Code after the RETURN statement on line 118 cannot be executed 136 | WARNING | [ ] Code after the RETURN statement on line 118 cannot be executed 137 | WARNING | [ ] Code after the RETURN statement on line 118 cannot be executed 141 | WARNING | [ ] Code after the RETURN statement on line 118 cannot be executed 142 | WARNING | [ ] Code after the RETURN statement on line 118 cannot be executed 144 | WARNING | [ ] Code after the RETURN statement on line 118 cannot be executed 145 | WARNING | [ ] Code after the RETURN statement on line 118 cannot be executed 148 | WARNING | [ ] Code after the RETURN statement on line 118 cannot be executed 149 | WARNING | [ ] Code after the RETURN statement on line 118 cannot be executed 152 | WARNING | [ ] Code after the RETURN statement on line 118 cannot be executed 153 | WARNING | [ ] Code after the RETURN statement on line 118 cannot be executed 157 | WARNING | [ ] Code after the RETURN statement on line 118 cannot be executed 158 | WARNING | [ ] Code after the RETURN statement on line 118 cannot be executed 161 | WARNING | [ ] Code after the RETURN statement on line 118 cannot be executed 163 | WARNING | [ ] Code after the RETURN statement on line 118 cannot be executed 165 | WARNING | [ ] Code after the RETURN statement on line 118 cannot be executed 169 | WARNING | [ ] Code after the RETURN statement on line 118 cannot be executed 171 | WARNING | [ ] Code after the RETURN statement on line 118 cannot be executed 172 | WARNING | [ ] Code after the RETURN statement on line 118 cannot be executed 174 | WARNING | [ ] Code after the RETURN statement on line 118 cannot be executed 175 | WARNING | [ ] Code after the RETURN statement on line 118 cannot be executed -------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 8 MARKED SNIFF VIOLATIONS AUTOMATICALLY -------------------------------------------------------------------------------------------------- FILE: /Users/interns/Demo-site/drupal-org-issues/web/modules/contrib/libraries/libraries.api.php ------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- FOUND 11 ERRORS AND 4 WARNINGS AFFECTING 11 LINES ------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- 171 | ERROR | [ ] Return type missing for @return tag in function comment 233 | ERROR | [ ] Long array syntax must not be used in doc comment code annotations 263 | WARNING | [ ] Line exceeds 80 characters; contains 81 characters 311 | WARNING | [ ] Line exceeds 80 characters; contains 82 characters 336 | ERROR | [ ] The text '@deprecated Will be removed before a stable Drupal 8 release.' does not match the standard format: @deprecated in %deprecation-version% and is | | removed from %removal-version%. %extra-info%. 336 | ERROR | [ ] Each @deprecated tag must have a @see tag immediately following it 340 | WARNING | [x] There must be no blank line following an inline comment 340 | WARNING | [ ] There must be no blank line following an inline comment 480 | ERROR | [x] Inline comments must end in full-stops, exclamation marks, question marks, colons, or closing parentheses 505 | ERROR | [x] Inline comments must end in full-stops, exclamation marks, question marks, colons, or closing parentheses 577 | ERROR | [ ] The text '@deprecated Will be removed before a stable Drupal 8 release.' does not match the standard format: @deprecated in %deprecation-version% and is | | removed from %removal-version%. %extra-info%. 577 | ERROR | [ ] Each @deprecated tag must have a @see tag immediately following it 600 | ERROR | [ ] Return type missing for @return tag in function comment 603 | ERROR | [ ] The text '@deprecated Will be removed before a stable Drupal 8 release.' does not match the standard format: @deprecated in %deprecation-version% and is | | removed from %removal-version%. %extra-info%. 603 | ERROR | [ ] Each @deprecated tag must have a @see tag immediately following it ------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 3 MARKED SNIFF VIOLATIONS AUTOMATICALLY ------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- FILE: /Users/interns/Demo-site/drupal-org-issues/web/modules/contrib/libraries/libraries.module ------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- FOUND 57 ERRORS AND 18 WARNINGS AFFECTING 61 LINES ------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- 9 | WARNING | [x] Unused use statement 14 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Extension\Dependency. 58 | ERROR | [ ] Missing parameter type 60 | ERROR | [ ] Missing parameter type 63 | ERROR | [ ] Return type missing for @return tag in function comment 68 | ERROR | [ ] The text '@deprecated Will be removed before a stable Drupal 8 release. Please use the new library load and managment concepts described at: | | https://www.drupal.org/node/2170763' does not match the standard format: @deprecated in %deprecation-version% and is removed from %removal-version%. | | %extra-info%. 68 | ERROR | [ ] Each @deprecated tag must have a @see tag immediately following it 101 | ERROR | [ ] Return type missing for @return tag in function comment 106 | ERROR | [ ] The text '@deprecated Will be removed before a stable Drupal 8 release. Please use the new library load and managment concepts described at: | | https://www.drupal.org/node/2170763' does not match the standard format: @deprecated in %deprecation-version% and is removed from %removal-version%. | | %extra-info%. 106 | ERROR | [ ] Each @deprecated tag must have a @see tag immediately following it 114 | WARNING | [x] There must be no blank line following an inline comment 114 | WARNING | [ ] There must be no blank line following an inline comment 162 | ERROR | [ ] Return type missing for @return tag in function comment 166 | ERROR | [ ] The text '@deprecated Will be removed before a stable Drupal 8 release. Please use the new library load and managment concepts described at: | | https://www.drupal.org/node/2170763' does not match the standard format: @deprecated in %deprecation-version% and is removed from %removal-version%. | | %extra-info%. 166 | ERROR | [ ] Each @deprecated tag must have a @see tag immediately following it 203 | ERROR | [ ] Missing parameter type 206 | ERROR | [ ] Missing parameter type 209 | ERROR | [ ] The text '@deprecated Will be removed before a stable Drupal 8 release. Please use the new library load and managment concepts described at: | | https://www.drupal.org/node/2170763' does not match the standard format: @deprecated in %deprecation-version% and is removed from %removal-version%. | | %extra-info%. 209 | ERROR | [ ] Each @deprecated tag must have a @see tag immediately following it 227 | ERROR | [ ] Missing parameter type 229 | ERROR | [ ] Missing parameter type 232 | ERROR | [ ] The text '@deprecated Will be removed before a stable Drupal 8 release. Please use the new library load and managment concepts described at: | | https://www.drupal.org/node/2170763' does not match the standard format: @deprecated in %deprecation-version% and is removed from %removal-version%. | | %extra-info%. 232 | ERROR | [ ] Each @deprecated tag must have a @see tag immediately following it 266 | ERROR | [ ] Long array syntax must not be used in doc comment code annotations 270 | ERROR | [ ] Long array syntax must not be used in doc comment code annotations 271 | ERROR | [ ] Long array syntax must not be used in doc comment code annotations 272 | ERROR | [ ] Long array syntax must not be used in doc comment code annotations 277 | ERROR | [ ] Missing parameter type 280 | ERROR | [ ] Missing parameter type 283 | ERROR | [ ] Missing parameter type 290 | ERROR | [ ] The text '@deprecated Will be removed before a stable Drupal 8 release. Please use the new library load and managment concepts described at: | | https://www.drupal.org/node/2170763' does not match the standard format: @deprecated in %deprecation-version% and is removed from %removal-version%. | | %extra-info%. 290 | ERROR | [ ] Each @deprecated tag must have a @see tag immediately following it 329 | ERROR | [ ] Missing parameter type 332 | ERROR | [ ] Missing parameter type 335 | ERROR | [ ] Missing parameter type 342 | ERROR | [ ] The text '@deprecated Will be removed before a stable Drupal 8 release. Please use the new library load and managment concepts described at: | | https://www.drupal.org/node/2170763' does not match the standard format: @deprecated in %deprecation-version% and is removed from %removal-version%. | | %extra-info%. 342 | ERROR | [ ] Each @deprecated tag must have a @see tag immediately following it 381 | ERROR | [ ] Missing parameter type 395 | ERROR | [ ] The text '@deprecated Will be removed before a stable Drupal 8 release. Please use the new library load and managment concepts described at: | | https://www.drupal.org/node/2170763' does not match the standard format: @deprecated in %deprecation-version% and is removed from %removal-version%. | | %extra-info%. 395 | ERROR | [ ] Each @deprecated tag must have a @see tag immediately following it 487 | ERROR | [ ] The text '@deprecated Will be removed before a stable Drupal 8 release. Please use the new library load and managment concepts described at: | | https://www.drupal.org/node/2170763' does not match the standard format: @deprecated in %deprecation-version% and is removed from %removal-version%. | | %extra-info%. 487 | ERROR | [ ] Each @deprecated tag must have a @see tag immediately following it 526 | ERROR | [ ] Missing parameter type 545 | ERROR | [ ] The text '@deprecated Will be removed before a stable Drupal 8 release. Please use the new library load and managment concepts described at: | | https://www.drupal.org/node/2170763' does not match the standard format: @deprecated in %deprecation-version% and is removed from %removal-version%. | | %extra-info%. 545 | ERROR | [ ] Each @deprecated tag must have a @see tag immediately following it 635 | ERROR | [ ] The array declaration extends to column 122 (the limit is 120). The array content should be split up over multiple lines 663 | ERROR | [ ] Missing parameter type 665 | ERROR | [ ] Missing parameter type 670 | ERROR | [ ] Return type missing for @return tag in function comment 680 | ERROR | [ ] The text '@deprecated Will be removed before a stable Drupal 8 release. Please use the new library load and managment concepts described at: | | https://www.drupal.org/node/2170763' does not match the standard format: @deprecated in %deprecation-version% and is removed from %removal-version%. | | %extra-info%. 680 | ERROR | [ ] Each @deprecated tag must have a @see tag immediately following it 737 | ERROR | [ ] Missing parameter type 740 | ERROR | [ ] Return type missing for @return tag in function comment 743 | ERROR | [ ] The text '@deprecated Will be removed before a stable Drupal 8 release. Please use the new library load and managment concepts described at: | | https://www.drupal.org/node/2170763' does not match the standard format: @deprecated in %deprecation-version% and is removed from %removal-version%. | | %extra-info%. 743 | ERROR | [ ] Each @deprecated tag must have a @see tag immediately following it 765 | WARNING | [ ] Code after the BREAK statement on line 764 cannot be executed 766 | WARNING | [ ] Code after the BREAK statement on line 764 cannot be executed 769 | WARNING | [ ] Code after the BREAK statement on line 764 cannot be executed 770 | WARNING | [ ] Code after the BREAK statement on line 764 cannot be executed 771 | WARNING | [ ] Code after the BREAK statement on line 764 cannot be executed 776 | WARNING | [ ] Code after the BREAK statement on line 764 cannot be executed 777 | WARNING | [ ] Code after the BREAK statement on line 764 cannot be executed 778 | WARNING | [ ] Code after the BREAK statement on line 764 cannot be executed 781 | WARNING | [ ] Code after the BREAK statement on line 764 cannot be executed 783 | WARNING | [ ] Code after the BREAK statement on line 764 cannot be executed 784 | WARNING | [ ] Code after the BREAK statement on line 764 cannot be executed 786 | WARNING | [ ] Code after the BREAK statement on line 764 cannot be executed 787 | WARNING | [ ] Code after the BREAK statement on line 764 cannot be executed 790 | WARNING | [ ] Code after the BREAK statement on line 764 cannot be executed 791 | WARNING | [ ] Code after the BREAK statement on line 764 cannot be executed 824 | ERROR | [ ] Missing parameter type 826 | ERROR | [ ] Missing parameter type 841 | ERROR | [ ] Return type missing for @return tag in function comment 846 | ERROR | [ ] The text '@deprecated Will be removed before a stable Drupal 8 release. Please use the new library load and managment concepts described at: | | https://www.drupal.org/node/2170763' does not match the standard format: @deprecated in %deprecation-version% and is removed from %removal-version%. | | %extra-info%. 846 | ERROR | [ ] Each @deprecated tag must have a @see tag immediately following it ------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 3 MARKED SNIFF VIOLATIONS AUTOMATICALLY ------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- FILE: /Users/interns/Demo-site/drupal-org-issues/web/modules/contrib/libraries/src/ExternalLibrary/Asset/LocalRemoteAssetTrait.php ---------------------------------------------------------------------------------------------------------------------------------- FOUND 3 ERRORS AFFECTING 3 LINES ---------------------------------------------------------------------------------------------------------------------------------- 47 | ERROR | Inline doc block comments are not allowed; use "/* Comment */" or "// Comment" instead 63 | ERROR | Missing parameter comment 91 | ERROR | Missing parameter comment ---------------------------------------------------------------------------------------------------------------------------------- FILE: /Users/interns/Demo-site/drupal-org-issues/web/modules/contrib/libraries/src/ExternalLibrary/Asset/MultipleAssetLibraryInterface.php ------------------------------------------------------------------------------------------------------------------------------------------ FOUND 1 ERROR AFFECTING 1 LINE ------------------------------------------------------------------------------------------------------------------------------------------ 53 | ERROR | Description for the @return value is missing ------------------------------------------------------------------------------------------------------------------------------------------ FILE: /Users/interns/Demo-site/drupal-org-issues/web/modules/contrib/libraries/src/ExternalLibrary/Asset/AttachableAssetLibraryRegistrationInterface.php -------------------------------------------------------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE -------------------------------------------------------------------------------------------------------------------------------------------------------- 18 | ERROR | Missing parameter comment -------------------------------------------------------------------------------------------------------------------------------------------------------- FILE: /Users/interns/Demo-site/drupal-org-issues/web/modules/contrib/libraries/src/ExternalLibrary/Asset/AssetLibrary.php -------------------------------------------------------------------------------------------------------------------------- FOUND 6 ERRORS AFFECTING 6 LINES -------------------------------------------------------------------------------------------------------------------------- 22 | ERROR | [x] Opening brace should be on the same line as the declaration 28 | ERROR | [x] Space found before semicolon; expected "LocalRemoteAssetTrait;" but found "LocalRemoteAssetTrait\n ;" 48 | ERROR | [ ] Missing @var tag in member variable comment 88 | ERROR | [ ] Description for the @return value is missing 114 | ERROR | [ ] Missing parameter comment 116 | ERROR | [ ] Description for the @return value is missing -------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY -------------------------------------------------------------------------------------------------------------------------- FILE: /Users/interns/Demo-site/drupal-org-issues/web/modules/contrib/libraries/src/ExternalLibrary/Asset/MultipleAssetLibrary.php --------------------------------------------------------------------------------------------------------------------------------- FOUND 6 ERRORS AFFECTING 6 LINES --------------------------------------------------------------------------------------------------------------------------------- 26 | ERROR | [x] Opening brace should be on the same line as the declaration 32 | ERROR | [x] Space found before semicolon; expected "LocalRemoteAssetTrait;" but found "LocalRemoteAssetTrait\n ;" 36 | ERROR | [ ] Missing @var tag in member variable comment 79 | ERROR | [ ] Description for the @return value is missing 109 | ERROR | [ ] Missing parameter comment 111 | ERROR | [ ] Description for the @return value is missing --------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY --------------------------------------------------------------------------------------------------------------------------------- FILE: /Users/interns/Demo-site/drupal-org-issues/web/modules/contrib/libraries/src/ExternalLibrary/Asset/AssetLibraryInterface.php ---------------------------------------------------------------------------------------------------------------------------------- FOUND 2 ERRORS AFFECTING 2 LINES ---------------------------------------------------------------------------------------------------------------------------------- 46 | ERROR | [x] Opening brace should be on the same line as the declaration 54 | ERROR | [ ] Description for the @return value is missing ---------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ---------------------------------------------------------------------------------------------------------------------------------- FILE: /Users/interns/Demo-site/drupal-org-issues/web/modules/contrib/libraries/src/ExternalLibrary/LibraryManager.php ---------------------------------------------------------------------------------------------------------------------------------------------------------------------- FOUND 12 ERRORS AND 1 WARNING AFFECTING 11 LINES ---------------------------------------------------------------------------------------------------------------------------------------------------------------------- 9 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\libraries\ExternalLibrary\Definition\DefinitionDiscoveryInterface. 44 | ERROR | [x] Multi-line function declarations must have a trailing comma after the last parameter 65 | WARNING | [ ] \Drupal calls should be avoided in classes, use dependency injection instead 87 | ERROR | [ ] Missing short description in doc comment 88 | ERROR | [ ] Missing parameter comment 88 | ERROR | [ ] Missing parameter type 89 | ERROR | [ ] Missing parameter comment 89 | ERROR | [ ] Missing parameter type 90 | ERROR | [ ] Description for the @return value is missing 108 | ERROR | [ ] Missing short description in doc comment 109 | ERROR | [ ] Missing parameter comment 110 | ERROR | [ ] Missing parameter comment 112 | ERROR | [ ] Description for the @return value is missing ---------------------------------------------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY ---------------------------------------------------------------------------------------------------------------------------------------------------------------------- FILE: /Users/interns/Demo-site/drupal-org-issues/web/modules/contrib/libraries/src/ExternalLibrary/Dependency/DependentLibraryTrait.php --------------------------------------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE --------------------------------------------------------------------------------------------------------------------------------------- 14 | ERROR | Missing @var tag in member variable comment --------------------------------------------------------------------------------------------------------------------------------------- FILE: /Users/interns/Demo-site/drupal-org-issues/web/modules/contrib/libraries/src/ExternalLibrary/Local/LocalLibraryTrait.php ------------------------------------------------------------------------------------------------------------------------------ FOUND 2 ERRORS AFFECTING 2 LINES ------------------------------------------------------------------------------------------------------------------------------ 3 | ERROR | [x] There must be one blank line after the namespace declaration 12 | ERROR | [x] Doc comment long description must end with a full stop ------------------------------------------------------------------------------------------------------------------------------ PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY ------------------------------------------------------------------------------------------------------------------------------ FILE: /Users/interns/Demo-site/drupal-org-issues/web/modules/contrib/libraries/src/ExternalLibrary/Local/LocalLibraryInterface.php ---------------------------------------------------------------------------------------------------------------------------------- FOUND 2 ERRORS AFFECTING 2 LINES ---------------------------------------------------------------------------------------------------------------------------------- 74 | ERROR | Missing parameter comment 76 | ERROR | Description for the @return value is missing ---------------------------------------------------------------------------------------------------------------------------------- FILE: /Users/interns/Demo-site/drupal-org-issues/web/modules/contrib/libraries/src/ExternalLibrary/Type/LibraryTypeBase.php --------------------------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE --------------------------------------------------------------------------------------------------------------------------- 20 | ERROR | [x] Opening brace should be on the same line as the declaration --------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY --------------------------------------------------------------------------------------------------------------------------- FILE: /Users/interns/Demo-site/drupal-org-issues/web/modules/contrib/libraries/src/ExternalLibrary/Version/VersionedLibraryTrait.php ------------------------------------------------------------------------------------------------------------------------------------ FOUND 2 ERRORS AFFECTING 2 LINES ------------------------------------------------------------------------------------------------------------------------------------ 75 | ERROR | Missing parameter comment 77 | ERROR | Description for the @return value is missing ------------------------------------------------------------------------------------------------------------------------------------ FILE: /Users/interns/Demo-site/drupal-org-issues/web/modules/contrib/libraries/src/ExternalLibrary/Version/VersionedLibraryInterface.php ---------------------------------------------------------------------------------------------------------------------------------------- FOUND 2 ERRORS AFFECTING 2 LINES ---------------------------------------------------------------------------------------------------------------------------------------- 57 | ERROR | Missing parameter comment 59 | ERROR | Description for the @return value is missing ---------------------------------------------------------------------------------------------------------------------------------------- FILE: /Users/interns/Demo-site/drupal-org-issues/web/modules/contrib/libraries/src/ExternalLibrary/Definition/FileDefinitionDiscoveryBase.php --------------------------------------------------------------------------------------------------------------------------------------------- FOUND 2 ERRORS AFFECTING 2 LINES --------------------------------------------------------------------------------------------------------------------------------------------- 58 | ERROR | Missing parameter type 71 | ERROR | Missing parameter type --------------------------------------------------------------------------------------------------------------------------------------------- FILE: /Users/interns/Demo-site/drupal-org-issues/web/modules/contrib/libraries/src/ExternalLibrary/Definition/DefinitionDiscoveryFactory.php -------------------------------------------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE -------------------------------------------------------------------------------------------------------------------------------------------- 48 | ERROR | [x] Multi-line function declarations must have a trailing comma after the last parameter -------------------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY -------------------------------------------------------------------------------------------------------------------------------------------- FILE: /Users/interns/Demo-site/drupal-org-issues/web/modules/contrib/libraries/src/ExternalLibrary/Definition/FileDefinitionDiscovery.php ----------------------------------------------------------------------------------------------------------------------------------------- FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES ----------------------------------------------------------------------------------------------------------------------------------------- 5 | WARNING | [x] Unused use statement 6 | WARNING | [x] Unused use statement ----------------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY ----------------------------------------------------------------------------------------------------------------------------------------- FILE: /Users/interns/Demo-site/drupal-org-issues/web/modules/contrib/libraries/src/ExternalLibrary/LibraryBase.php ------------------------------------------------------------------------------------------------------------------------- FOUND 2 ERRORS AFFECTING 2 LINES ------------------------------------------------------------------------------------------------------------------------- 19 | ERROR | [x] Opening brace should be on the same line as the declaration 25 | ERROR | [x] Space found before semicolon; expected "VersionedLibraryTrait;" but found "VersionedLibraryTrait\n ;" ------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY ------------------------------------------------------------------------------------------------------------------------- FILE: /Users/interns/Demo-site/drupal-org-issues/web/modules/contrib/libraries/src/ExternalLibrary/Exception/LibraryTypeNotFoundException.php -------------------------------------------------------------------------------------------------------------------------------------------------------------- FOUND 2 ERRORS AFFECTING 2 LINES -------------------------------------------------------------------------------------------------------------------------------------------------------------- 6 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\libraries\ExternalLibrary\Utility\LibraryIdAccessorInterface. 31 | ERROR | [x] Multi-line function declarations must have a trailing comma after the last parameter -------------------------------------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY -------------------------------------------------------------------------------------------------------------------------------------------------------------- FILE: /Users/interns/Demo-site/drupal-org-issues/web/modules/contrib/libraries/src/ExternalLibrary/Exception/LibraryNotInstalledException.php ------------------------------------------------------------------------------------------------------------------------------------------------------------ FOUND 2 ERRORS AFFECTING 2 LINES ------------------------------------------------------------------------------------------------------------------------------------------------------------ 7 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\libraries\ExternalLibrary\Utility\LibraryAccessorInterface. 32 | ERROR | [x] Multi-line function declarations must have a trailing comma after the last parameter ------------------------------------------------------------------------------------------------------------------------------------------------------------ PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY ------------------------------------------------------------------------------------------------------------------------------------------------------------ FILE: /Users/interns/Demo-site/drupal-org-issues/web/modules/contrib/libraries/src/ExternalLibrary/Exception/InvalidLibraryDependencyException.php -------------------------------------------------------------------------------------------------------------------------------------------------- FOUND 2 ERRORS AFFECTING 2 LINES -------------------------------------------------------------------------------------------------------------------------------------------------- 6 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\libraries\ExternalLibrary\LibraryInterface. 39 | ERROR | [x] Multi-line function declarations must have a trailing comma after the last parameter -------------------------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY -------------------------------------------------------------------------------------------------------------------------------------------------- FILE: /Users/interns/Demo-site/drupal-org-issues/web/modules/contrib/libraries/src/ExternalLibrary/Exception/UnknownLibraryVersionException.php ------------------------------------------------------------------------------------------------------------------------------------------------------------ FOUND 2 ERRORS AFFECTING 2 LINES ------------------------------------------------------------------------------------------------------------------------------------------------------------ 6 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\libraries\ExternalLibrary\Utility\LibraryAccessorInterface. 32 | ERROR | [x] Multi-line function declarations must have a trailing comma after the last parameter ------------------------------------------------------------------------------------------------------------------------------------------------------------ PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY ------------------------------------------------------------------------------------------------------------------------------------------------------------ FILE: /Users/interns/Demo-site/drupal-org-issues/web/modules/contrib/libraries/src/ExternalLibrary/Exception/LibraryDefinitionNotFoundException.php -------------------------------------------------------------------------------------------------------------------------------------------------------------- FOUND 2 ERRORS AFFECTING 2 LINES -------------------------------------------------------------------------------------------------------------------------------------------------------------- 6 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\libraries\ExternalLibrary\Utility\LibraryIdAccessorInterface. 31 | ERROR | [x] Multi-line function declarations must have a trailing comma after the last parameter -------------------------------------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY -------------------------------------------------------------------------------------------------------------------------------------------------------------- FILE: /Users/interns/Demo-site/drupal-org-issues/web/modules/contrib/libraries/src/ExternalLibrary/Remote/RemoteLibraryTrait.php -------------------------------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE -------------------------------------------------------------------------------------------------------------------------------- 38 | ERROR | [x] Return comment indentation must be 3 spaces, found 1 spaces -------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY -------------------------------------------------------------------------------------------------------------------------------- FILE: /Users/interns/Demo-site/drupal-org-issues/web/modules/contrib/libraries/src/Plugin/MissingPluginConfigurationException.php --------------------------------------------------------------------------------------------------------------------------------- FOUND 3 ERRORS AFFECTING 3 LINES --------------------------------------------------------------------------------------------------------------------------------- 24 | ERROR | [ ] Missing parameter type 28 | ERROR | [ ] Missing parameter type 44 | ERROR | [x] Multi-line function declarations must have a trailing comma after the last parameter --------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY --------------------------------------------------------------------------------------------------------------------------------- FILE: /Users/interns/Demo-site/drupal-org-issues/web/modules/contrib/libraries/src/Plugin/libraries/Locator/GlobalLocator.php ----------------------------------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ----------------------------------------------------------------------------------------------------------------------------------- 6 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Config\ConfigFactoryInterface. ----------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ----------------------------------------------------------------------------------------------------------------------------------- FILE: /Users/interns/Demo-site/drupal-org-issues/web/modules/contrib/libraries/src/Plugin/libraries/Locator/UriLocator.php ----------------------------------------------------------------------------------------------------------------------------------------------- FOUND 2 ERRORS AND 1 WARNING AFFECTING 2 LINES ----------------------------------------------------------------------------------------------------------------------------------------------- 6 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Plugin\ContainerFactoryPluginInterface. 81 | ERROR | [x] list(...) is forbidden, use [...] instead. 81 | WARNING | [ ] Unused variable $scheme. ----------------------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY ----------------------------------------------------------------------------------------------------------------------------------------------- FILE: /Users/interns/Demo-site/drupal-org-issues/web/modules/contrib/libraries/src/Plugin/libraries/Type/AssetLibraryType.php ---------------------------------------------------------------------------------------------------------------------------------------------- FOUND 2 ERRORS AFFECTING 2 LINES ---------------------------------------------------------------------------------------------------------------------------------------------- 6 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\libraries\ExternalLibrary\Asset\AssetLibrary. 12 | ERROR | [ ] Missing short description in doc comment ---------------------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ---------------------------------------------------------------------------------------------------------------------------------------------- FILE: /Users/interns/Demo-site/drupal-org-issues/web/modules/contrib/libraries/src/Plugin/libraries/Type/MultipleAssetLibraryType.php ------------------------------------------------------------------------------------------------------------------------------------- FOUND 5 ERRORS AFFECTING 5 LINES ------------------------------------------------------------------------------------------------------------------------------------- 12 | ERROR | Missing short description in doc comment 38 | ERROR | Missing short description in doc comment 39 | ERROR | Missing parameter comment 40 | ERROR | Missing parameter comment 42 | ERROR | Description for the @return value is missing ------------------------------------------------------------------------------------------------------------------------------------- FILE: /Users/interns/Demo-site/drupal-org-issues/web/modules/contrib/libraries/src/Plugin/libraries/Type/PhpFileLibraryType.php -------------------------------------------------------------------------------------------------------------------------------------------------- FOUND 2 ERRORS AFFECTING 2 LINES -------------------------------------------------------------------------------------------------------------------------------------------------- 8 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\libraries\ExternalLibrary\PhpFile\PhpFileLibrary. 13 | ERROR | [ ] Missing short description in doc comment -------------------------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY -------------------------------------------------------------------------------------------------------------------------------------------------- FILE: /Users/interns/Demo-site/drupal-org-issues/web/modules/contrib/libraries/src/Plugin/libraries/VersionDetector/StaticDetector.php -------------------------------------------------------------------------------------------------------------------------------------- FOUND 3 ERRORS AFFECTING 3 LINES -------------------------------------------------------------------------------------------------------------------------------------- 25 | ERROR | Missing parameter comment 26 | ERROR | Missing parameter comment 27 | ERROR | Missing parameter comment -------------------------------------------------------------------------------------------------------------------------------------- FILE: /Users/interns/Demo-site/drupal-org-issues/web/modules/contrib/libraries/src/Plugin/libraries/VersionDetector/LinePatternDetector.php ------------------------------------------------------------------------------------------------------------------------------------------- FOUND 4 ERRORS AFFECTING 4 LINES ------------------------------------------------------------------------------------------------------------------------------------------- 35 | ERROR | Missing parameter comment 36 | ERROR | Missing parameter comment 37 | ERROR | Missing parameter comment 38 | ERROR | Missing parameter comment ------------------------------------------------------------------------------------------------------------------------------------------- FILE: /Users/interns/Demo-site/drupal-org-issues/web/modules/contrib/libraries/src/StreamWrapper/LocalHiddenStreamTrait.php --------------------------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE --------------------------------------------------------------------------------------------------------------------------- 15 | ERROR | Description for the @return value is missing --------------------------------------------------------------------------------------------------------------------------- FILE: /Users/interns/Demo-site/drupal-org-issues/web/modules/contrib/libraries/src/StreamWrapper/LibraryDefinitionsStream.php ------------------------------------------------------------------------------------------------------------------------------------ FOUND 3 ERRORS AFFECTING 2 LINES ------------------------------------------------------------------------------------------------------------------------------------ 6 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Config\ConfigFactoryInterface. 88 | ERROR | [x] There must be exactly one blank line before the tags in a doc comment 88 | ERROR | [ ] Missing parameter type ------------------------------------------------------------------------------------------------------------------------------------ PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY ------------------------------------------------------------------------------------------------------------------------------------ FILE: /Users/interns/Demo-site/drupal-org-issues/web/modules/contrib/libraries/src/StreamWrapper/PrivateStreamTrait.php ----------------------------------------------------------------------------------------------------------------------- FOUND 2 ERRORS AFFECTING 2 LINES ----------------------------------------------------------------------------------------------------------------------- 20 | ERROR | [ ] Function return type is not void, but function has no return statement 25 | ERROR | [x] Visibility must be declared on method "getExternalUrl" ----------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ----------------------------------------------------------------------------------------------------------------------- Time: 1.52 secs; Memory: 14MB ➜ contribMoving this to RTBC since this issue only focuses on the t() calls issues.
Thank you.