Fix the issues reported by phpcs

I have solved the PHPCS errors.

Hi kalash-j,

Applied your changes on the MR !2, it applied successfully, however, there was still one error reported.

domain_entity_type git:(main) curl https://git.drupalcode.org/project/domain_entity_type/-/merge_requests/2.diff | patch -p1
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100 11136    0 11136    0     0  22993      0 --:--:-- --:--:-- --:--:-- 23643
patching file domain_entity_type.info.yml
patching file domain_entity_type.install
patching file modules/det_node/det_node.module
patching file modules/det_node/det_node.services.yml
patching file modules/det_node/src/Access/NodeTypeDomainAccessCheck.php
patching file modules/det_node/src/Controller/NodeControllerOverride.php
patching file modules/det_node/src/NodeTypeAccessOverride.php
patching file modules/det_node/src/NodeTypeListBuilderOverride.php
patching file modules/det_node/src/Routing/NodeRouteSubscriber.php
patching file src/Services/DomainEntityTypeManager.php
➜  domain_entity_type git:(main) ✗ cd ..
➜  contrib git:(master) ✗ phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig domain_entity_type

FILE: ...main_entity_type/modules/det_node/src/Access/NodeTypeDomainAccessCheck.php
--------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------
 55 | ERROR | [x] Multi-line function declarations must have a trailing comma
    |       |     after the last parameter
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------

Time: 406ms; Memory: 10MB

Kindly check

Thanks,
Jake

nilesh.addweb → made their first commit to this issue’s fork.

Hi,
I have fixed remaining phpcs issues, please review it.

The mentioned phpcs issue is resolved, & I have also checked and it is working as expected. I am attaching the Screenshots & doing RTBC for the same.

Hi, I've applied the provided MR as a patch and it applied cleanly with no errors. After applying the patch, the mentioned phpcs issue have been resolved successfully. However getting errors shown in the attached screenshot while clearing the cache command: drush cr. I've attached the screenshot for reference. As the new issue was encountered after applying the patch hence, moving the issue status to Needs work.

Hi @tirupati_singh ,

I'll work on a patch to solve those errors.

I've integrated PHPCS, PHPStan, and the necessary linters into the project's GitLab CI to ensure clean and consistent code for all future contributions. The fixes have been merged into the 1.0.x branch.

To apply these fixes in your projects before the next official release, you can run the following command:
composer require 'drupal/domain_entity_type:1.0.x-dev@dev'

Thank you, everyone!

b.khouy → closed merge request !2

kalash-j → changed the visibility of the branch 3459966-fix-the-issues to active.

kalash-j → changed the visibility of the branch 3459966-fix-the-issues to hidden.