- Issue created by @dev2.addweb
- Issue was unassigned.
- Status changed to Needs review
6 months ago 10:12am 10 July 2024 - š®š³India dev2.addweb
Hi I have fixed phpcs issues and created MR. Please review it.
- Status changed to Needs work
6 months ago 11:30am 10 July 2024 - š®š³India bhaveshdas
I applied MR!2 and I still encountered some issues after I ran vendor/bin/phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,js,info,txt,md,yml,twig modules/custom/simple_carousel-3460454/
FILE: /var/www/html/drupal-contri-d10/modules/custom/simple_carousel-3460454/README.txt --------------------------------------------------------------------------------------- FOUND 1 ERROR AND 8 WARNINGS AFFECTING 9 LINES --------------------------------------------------------------------------------------- 5 | WARNING | [ ] Line exceeds 80 characters; contains 417 characters 9 | WARNING | [ ] Line exceeds 80 characters; contains 85 characters 10 | WARNING | [ ] Line exceeds 80 characters; contains 89 characters 11 | WARNING | [ ] Line exceeds 80 characters; contains 112 characters 12 | WARNING | [ ] Line exceeds 80 characters; contains 103 characters 13 | WARNING | [ ] Line exceeds 80 characters; contains 82 characters 17 | WARNING | [ ] Line exceeds 80 characters; contains 236 characters 24 | WARNING | [ ] Line exceeds 80 characters; contains 87 characters 43 | ERROR | [x] Expected 1 newline at end of file; 2 found --------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY --------------------------------------------------------------------------------------- FILE: /var/www/html/drupal-contri-d10/modules/custom/simple_carousel-3460454/js/simple-carousel.js -------------------------------------------------------------------------------------------------- FOUND 2 ERRORS AFFECTING 2 LINES -------------------------------------------------------------------------------------------------- 28 | ERROR | [x] Expected 1 space after FUNCTION keyword; 0 found 41 | ERROR | [x] Expected 1 space after FUNCTION keyword; 0 found -------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY -------------------------------------------------------------------------------------------------- Time: 104ms; Memory: 10MB
- Status changed to Needs review
6 months ago 11:59am 10 July 2024 - š®š³India dev2.addweb
Hi,
I have fixed the error mentioned for the JavaScript file and committed the code.
Regarding the README.txt file, I have created an issue for this. It will be fixed in issue #3460485. š Replace README.txt to Readme.md file RTBC - Status changed to Needs work
6 months ago 12:55pm 10 July 2024 - šµšPhilippines cleavinjosh
Hi @nilesh.addweb,
I applied MR!2 and it was applied smoothly. It also fixed the issue with the js file.
After I ran
phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml
, these are the issues remaining.ā simple_carousel git:(main) ā curl https://git.drupalcode.org/project/simple_carousel/-/merge_requests/2.diff | patch -p1 % Total % Received % Xferd Average Speed Time Time Time Current Dload Upload Total Spent Left Speed 100 3458 0 3458 0 0 1032 0 --:--:-- 0:00:03 --:--:-- 1032 patching file css/simple-carousel.css patching file js/simple-carousel.js patching file simple_carousel.module patching file src/Plugin/views/style/SimpleCarousel.php ā simple_carousel git:(main) ā .. ā contrib git:(main) ā phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml simple_carousel FILE: /Users/interns/Demo-site/drupal-org-issues/web/modules/contrib/simple_carousel/simple_carousel.info.yml ------------------------------------------------------------------------------------------------------------- FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 1 LINE ------------------------------------------------------------------------------------------------------------- 1 | WARNING | Remove "project" from the info file, it will be added by drupal.org packaging automatically 1 | WARNING | Remove "datestamp" from the info file, it will be added by drupal.org packaging automatically 1 | WARNING | Remove "version" from the info file, it will be added by drupal.org packaging automatically ------------------------------------------------------------------------------------------------------------- FILE: /Users/interns/Demo-site/drupal-org-issues/web/modules/contrib/simple_carousel/README.txt ----------------------------------------------------------------------------------------------- FOUND 1 ERROR AND 8 WARNINGS AFFECTING 9 LINES ----------------------------------------------------------------------------------------------- 5 | WARNING | [ ] Line exceeds 80 characters; contains 417 characters 9 | WARNING | [ ] Line exceeds 80 characters; contains 85 characters 10 | WARNING | [ ] Line exceeds 80 characters; contains 89 characters 11 | WARNING | [ ] Line exceeds 80 characters; contains 112 characters 12 | WARNING | [ ] Line exceeds 80 characters; contains 103 characters 13 | WARNING | [ ] Line exceeds 80 characters; contains 82 characters 17 | WARNING | [ ] Line exceeds 80 characters; contains 236 characters 24 | WARNING | [ ] Line exceeds 80 characters; contains 87 characters 43 | ERROR | [x] Expected 1 newline at end of file; 2 found ----------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ----------------------------------------------------------------------------------------------- Time: 126ms; Memory: 10MB ā contrib git:(main) ā
Please check and advise.
Thank you. - Status changed to Needs review
6 months ago 1:37pm 10 July 2024 - š®š³India dev2.addweb
Hi @cleavinjosh,
Thanks for reviewing the MR.
Please refer to #5, where I mentioned that I've created a new issue for the README.txt file. This will be fixed in issue # 3460485 š Replace README.txt to Readme.md file RTBC .
Additionally, instead of installing the module through Composer, please install it by using git clone to avoid the info file issue.
- Status changed to RTBC
6 months ago 6:56am 12 July 2024 - š®š³India dev16.addweb
Hi,
I have tested the MR, and there are no errors except for the README.txt file. This will be fixed in the related issue #3460485 š Replace README.txt to Readme.md file RTBC . Therefore, I am moving this to RTBC