- Issue created by @deepakkm
- First commit to issue fork.
- Status changed to Needs review
5 months ago 10:12am 12 August 2024 - Status changed to RTBC
5 months ago 10:40am 12 August 2024 - 🇮🇳India deepak5423
Hi,
I have tested the MR !14.
All the issues of phpstan and phpcs are fixed.
Moving the issue to RTBC.Thanks.
- 🇮🇳India ankitv18
Validated on local with these changes ~~ functionalities are working fine
- Status changed to Needs work
5 months ago 6:18pm 12 August 2024 - 🇮🇳India vishalkhode
Requested some changes, hence moving it back to Needs Work. Also, let's not skip eslint and fix that as well. If that's a major change and required more changes, we can skip eslint and cslint for now and handle that in a separate ticket and limit this ticket for PHPCS and PHPStan fixes only.
- Status changed to Needs review
5 months ago 6:39am 13 August 2024 - 🇮🇳India vishalkhode
I ran the ESlint in local and it showed errors in
config_update_ui.settings.yml
file. I think we should handle & fix that in a separate ticket. So, I'm Ok, if we've skipped the ESlint job here, we can enable and fix those separately. Thanks. -
vishalkhode →
committed 9e950db1 on 2.0.x authored by
deepakkm →
Issue #3465396 by ankitv18, deepakkm, chaitanyadessai: Fix validate...
-
vishalkhode →
committed 9e950db1 on 2.0.x authored by
deepakkm →
- Status changed to Fixed
5 months ago 11:41am 13 August 2024 Automatically closed - issue fixed for 2 weeks with no activity.