Fix validate pipeline

Created on 2 August 2024, about 2 months ago
Updated 27 August 2024, about 1 month ago

Problem/Motivation

There are many phpstan issue and phpcs issues reported by gitlab CI, hence as per drupal standard these issues should be fixed.
https://git.drupalcode.org/issue/config_update-3452453/-/pipelines/241400

📌 Task
Status

Fixed

Version

2.0

Component

Other

Created by

🇮🇳India deepakkm

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @deepakkm
  • Merge request !14fix pipeline issues. → (Merged) created by deepakkm
  • Pipeline finished with Failed
    about 2 months ago
    Total: 148s
    #241678
  • Pipeline finished with Failed
    about 2 months ago
    Total: 145s
    #247447
  • Pipeline finished with Success
    about 2 months ago
    Total: 146s
    #247450
  • Pipeline finished with Success
    about 2 months ago
    Total: 147s
    #247455
  • Pipeline finished with Failed
    about 2 months ago
    Total: 148s
    #247502
  • Pipeline finished with Success
    about 2 months ago
    Total: 180s
    #247521
  • Pipeline finished with Success
    about 2 months ago
    Total: 183s
    #247613
  • Pipeline finished with Success
    about 2 months ago
    Total: 147s
    #247628
  • Pipeline finished with Success
    about 2 months ago
    Total: 2908s
    #247676
  • First commit to issue fork.
  • Pipeline finished with Failed
    about 2 months ago
    #251453
  • Pipeline finished with Failed
    about 2 months ago
    Total: 145s
    #251501
  • Pipeline finished with Success
    about 2 months ago
    Total: 172s
    #251516
  • Status changed to Needs review about 2 months ago
  • 🇮🇳India ankitv18

    Please review MR!14

  • Status changed to RTBC about 2 months ago
  • 🇮🇳India deepak5423

    Hi,

    I have tested the MR !14.
    All the issues of phpstan and phpcs are fixed.
    Moving the issue to RTBC.

    Thanks.

  • Pipeline finished with Failed
    about 2 months ago
    #251629
  • Pipeline finished with Success
    about 2 months ago
    Total: 201s
    #251640
  • 🇮🇳India ankitv18

    Validated on local with these changes ~~ functionalities are working fine


  • Pipeline finished with Success
    about 2 months ago
    Total: 170s
    #251720
  • Pipeline finished with Canceled
    about 2 months ago
    Total: 113s
    #251761
  • Pipeline finished with Canceled
    about 2 months ago
    Total: 104s
    #251765
  • Pipeline finished with Success
    about 2 months ago
    Total: 156s
    #251766
  • Status changed to Needs work about 2 months ago
  • 🇮🇳India vishalkhode

    Requested some changes, hence moving it back to Needs Work. Also, let's not skip eslint and fix that as well. If that's a major change and required more changes, we can skip eslint and cslint for now and handle that in a separate ticket and limit this ticket for PHPCS and PHPStan fixes only.

  • Pipeline finished with Failed
    about 2 months ago
    Total: 188s
    #252330
  • Pipeline finished with Success
    about 2 months ago
    Total: 162s
    #252370
  • Pipeline finished with Success
    about 2 months ago
    Total: 171s
    #252377
  • Status changed to Needs review about 2 months ago
  • 🇮🇳India ankitv18

    Addressed the MR feedback, hence moving into review.

  • 🇮🇳India vishalkhode

    I ran the ESlint in local and it showed errors in config_update_ui.settings.yml file. I think we should handle & fix that in a separate ticket. So, I'm Ok, if we've skipped the ESlint job here, we can enable and fix those separately. Thanks.

  • Pipeline finished with Success
    about 2 months ago
    Total: 145s
    #252529
  • Pipeline finished with Skipped
    about 2 months ago
    #252550
  • Pipeline finished with Skipped
    about 2 months ago
    #252645
  • Status changed to Fixed about 2 months ago
  • Automatically closed - issue fixed for 2 weeks with no activity.

Production build 0.71.5 2024