Gitlab CI: fix eslint

please review

Merge error. Make sure to pull 4.0.x branch

git pull origin 4.0.x

and resolve conflicts.

please review

Hi, as there is no eslint issues and pipeline is Green for eslint hence moving the issue status to RTBC.

• New JS functionality are not explained or commented.
• JS: function moved but no comments added.
• eslint is still in red.

Changes look good.
Tested.
Ready for release.

Thanks for your contribution!

Committed! Thank you all! 🍻

Automatically closed - issue fixed for 2 weeks with no activity.

This has broken the shorthand module completely and stories can no longer be selected.

if (option.value == 0) {

was changed to:

if (option.value === 0) {

However the zero is actually a string so now it fails to be excluded and then causes the following error
TypeError: Cannot read properties of undefined (reading 'description'), so either need to be changed back or changed to === '0'

While this part is being addressed, we shouldn't be excluding zero anyway. Once a story has been selected, there is currently no way to unselect all stories and set it back to 0 The field doesn't have to be set as a a required nor should it have to be be.

The code also has a hardcoded field name in it, which is just not acceptable in a Drupal module. Users should be free to name their fields as they wish.

I'll create a new issue for all of the above, but just putting it here, incase people are wondering why this issue has broken something

Thanks for reporting @paulmartin84.
Committing now.