- Issue created by @Eli-T
- @eli-t opened merge request.
- Status changed to Postponed
over 1 year ago 8:59am 11 August 2023 - 🇬🇧United Kingdom Eli-T Manchester
I can't currently run pipelines as @pol has not granted me administer maintainers permission on this repo. I have contacted them today on their contact form to ask them to rectify this, but until that happens, or the DA complete the work to enable those without this permission to run pipelines on forks, this is postponed.
- Status changed to Needs review
over 1 year ago 12:32pm 11 August 2023 - 🇬🇧United Kingdom Eli-T Manchester
Embarrassingly you can run Gitlab CI Pipelines without 'administer maintainers', so long as you use the correct name for your Gitlab CI file.
So unpostponing this!
- Status changed to Needs work
over 1 year ago 9:42am 12 August 2023 - 🇬🇧United Kingdom Eli-T Manchester
Tests are currently failing because the test module is not marked as D10 compatible.
- 🇬🇧United Kingdom Eli-T Manchester
PHPUnit now passes - note this is just a single test that asserts the module installs.
However there are issues in eslint, phpcs and stylint we should consider fixing.
- Status changed to Needs review
over 1 year ago 5:02pm 13 August 2023 - Status changed to RTBC
3 months ago 1:34pm 6 August 2024 - 🇮🇳India deepak5423
Hi,
The added gilab-ci files look good to me and all the tests are also getting passed.
Moving the issue to RTBC.Thanks.
- Status changed to Needs work
about 1 month ago 3:01pm 15 October 2024 - 🇬🇧United Kingdom Eli-T Manchester
The pipeline did pass a year ago, but rerunning it now results in failure at the build stage.
https://git.drupalcode.org/project/views_ef_fieldset/-/jobs/3058636
- 🇬🇧United Kingdom Eli-T Manchester
CI is now passing again with the exception of PHPStan, which is complaining about the following
------ ----------------------------------------------------------------------- Line src/ArrayDataItemIterator.php ------ ----------------------------------------------------------------------- 18 Return type mixed of method Drupal\views_ef_fieldset\ArrayDataItemIterator::getChildren() is not covariant with tentative return type RecursiveIterator|null of method RecursiveIterator::getChildren(). 💡 Make it covariant, or use the #[\ReturnTypeWillChange] attribute to temporarily suppress the error. 30 Return type mixed of method Drupal\views_ef_fieldset\ArrayDataItemIterator::hasChildren() is not covariant with tentative return type bool of method RecursiveIterator::hasChildren(). 💡 Make it covariant, or use the #[\ReturnTypeWillChange] attribute to temporarily suppress the error. ------ -----------------------------------------------------------------------
- 🇬🇧United Kingdom Eli-T Manchester
All CI now passes.
I would very much appreciate any review/manual testing from other users of this module. The automated tests are currently somewhat limited.