Created on 11 August 2023, over 1 year ago

Problem/Motivation

https://www.drupal.org/docs/develop/git/using-gitlab-to-contribute-to-dr...

Gitlab CI is now available.
Drupal CI will ultimately be turned off.

Whilst we're not using Drupal CI at the moment, we can use Gitlab CI to run PHPCS, ESLint, Composer Lint and the single installation test this module currently has.

Steps to reproduce

N/A

Proposed resolution

Adapt the Drupal Association provided template to use Gitlab CI for this module.

Remaining tasks

  • adopt Gitlab CI

User interface changes

None.

API changes

None.

Data model changes

None.

📌 Task
Status

Active

Version

1.0

Component

Code

Created by

🇬🇧United Kingdom Eli-T Manchester

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

  • Issue created by @Eli-T
  • @eli-t opened merge request.
  • Status changed to Postponed over 1 year ago
  • 🇬🇧United Kingdom Eli-T Manchester

    I can't currently run pipelines as @pol has not granted me administer maintainers permission on this repo. I have contacted them today on their contact form to ask them to rectify this, but until that happens, or the DA complete the work to enable those without this permission to run pipelines on forks, this is postponed.

  • Status changed to Needs review over 1 year ago
  • 🇬🇧United Kingdom Eli-T Manchester

    Embarrassingly you can run Gitlab CI Pipelines without 'administer maintainers', so long as you use the correct name for your Gitlab CI file.

    So unpostponing this!

  • Status changed to Needs work over 1 year ago
  • 🇬🇧United Kingdom Eli-T Manchester

    Tests are currently failing because the test module is not marked as D10 compatible.

  • 🇬🇧United Kingdom Eli-T Manchester

    PHPUnit now passes - note this is just a single test that asserts the module installs.

    However there are issues in eslint, phpcs and stylint we should consider fixing.

  • Status changed to Needs review over 1 year ago
  • 🇬🇧United Kingdom Eli-T Manchester

    All pipeline stages now pass.

  • Status changed to RTBC 3 months ago
  • 🇮🇳India deepak5423

    Hi,

    The added gilab-ci files look good to me and all the tests are also getting passed.
    Moving the issue to RTBC.

    Thanks.

  • Status changed to Needs work about 1 month ago
  • 🇬🇧United Kingdom Eli-T Manchester

    The pipeline did pass a year ago, but rerunning it now results in failure at the build stage.

    https://git.drupalcode.org/project/views_ef_fieldset/-/jobs/3058636

  • 🇬🇧United Kingdom Eli-T Manchester

    CI is now passing again with the exception of PHPStan, which is complaining about the following

     ------ ----------------------------------------------------------------------- 
      Line   src/ArrayDataItemIterator.php                                          
     ------ ----------------------------------------------------------------------- 
      18     Return type mixed of method                                            
             Drupal\views_ef_fieldset\ArrayDataItemIterator::getChildren() is not   
             covariant with tentative return type RecursiveIterator|null of method  
             RecursiveIterator::getChildren().                                      
             💡 Make it covariant, or use the #[\ReturnTypeWillChange] attribute    
                to temporarily suppress the error.                                  
      30     Return type mixed of method                                            
             Drupal\views_ef_fieldset\ArrayDataItemIterator::hasChildren() is not   
             covariant with tentative return type bool of method                    
             RecursiveIterator::hasChildren().                                      
             💡 Make it covariant, or use the #[\ReturnTypeWillChange] attribute    
                to temporarily suppress the error.                                  
     ------ ----------------------------------------------------------------------- 
  • 🇬🇧United Kingdom Eli-T Manchester

    All CI now passes.

    I would very much appreciate any review/manual testing from other users of this module. The automated tests are currently somewhat limited.

  • 🇬🇧United Kingdom Eli-T Manchester
  • Automatically closed - issue fixed for 2 weeks with no activity.

Production build 0.71.5 2024