Fix the issues reported by phpcs

Fixed the phpcs issues in this patch.

Hi @Neha-Verma,

Applied your patch, patch #3 had 1 file that did not apply successfully, it threw multiple errors from multiple files too.

pagination_manager git:(1.0.x) curl https://www.drupal.org/files/issues/2023-07-07/fix-phpcs-issue-3370004.patch | patch -p1
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100 46124  100 46124    0     0   124k      0 --:--:-- --:--:-- --:--:--  128k
patching file README.md
patching file config/schema/pagination_manager.schema.yml
patching file pagination_manager.module
Hunk #1 FAILED at 1.
1 out of 1 hunk FAILED -- saving rejects to file pagination_manager.module.rej
patching file src/Configuration.php
patching file src/Exception/BadFilterException.php
patching file src/Exception/EntityTypeNotSupportedException.php
patching file src/Exception/PaginationException.php
patching file src/Exception/SortAttributeNotAvailableException.php
patching file src/Filter.php
patching file src/Form/PaginationManagerConfigForm.php
patching file src/Page.php
patching file src/PaginationManager.php
patching file src/Query.php
patching file tests/src/Unit/PaginationManagerTest.php
➜  pagination_manager git:(1.0.x) ✗ cd ..
➜  contrib git:(main) ✗ phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig pagination_manager

FILE: /Users/PrometInterns/Demo-site/drupal-orgissue/web/modules/contrib/pagination_manager/pagination_manager.module
------------------------------------------------------------------------------------------------------------------------------
FOUND 4 ERRORS AFFECTING 4 LINES
------------------------------------------------------------------------------------------------------------------------------
  1 | ERROR | [x] Missing file doc comment
  6 | ERROR | [x] Missing function doc comment
 10 | ERROR | [x] Multi-line function declarations must have a trailing comma after the last parameter
 12 | ERROR | [x] The closing parenthesis and the opening brace of a multi-line function declaration must be on the same line
------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 4 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------------------------------------------------------


FILE: /Users/PrometInterns/Demo-site/drupal-orgissue/web/modules/contrib/pagination_manager/src/Filter.php
----------------------------------------------------------------------------------------------------------
FOUND 6 ERRORS AFFECTING 5 LINES
----------------------------------------------------------------------------------------------------------
 52 | ERROR | [x] Multi-line function declaration not indented correctly; expected 4 spaces but found 8
 53 | ERROR | [x] Multi-line function declaration not indented correctly; expected 4 spaces but found 8
 54 | ERROR | [x] Multi-line function declaration not indented correctly; expected 4 spaces but found 8
 55 | ERROR | [x] Multi-line function declaration not indented correctly; expected 4 spaces but found 8
 55 | ERROR | [x] Multi-line function declarations must have a trailing comma after the last parameter
 56 | ERROR | [x] Multi-line function declaration not indented correctly; expected 2 spaces but found 4
----------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 6 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------------------------------------------


FILE: /Users/PrometInterns/Demo-site/drupal-orgissue/web/modules/contrib/pagination_manager/src/Page.php
--------------------------------------------------------------------------------------------------------
FOUND 10 ERRORS AFFECTING 9 LINES
--------------------------------------------------------------------------------------------------------
 86 | ERROR | [x] Multi-line function declaration not indented correctly; expected 4 spaces but found 8
 87 | ERROR | [x] Multi-line function declaration not indented correctly; expected 4 spaces but found 8
 88 | ERROR | [x] Multi-line function declaration not indented correctly; expected 4 spaces but found 8
 89 | ERROR | [x] Multi-line function declaration not indented correctly; expected 4 spaces but found 8
 90 | ERROR | [x] Multi-line function declaration not indented correctly; expected 4 spaces but found 8
 91 | ERROR | [x] Multi-line function declaration not indented correctly; expected 4 spaces but found 8
 92 | ERROR | [x] Multi-line function declaration not indented correctly; expected 4 spaces but found 8
 93 | ERROR | [x] Multi-line function declaration not indented correctly; expected 4 spaces but found 8
 93 | ERROR | [x] Multi-line function declarations must have a trailing comma after the last parameter
 94 | ERROR | [x] Multi-line function declaration not indented correctly; expected 2 spaces but found 4
--------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 10 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------------------------------


FILE: /Users/PrometInterns/Demo-site/drupal-orgissue/web/modules/contrib/pagination_manager/src/Query.php
---------------------------------------------------------------------------------------------------------
FOUND 11 ERRORS AFFECTING 10 LINES
---------------------------------------------------------------------------------------------------------
 117 | ERROR | [x] Multi-line function declaration not indented correctly; expected 4 spaces but found 8
 118 | ERROR | [x] Multi-line function declaration not indented correctly; expected 4 spaces but found 8
 119 | ERROR | [x] Multi-line function declaration not indented correctly; expected 4 spaces but found 8
 120 | ERROR | [x] Multi-line function declaration not indented correctly; expected 4 spaces but found 8
 121 | ERROR | [x] Multi-line function declaration not indented correctly; expected 4 spaces but found 8
 122 | ERROR | [x] Multi-line function declaration not indented correctly; expected 4 spaces but found 8
 123 | ERROR | [x] Multi-line function declaration not indented correctly; expected 4 spaces but found 8
 124 | ERROR | [x] Multi-line function declaration not indented correctly; expected 4 spaces but found 8
 125 | ERROR | [x] Multi-line function declaration not indented correctly; expected 4 spaces but found 8
 125 | ERROR | [x] Multi-line function declarations must have a trailing comma after the last parameter
 126 | ERROR | [x] Multi-line function declaration not indented correctly; expected 2 spaces but found 4
---------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 11 MARKED SNIFF VIOLATIONS AUTOMATICALLY
---------------------------------------------------------------------------------------------------------

Time: 318ms; Memory: 10MB

Kindly check.

Thanks,
Jake

Arijit Acharya → made their first commit to this issue’s fork.

Fixed the phpcs issues. Please review and merge.

Hi @Arijit Acharya,

Applied your changes in MR !1 successfully, confirmed no errors thrown.

pagination_manager git:(1.0.x) ✗ curl https://git.drupalcode.org/project/pagination_manager/-/merge_requests/1.diff | patch -p1
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100 53365    0 53365    0     0  83345      0 --:--:-- --:--:-- --:--:-- 85247
patching file README.md
patching file config/schema/pagination_manager.schema.yml
patching file pagination_manager.module
patching file src/Configuration.php
patching file src/Exception/BadFilterException.php
patching file src/Exception/EntityTypeNotSupportedException.php
patching file src/Exception/PaginationException.php
patching file src/Exception/SortAttributeNotAvailableException.php
patching file src/Filter.php
patching file src/Form/PaginationManagerConfigForm.php
patching file src/Page.php
patching file src/PaginationManager.php
patching file src/Query.php
patching file tests/src/Unit/PaginationManagerTest.php
➜  pagination_manager git:(1.0.x) ✗ cd ..
➜  contrib git:(main) ✗ phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig pagination_manager
zsh: command not found: phpcs
➜  contrib git:(main) ✗ export PATH="$PATH:$HOME/.composer/vendor/squizlabs/php_codesniffer/bin"
➜  contrib git:(main) ✗ phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig pagination_manager
➜  contrib git:(main) ✗

Will move to RTBC.

Thanks,
Jake