- Issue created by @mrinalini9
- Issue was unassigned.
- Status changed to Needs review
about 2 years ago 7:42am 1 February 2023 - ๐ฎ๐ณIndia mrinalini9 New Delhi
Added patch for the above fixes here, please review it.
- Status changed to Needs work
about 2 years ago 10:41am 1 February 2023 - ๐ฎ๐ณIndia arisen Goa
Reviewed the patch on 3.0.x branch. The patch is applying cleanly but getting additional code standards error.
FILE: ...color_field/src/Plugin/Field/FieldFormatter/ColorFieldFormatterCss.php ---------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ---------------------------------------------------------------------------------------------------------- 70 | ERROR | Unknown type hint "mixed" found for $plugin_definition ---------------------------------------------------------------------------------------------------------- Time: 921ms; Memory: 12MB
- Status changed to Needs review
about 2 years ago 10:10am 16 February 2023 - First commit to issue fork.
- Assigned to urvashi_vora
- Status changed to Needs work
about 2 years ago 10:29am 1 March 2023 - ๐ฎ๐ณIndia urvashi_vora Madhya Pradesh, India
Reviewed and Tested Patch 3338149-4.patch.
The patch applied smoothly
urvasi@urvasi-Inspiron-15-3552:/var/www/html/contribution/drupal/web/modules/contrib/color_field-3338149$ git apply -v 3338149-4.patch Checking patch src/ColorHex.php... Checking patch src/Plugin/Field/FieldFormatter/ColorFieldFormatterCss.php... Checking patch tests/src/Functional/ColorFieldFormatterTest.php... Checking patch tests/src/Functional/ColorFieldFormatterTokenTest.php... Checking patch tests/src/Functional/ColorFieldWidgetTest.php... Applied patch src/ColorHex.php cleanly. Applied patch src/Plugin/Field/FieldFormatter/ColorFieldFormatterCss.php cleanly. Applied patch tests/src/Functional/ColorFieldFormatterTest.php cleanly. Applied patch tests/src/Functional/ColorFieldFormatterTokenTest.php cleanly. Applied patch tests/src/Functional/ColorFieldWidgetTest.php cleanly.
Still there are a few issues left, which can fixed by phpcbf, I will fix them and create a MR.
- Issue was unassigned.
- Status changed to Needs review
about 2 years ago 10:30am 1 March 2023 - ๐ฎ๐ณIndia urvashi_vora Madhya Pradesh, India
Fixed all the issue, Please review.
urvasi@urvasi-Inspiron-15-3552:/var/www/html/contribution/drupal/web/modules/contrib$ phpcbf --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,js,info,txt,md,yml,twig color_field-3338149/ PHPCBF RESULT SUMMARY -------------------------------------------------------------------------------- FILE FIXED REMAINING -------------------------------------------------------------------------------- ...olor_field-3338149/js/color_field_widget_spectrum.jquery.js 1 0 ...es/contrib/color_field-3338149/js/color_field_widget_box.js 2 0 -------------------------------------------------------------------------------- A TOTAL OF 3 ERRORS WERE FIXED IN 2 FILES -------------------------------------------------------------------------------- Time: 2.55 secs; Memory: 12MB
- Merge request !13Issue #3338149: Fix the issues reported by phpcs โ (Open) created by urvashi_vora
- Status changed to RTBC
almost 2 years ago 2:27am 9 June 2023 - ๐ต๐ญPhilippines paraderojether
I reviewed MR!13, and applied it against Color Field 3.0.x-dev cleanly and confirmed it fixes all the issues reported by phpcs.
I added screenshots for reference.
Thank You. - Status changed to Needs work
almost 2 years ago 7:50am 9 June 2023 - First commit to issue fork.
- last update
over 1 year ago Composer require failure - ๐ฎ๐นItaly apaderno Brescia, ๐ฎ๐น
The MR is still using
NULL
andTRUE
in JavaScript files, while they are used in PHP code. In JavaScript, it is correct to usenull
andtrue
. - First commit to issue fork.
- last update
over 1 year ago Composer require failure - Status changed to Needs review
over 1 year ago 12:11pm 2 January 2024 - Status changed to Needs work
about 1 year ago 3:48pm 7 January 2024 - last update
about 1 year ago Composer require failure - Status changed to Needs review
about 1 year ago 2:22pm 17 January 2024 - ๐ท๐บRussia zniki.ru
Please remove changes that is not necessary, and not marked as violation by phpcs report.
- Status changed to Needs work
about 1 year ago 10:11am 18 January 2024 - last update
about 1 year ago Composer require failure Arijit Acharya โ made their first commit to this issueโs fork.
- Merge request !223338149-fix-phpcs-issue: Resolving the errors thrown by phpcs. โ (Open) created by arijit acharya
- last update
about 1 year ago Composer require failure Added a MR which resolves the errors thrown by phpcs.
Please review and merge.- last update
about 1 year ago Composer require failure - Status changed to Needs review
about 1 year ago 6:09am 7 February 2024 - last update
10 months ago 9 pass - Status changed to RTBC
10 months ago 6:35am 10 June 2024 - ๐ฎ๐ณIndia dev16.addweb
Hi, I have tested MR 22. There are no remaining issues. Moving to RTBC.
addweb@addweb-HP-ZBook-15-G2:~$ .config/composer/vendor/squizlabs/php_codesniffer/bin/phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,info,txt,md,yml,css Drupal8-vagrant/web/web/contribution/drupal-10-3/web/modules/custom/color_field/ addweb@addweb-HP-ZBook-15-G2:~$
- ๐ฎ๐นItaly apaderno Brescia, ๐ฎ๐น
apaderno โ changed the visibility of the branch 3338149-fix-the-issues to hidden.
- ๐ฎ๐นItaly apaderno Brescia, ๐ฎ๐น
apaderno โ changed the visibility of the branch 3.0.x to hidden.
- last update
10 months ago 9 pass - last update
10 months ago 9 pass - Status changed to Closed: outdated
10 months ago 7:11am 10 June 2024 - ๐ฎ๐นItaly apaderno Brescia, ๐ฎ๐น
GitLAb CI does not report any PHP_CodeSniffer warning/error that should be fixed.