kristiaanvandeneynde → credited Adil_Siddiqui → .
Patch created
Patch created
Patch updated with both the above issues resolved.
Patch created
Patch created
Patch created
Patch created
MR reviewed and it is working fine...Marking as RTBC
Patch created
Patch created
Patch #2 applied successfully...Marking as RTBC
Patch applied successfully and all the errors got resolved...Marking as RTBC
Patch created.
Patch created
MR reviewed and it is working fine...Marking as RTBC
Yes it needs to be corrected as well....Providing updated patch with changes at both the lines
Patch created
Patch created
Patch created
Since MR is merged, closing the issue and marking it as Fixed.
MR reviewed and it is working fine...Marking as RTBC
MR !21 created ..Please review
Adil_Siddiqui → made their first commit to this issue’s fork.
MR !1 created...Please review
Adil_Siddiqui → made their first commit to this issue’s fork.
Patch created
Patch applied successfully and all the warnings specified are resolved...Marking as RTBC
MR created....Please review
Adil_Siddiqui → made their first commit to this issue’s fork.
Patch applied successfully and solved the issues specified...Marking as RTBC
Updated patch..ignore previous patch
Patch created
Patch created
Patch created
Patch reviewed and it is working fine....Makring as RTBC
Patch #2 failed to apply but patch #3 applied successfully...Marking as RTBC
MR reviewed and it is working fine... Marking as RTBC
MR reviewed and it is working fine....Marking as RTBC
Patch created
Patch created
MR reviewed and it is working fine....Marking as RTBC
Patch created
MR reviewed and it is working fine...Marking as RTBC.
Patch created
MR reviewed and it is working fine..Marking as RTBC
MR reviewed and it is working fine..Marking as RTBC
Patch created
Adil_Siddiqui → made their first commit to this issue’s fork.
Updated patch...ignore previous patch
Please review
It is fixed in 1.0.x branch
Adil_Siddiqui → made their first commit to this issue’s fork.
MR reviewed and it is working fine..Marking as RTBC
MR reviewed and it is working fine..Marking as RTBC
MR reviewed and it is working fine....Marking as RTBC.
MR reviewed and it is working fine..Marking as RTBC
Patch reviewed and it is working fine...Marking as RTBC.
Patch created
Patch created
MR reviewed and it is working fine...Marking as RTBC.
MR reviewed and it is working fine..Marking as RTBC.
MR reviewed and it is working fine..Marking as RTBC.
Patch created
Patch reviewed and it is working fine...marking as RTBC.
MR reviewed and it is working fine...Marking as RTBC.
MR reviewed and it is working fine...Marking as RTBC.
Patch created...Please review
Patch created
MR reviewed and it working fine...Marking as RTBC
MR reviewed and it is looking fine ...Marking as RTBC
Reviewed and it is working fine..Marking as RTBC
The below variable is not required as it is just declared and not used anywhere hence it is removed in the patch.
- $entity_display_repository = \Drupal::service('entity_display.repository');
-Patch created
MR reviewed and it is. working fine...Marking as RTBC.
MR reviewed and it is working fine....Marking as RTBC
MR reviewed and it is working fine...Marking as RTBC
Patch created
Patch created to solve #3 issues.
Below t() call is still left in
FILE: /Users/adil.shiddiqui/drupal9/web/modules/contrib/augmentor/src/Plugin/Field/FieldWidget/AugmentorBaseWidget.php
306 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
Also other phpcs errors is also present:
FILE: /Users/adil.shiddiqui/drupal9/web/modules/contrib/augmentor/src/Plugin/Field/FieldWidget/AugmentorBaseWidget.php
------------------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 4 WARNINGS AFFECTING 4 LINES
------------------------------------------------------------------------------------------------------------------------------------------
74 | WARNING | Unused variable $yolo.
87 | WARNING | File::load calls should be avoided in classes, use dependency injection instead
306 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
367 | WARNING | Unused variable $field_name.
------------------------------------------------------------------------------------------------------------------------------------------
FILE: /Users/adil.shiddiqui/drupal9/web/modules/contrib/augmentor/src/Plugin/Field/FieldWidget/AugmentorWidget.php
------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 3 LINES
------------------------------------------------------------------------------------------------------------------
82 | WARNING | Unused variable $yolo.
94 | WARNING | File::load calls should be avoided in classes, use dependency injection instead
324 | WARNING | Unused variable $field_name.
------------------------------------------------------------------------------------------------------------------
FILE: /Users/adil.shiddiqui/drupal9/web/modules/contrib/augmentor/src/Plugin/Field/FieldFormatter/AugmentorFormatter.php
------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES
------------------------------------------------------------------------------------------------------------------------
64 | WARNING | Unused variable $debug.
65 | WARNING | Unused variable $entity.
------------------------------------------------------------------------------------------------------------------------
Patch reviewed and it is working fine...Marking as RTBC
Patch created
MR reviewed and it is working fine...Marking as RTBC
MR reviewed and it is working fine..Marking as RTBC
MR reviewed and it is working fine..Marking as RTBC
Patch #2 applied successfully and MR also reviewed....RTBC
Patch created
MR reviewed and it is working fine...RTBC